Commit Graph

119 Commits

Author SHA1 Message Date
Rich
7c23e01e31
feat(aws): always create AAAA alias records in route53 (#5111)
* First pass based on existing PR, what is currently on master and some
extra tests.

* Try to resolve AWS service documentation

* Add documentation on how to opt-out of AAAA record creation

* Address documentation concerns

* Add some IPv6 tests to sources

* Make recommended changes to documentation
2025-03-03 00:21:00 -08:00
Kubernetes Prow Robot
0e8f84662b
Merge pull request #4871 from Demonware/pdns-validate-mx-srv
feat(pdns): add validation for MX and SRV records
2025-02-24 23:32:30 -08:00
Julilla Paul
f593c08aa9
chore: refactor CheckEndpoint into helper functions 2025-02-10 11:46:55 -08:00
Julilla Paul
3b2453bc1a
chore: add debug logs and make integer parsing strict 2025-02-10 11:35:07 -08:00
Julilla Paul
10f4a26184
chore: make CheckEndpoint an Endpoint type method 2025-02-10 11:20:39 -08:00
Ivan Ka
70cbcd1314
test(domain-filter): simple filters on domain exclusion (#5064)
* issue(filter-tags): issue-3718 domain exclusion filters

Signed-off-by: ivan katliarchuk <ivan.katliarchuk@gmail.com>

* issue(filter-tags): issue-3718 domain exclusion filters

Signed-off-by: ivan katliarchuk <ivan.katliarchuk@gmail.com>

* issue(filter-tags): issue-3718 domain exclusion filters

Signed-off-by: ivan katliarchuk <ivan.katliarchuk@gmail.com>

* Apply suggestions from code review

Co-authored-by: Michel Loiseleur <97035654+mloiseleur@users.noreply.github.com>

---------

Signed-off-by: ivan katliarchuk <ivan.katliarchuk@gmail.com>
Co-authored-by: Michel Loiseleur <97035654+mloiseleur@users.noreply.github.com>
2025-02-10 01:15:58 -08:00
Kubernetes Prow Robot
290f8c848d
Merge pull request #4980 from gofogo/fix-aes-4976
fix(aes-encryption): support plain txt and url safe base64 strings
2025-01-23 01:06:57 -08:00
Michel Loiseleur
5561d916b1 refactor test following review 2025-01-19 12:16:41 +01:00
Michel Loiseleur
cc546820dc chore(ci): fix failing test, upgrade to go 1.23.5 and linter to v1.63 2025-01-17 21:05:08 +01:00
ivan katliarchuk
41cea23fff
fix(aes-encryption): labels.Serialize cover case when GenerateNonce errors
Signed-off-by: ivan katliarchuk <ivan.katliarchuk@gmail.com>
2024-12-29 13:10:02 +00:00
ivan katliarchuk
ca517446cc
fix(aes-encryption): crypto.GenerateNonce write tests
Signed-off-by: ivan katliarchuk <ivan.katliarchuk@gmail.com>
2024-12-29 12:57:01 +00:00
ivan katliarchuk
f8777a0ab2
fix(aes-encryption): labels.Serialise cover case when encryption failed
Signed-off-by: ivan katliarchuk <ivan.katliarchuk@gmail.com>
2024-12-29 12:44:51 +00:00
ivan katliarchuk
842ecee70a
fix(aes-encryption): labels.Serialise cover case when encryption failed
Signed-off-by: ivan katliarchuk <ivan.katliarchuk@gmail.com>
2024-12-29 12:43:48 +00:00
ivan katliarchuk
7c62eba9c2
fix(aes-encryption): labels.Serialise cover case when encryption failed
Signed-off-by: ivan katliarchuk <ivan.katliarchuk@gmail.com>
2024-12-29 12:41:30 +00:00
Julilla Paul
ad9f300589
chore: move validation to endpoint 2024-11-20 13:46:57 -08:00
Thibault Jamet
b2ff1619f5
Add Domain filter interface 2024-08-14 10:20:59 +02:00
Morre
c0a183b006
fix: re-add api-approved.kubernetes.io annotation 2024-05-21 09:27:03 +02:00
Leonardo Quatrocchi
08e917751b bugfix: add clarification to endpoint unit tests 2024-05-11 20:54:25 -03:00
Leonardo Quatrocchi
05ca35e228 Merge remote-tracking branch 'origin/master' into bugfix/group-endpoints-per-hosted-zone-for-aws 2024-04-22 20:36:38 -03:00
dongjiang1989
f3c1e32930
add unittest casae
Signed-off-by: dongjiang1989 <dongjiang1989@126.com>
2024-04-09 09:34:58 +08:00
dongjiang
b5ef2fc913
Update endpoint/endpoint.go
Co-authored-by: Michel Loiseleur <97035654+mloiseleur@users.noreply.github.com>
2024-04-07 09:44:08 +08:00
Leonardo Quatrocchi
d9b743922a Specify and clarify root cause of issue 4241 2024-04-06 03:25:05 -03:00
Leonardo Quatrocchi
4fb2f2e283 Specific bugfix near the root cause for duplicated deletes on plan.go 2024-04-05 01:29:38 -03:00
Leonardo Quatrocchi
deba1ea445 Fix suggestions 2024-04-04 21:15:48 -03:00
leonardocaylent
3ca4d0250f
Update endpoint/endpoint.go
Co-authored-by: Eric Bailey <yurrriq@users.noreply.github.com>
2024-04-04 16:35:21 -03:00
Leonardo Quatrocchi
6066b700b8 Fix for duplicated endpoints 2024-04-04 01:24:05 -03:00
dongjiang1989
dc9e0a5816
dongjiang, fix ipv6 shortener and expander equal
Signed-off-by: dongjiang1989 <dongjiang1989@126.com>
2024-03-31 19:51:28 +08:00
Leonardo Quatrocchi
2b3da1b608 Fix for duplicated endpoints and unit tests 2024-03-29 23:27:25 -03:00
Leonardo Quatrocchi
7fe2d3f069 Fix for duplicated endpoints and unit tests 2024-03-29 03:39:17 -03:00
Leonardo Quatrocchi
82046ccb15 Removing comments and clean up 2024-03-16 15:05:59 -03:00
Leonardo Quatrocchi
0ca279694a Fix Lint 2024-03-16 11:41:26 -03:00
leonardocaylent
30c9e77765
Fix lint 2024-03-16 00:00:00 -03:00
leonardocaylent
a3826d541b
Update endpoint.go with Key function 2024-03-15 22:56:02 -03:00
Leonardo Quatrocchi
294b4c673e Fix format on aws and endpoint files 2024-03-05 02:35:13 -03:00
Leonardo Quatrocchi
846f4b40fa Going back to endpoint.go 2024-03-05 02:27:20 -03:00
Kubernetes Prow Robot
4dc15d917e
Merge pull request #4212 from jstudler/master
Fixing NAPTR support
2024-02-29 10:00:59 -08:00
thiagoluiznunes
70835ab7bd feat(aws-provider): create flag to support sub-domains match parent
The current implementation of external-dns from sig-external-dns does
not support domain filtering (--domain-filter) for sub-domains on Route53,
such as test.sub-domain.domain.com. The function MatchParent was recently
removed from the base code, but it is still necessary for this purpose.
An example of a use case for this support is having a cluster per hosted
zone with a hundred ingress related to that zone with different variants of
sub-domains. With the matchParent function and zone-match-parent flag,
external-dns will now support an extended automatic match for sub-domains.
2024-02-06 10:33:01 -03:00
Joel Studler
2fdc7354c0 Add unit tests for NAPTR and invalid endpoints 2024-01-27 13:16:53 +01:00
Seweryn Chlewicki
66b5b250fa
Make the nonce stable when generating delete records 2023-10-05 20:07:41 +01:00
Kubernetes Prow Robot
030342f445
Merge pull request #3747 from cronik/bugfix/dual-stack-records
Fix planning for multi-cluster dual stack record types
2023-09-14 22:24:12 -07:00
Kubernetes Prow Robot
0a6574a982
Merge pull request #3860 from johngmyers/refactor
Remove DomainFilterInterface
2023-09-01 07:54:50 -07:00
Kyle Cronin
20bff0aae5 Remove EndpointFilterInterface 2023-08-16 23:48:30 -04:00
Kyle Cronin
7fb144d8d8 Fix planning for multi-cluster dual stack record types
When AAAA multi-target / dual stack support was
added via #2461 it broke ownership of domains across
different clusters with different ingress records types.

For example if 2 clusters manage the same zone,
1 cluster uses A records and the other uses CNAME
records, when each record type is treated as a separate
planning record, it will cause ownership to bounce back
and forth and records to be constantly created and
deleted.

This change updates the planner to keep track of multiple
current records for a domain. This allows for A and AAAA
records to exist for a domain while allowing record type
changes.

The planner will ignore desired records for a domain that
represent conflicting record types allowed by RFC 1034 3.6.2.
For example if the desired records for a domain contains
a CNAME record plus any other record type no changes for
that domain will be planned.

The planner now contains an owned record filter provided
by the registry. This allows the planner to accurately plan
create updates when there are record type changes between
the current and desired endpoints. Without this filter the
planner could add create changes for domains not owned
by the controller.
2023-08-15 19:37:50 -04:00
Matúš Ferech
7aa9d25067
Align PDNS provider with other providers by removing MatchParent
PNDS provider is the only one which uses MatchParent functionality. The
MatchParent functionality breaks domain and regex domain filters. It
also makes PDNS provider behave differently than other providers while
having the same configuration. MatchParent can be replaced by using
multiple domain filters. After discussion with maintainers we concluded
that MatchParent should be removed.
2023-08-14 12:49:23 +02:00
John Gardiner Myers
e9be5887bd Remove DomainFilterInterface 2023-08-11 13:01:22 -07:00
John Gardiner Myers
29a6372030 Add serialization/deserialization support to DomainFilter 2023-07-01 20:14:39 -07:00
John Gardiner Myers
84aa9c1792 Add missing DomainFilter tests 2023-07-01 10:49:34 -07:00
John Gardiner Myers
a9ae5ea43a Add SetIdentifier to EndpointKey 2023-06-18 16:47:37 -07:00
John Gardiner Myers
4417ad4894 Move EndpointKey to endpoints package 2023-06-18 16:47:37 -07:00
Kubernetes Prow Robot
d867cc8059
Merge pull request #3674 from johngmyers/provider-specific
Route53 update configuration of target health checks
2023-06-17 02:56:20 -07:00