mirrors/external-dns
1
0
Fork 0
mirror of https://github.com/kubernetes-sigs/external-dns.git synced 2025-08-06 17:46:57 +02:00
Code Issues Packages Projects Releases Wiki Activity

test(domain-filter): simple filters on domain exclusion (#5064)

Browse Source 
* issue(filter-tags): issue-3718 domain exclusion filters

Signed-off-by: ivan katliarchuk <ivan.katliarchuk@gmail.com>

* issue(filter-tags): issue-3718 domain exclusion filters

Signed-off-by: ivan katliarchuk <ivan.katliarchuk@gmail.com>

* issue(filter-tags): issue-3718 domain exclusion filters

Signed-off-by: ivan katliarchuk <ivan.katliarchuk@gmail.com>

* Apply suggestions from code review

Co-authored-by: Michel Loiseleur <97035654+mloiseleur@users.noreply.github.com>

---------

Signed-off-by: ivan katliarchuk <ivan.katliarchuk@gmail.com>
Co-authored-by: Michel Loiseleur <97035654+mloiseleur@users.noreply.github.com>
This commit is contained in:
Ivan Ka 2025-02-10 09:15:58 +00:00 committed by GitHub
parent b98723d78c
commit 70cbcd1314
No known key found for this signature in database
GPG Key ID: B5690EEEBB952194
1 changed files with 49 additions and 0 deletions
Show Stats Download Patch File Download Diff File Expand all files Collapse all files

49
endpoint/domain_filter_test.go
View File

@ -20,6 +20,7 @@ import (
"encoding/json"
"fmt"
"regexp"
"strings"
"testing"
"github.com/stretchr/testify/assert"
@ -769,3 +770,51 @@ func TestDomainFilterMatchParent(t *testing.T) {
})
}
}
func TestSimpleDomainFilterWithExclusion(t *testing.T) {
test := []struct {
domainFilter []string
exclusionFilter []string
domains []string
want []string
}{
{
domainFilter: []string{"ex.com"},
exclusionFilter: []string{"subdomain.ex.com"},
domains: []string{"subdomain.ex.com", "ex.com", "subdomain.ex.com.", ".subdomain.ex.com", "one.subdomain.ex.com", "ex.com."},
want: []string{"ex.com", "ex.com."},
},
{
domainFilter: []string{"ex.com"},
exclusionFilter: []string{},
domains: []string{"subdomain.ex.com", "ex.com", "subdomain.ex.com.", ".subdomain.ex.com", "one.subdomain.ex.com", "ex.com."},
want: []string{"subdomain.ex.com", "ex.com", "subdomain.ex.com.", ".subdomain.ex.com", "one.subdomain.ex.com", "ex.com."},
},
{
domainFilter: []string{"ex.com"},
exclusionFilter: []string{"one.subdomain.ex.com"},
domains: []string{"subdomain.ex.com", "ex.com", "subdomain.ex.com.", ".subdomain.ex.com", "one.subdomain.ex.com", "ex.com."},
want: []string{"subdomain.ex.com", "ex.com", "subdomain.ex.com.", ".subdomain.ex.com", "ex.com."},
},
{
domainFilter: []string{"ex.com"},
exclusionFilter: []string{".ex.com"},
domains: []string{"subdomain.ex.com", "ex.com", "subdomain.ex.com.", ".subdomain.ex.com", "one.subdomain.ex.com", "ex.com."},
want: []string{"ex.com", "ex.com."},
},
}
for _, tt := range test {
t.Run(fmt.Sprintf("include:%s-exclude:%s", strings.Join(tt.domainFilter, "_"), strings.Join(tt.exclusionFilter, "_")), func(t *testing.T) {
domainFilter := NewDomainFilterWithExclusions(tt.domainFilter, tt.exclusionFilter)
var got []string
for _, domain := range tt.domains {
if domainFilter.Match(domain) {
got = append(got, domain)
}
}
assert.Equal(t, len(got), len(tt.want))
assert.Equal(t, got, tt.want)
})
}
}