mirrors/external-dns
1
0
Fork 0
mirror of https://github.com/kubernetes-sigs/external-dns.git synced 2026-05-04 22:26:11 +02:00
Code Issues Packages Projects Releases Wiki Activity

chore: add debug logs and make integer parsing strict

Browse Source
This commit is contained in:
Julilla Paul 2025-02-10 11:35:07 -08:00
parent 10f4a26184
commit 3b2453bc1a
No known key found for this signature in database
GPG Key ID: BFF368E2BF99CD50
1 changed files with 6 additions and 4 deletions
Show Stats Download Patch File Download Diff File Expand all files Collapse all files

10
endpoint/endpoint.go
View File

@ -401,7 +401,7 @@ func RemoveDuplicates(endpoints []*Endpoint) []*Endpoint {
// Check endpoint if is it properly formatted according to RFC standards
func (e *Endpoint) CheckEndpoint() bool {
switch recordType := e.RecordType; recordType {
case "MX":
case RecordTypeMX:
for _, target := range e.Targets {
// MX records must have a preference value to indicate priority, e.g. "10 example.com"
// as per https://www.rfc-editor.org/rfc/rfc974.txt
@ -411,12 +411,13 @@ func (e *Endpoint) CheckEndpoint() bool {
}
preferenceRaw := targetParts[0]
_, err := strconv.ParseInt(preferenceRaw, 10, 32)
_, err := strconv.ParseUint(preferenceRaw, 10, 16)
if err != nil {
log.Debugf("Invalid %s record target: %s. Invalid integer value in target.", recordType, target)
return false
}
}
case "SRV":
case RecordTypeSRV:
for _, target := range e.Targets {
// SRV records must have a priority, weight, and port value, e.g. "10 5 5060 example.com"
// as per https://www.rfc-editor.org/rfc/rfc2782.txt
@ -426,8 +427,9 @@ func (e *Endpoint) CheckEndpoint() bool {
}
for _, part := range targetParts[:3] {
_, err := strconv.ParseInt(part, 10, 32)
_, err := strconv.ParseUint(part, 10, 16)
if err != nil {
log.Debugf("Invalid %s record target: %s. Invalid integer value in target.", recordType, target)
return false
}
}