mirrors/external-dns
1
0
Fork 0
mirror of https://github.com/kubernetes-sigs/external-dns.git synced 2026-05-04 22:26:11 +02:00
Code Issues Packages Projects Releases Wiki Activity

fix(aes-encryption): labels.Serialise cover case when encryption failed

Browse Source 
Signed-off-by: ivan katliarchuk <ivan.katliarchuk@gmail.com>
This commit is contained in:
ivan katliarchuk 2024-12-29 12:43:48 +00:00
parent 7c62eba9c2
commit 842ecee70a
No known key found for this signature in database
GPG Key ID: 601CDBBBB76E47BE
1 changed files with 4 additions and 5 deletions
Show Stats Download Patch File Download Diff File Expand all files Collapse all files

9
endpoint/labels.go
View File

@ -44,8 +44,8 @@ const (
// DualstackLabelKey is the name of the label that identifies dualstack endpoints
DualstackLabelKey = "dualstack"
// TxtEncryptionNonce label for keep same nonce for same txt records, for prevent different result of encryption for same txt record, it can cause issues for some providers
TxtEncryptionNonce = "txt-encryption-nonce"
// txtEncryptionNonce label for keep same nonce for same txt records, for prevent different result of encryption for same txt record, it can cause issues for some providers
txtEncryptionNonce = "txt-encryption-nonce"
)
// Labels store metadata related to the endpoint
@ -98,7 +98,7 @@ func NewLabelsFromString(labelText string, aesKey []byte) (Labels, error) {
if err == nil {
labels, err := NewLabelsFromStringPlain(decryptedText)
if err == nil {
labels[TxtEncryptionNonce] = encryptionNonce
labels[txtEncryptionNonce] = encryptionNonce
}
return labels, err
@ -119,7 +119,7 @@ func (l Labels) SerializePlain(withQuotes bool) string {
sort.Strings(keys) // sort for consistency
for _, key := range keys {
if key == TxtEncryptionNonce {
if key == txtEncryptionNonce {
continue
}
tokens = append(tokens, fmt.Sprintf("%s/%s=%s", heritage, key, l[key]))
@ -154,7 +154,6 @@ func (l Labels) Serialize(withQuotes bool, txtEncryptEnabled bool, aesKey []byte
text, err = EncryptText(text, aesKey, encryptionNonce)
if err != nil {
// if encryption failed, the external-dns will crash
fmt.Println("GINBO")
log.Fatalf("Failed to encrypt the text %#v using the encryption key %#v. Got error %#v.", text, aesKey, err)
}