Combine steps 3.2 and 3.3 under "Migrating an existing installation"
into a single "replace" instruction. The previous two-step approach
("delete your apps_paths" then "add this apps_paths") was ambiguous
and could be misread as requiring no apps_paths configuration at all
after step 3.2.
The revised step explains that any existing apps_paths configuration
should be replaced with the Docker-compatible version, notes that the
existing configuration may vary in form, and briefly explains why the
apps directory must be non-writable and custom_apps writable.
Signed-off-by: Josh <josh.t.richards@gmail.com>
* fix(hooks): incorrect skipped output in mixed exec/non-exec batches
The `found` variable is incorrectly decremented for non-executable scripts, which leads to misleading output when a hook folder contains an executable + a non-executable script (output will indicate the folder was fully scripted).
Signed-off-by: Josh <josh.t.richards@gmail.com>
* chore(hooks): make skipped/completed logic more intuitive
Signed-off-by: Josh <josh.t.richards@gmail.com>
---------
Signed-off-by: Josh <josh.t.richards@gmail.com>
Extract the disabled-app reporting logic into a helper and compare normalized enabled app names instead of parsing diff output from full `occ app:list` snapshots.
This fixes false positives where apps upgraded during `occ upgrade` were reported as disabled because their version line changed, and avoids reliance on diff output format differences on Alpine/BusyBox.
Fixes#1911
Signed-off-by: Josh <josh.t.richards@gmail.com>
Limit return_code to the per-script failure path instead of keeping it as loop state.
This does not change current behavior, but makes the code easier to reason about and avoids future stale-state bugs if the loop logic is refactored.
Signed-off-by: Josh <josh.t.richards@gmail.com>
* chore: drop libmcrypt-dev from Alpine Dockerfile template
Removed 'libmcrypt-dev' from the list of dependencies.
Was deprecated in PHP 7.1.0 and removed in PHP 7.2.0.
Has not been used by Nextcloud for awhile.
And we're not installing mcrypt as a PECL installation so it's not used at all.
Signed-off-by: Josh <josh.t.richards@gmail.com>
* chore: drop libmcrypt-dev from Debian Dockerfile template
Removed libmcrypt-dev from the list of dependencies.
Signed-off-by: Josh <josh.t.richards@gmail.com>
---------
Signed-off-by: Josh <josh.t.richards@gmail.com>
