1
0
mirror of https://github.com/nextcloud/docker.git synced 2026-04-03 21:01:11 +02:00

fix(hooks): incorrect found count/skipped output in mixed exec/non-exec batches (#2551)

* fix(hooks): incorrect skipped output in mixed exec/non-exec batches

The `found` variable is incorrectly decremented for non-executable scripts, which leads to misleading output when a hook folder contains an executable + a non-executable script (output will indicate the folder was fully scripted).

Signed-off-by: Josh <josh.t.richards@gmail.com>

* chore(hooks): make skipped/completed logic more intuitive

Signed-off-by: Josh <josh.t.richards@gmail.com>

---------

Signed-off-by: Josh <josh.t.richards@gmail.com>
This commit is contained in:
Josh 2026-03-28 20:16:56 -04:00 committed by GitHub
parent a5577bc3ae
commit 583fbe383c
No known key found for this signature in database
GPG Key ID: B5690EEEBB952194

View File

@ -35,7 +35,6 @@ run_path() {
while read -r script_file_path; do
if ! [ -x "${script_file_path}" ]; then
echo "==> The script \"${script_file_path}\" was skipped, because it lacks the executable flag"
found=$((found-1))
continue
fi
@ -49,10 +48,10 @@ run_path() {
echo "==> Finished executing the script: \"${script_file_path}\""
done
if [ "$found" -lt "1" ]; then
echo "==> Skipped: the \"$1\" folder does not contain any valid scripts"
if [ "$found" -gt "0" ]; then
echo "=> Completed executing scripts in the \"$1\" folder"
else
echo "=> Completed executing scripts in the \"$1\" folder"
echo "==> Skipped: the \"$1\" folder does not contain any valid scripts"
fi
)
}