The factory test image was created by using rsync from build artifacts
in chroot, which has some concerns:
- Runtime dependencies of autotest-factory won't be picked into image.
- If a developer skips build_package and builds image by using only pre-built
binary packages, he will get nothing in factory test image.
- It's hard for developers to figure out how and when his changes will be
merged to next build_image (cros_workon does not really work).
- Output image will be definitely different for every developers, also the
official build bots.
- If developers never wipes his chroot (setup_board), the factory test image
will grow until out of space. (For example, my environment outputs a 825M
image while the official buildbot generates only 563M for same ToT source).
This CL changes image build command to using portage emerge, so that output
image can be prepared faster and smaller, and easier for maintenance.
BUG=chromium-os:3335
TEST=./build_packages; ./build_image --factory # Image starts factory UI successfully
# Also tried tests in test_list.all, seems fine.
time ./mod_image_for_test.sh --factory --force_copy --no_inplace
# time: 3m2s => 1m55s, factory test image data: 825/563M => 378M
./build_image --factory_install # factory install shim is also fine
Change-Id: I82b4505c74cd31e718aaff4a319d50b69b2c852c
Reviewed-on: https://gerrit.chromium.org/gerrit/14473
Tested-by: Hung-Te Lin <hungte@chromium.org>
Reviewed-by: Richard Barnette <jrbarnette@chromium.org>
Commit-Ready: Hung-Te Lin <hungte@chromium.org>
Not all 64-bit platforms have names starting with amd64-, so we should
use portageq to get the board architecture name.
BUG=chromium-os:25228
TEST=./cros_generate_breakpad_symbols --board=x86-alex, amd64-corei7, link
Change-Id: I83769575dbd19112b929724995d0c97ed4df2b02
Reviewed-on: https://gerrit.chromium.org/gerrit/14444
Commit-Ready: Vincent Palatin <vpalatin@chromium.org>
Tested-by: Vincent Palatin <vpalatin@chromium.org>
Reviewed-by: David James <davidjames@chromium.org>
Buildbots are periodically failing to build images; the evidence
points to failures in mount_gpt_image.sh, but it's inconclusive.
Add detailed error messages to mount failures so as to be able
to debug more the next time it happens.
BUG=chromium-os:24975
TEST=build_image, to see that successful cases still work
TEST=repeatedly mount new images with mount_gpt_image until it fails
Change-Id: I711fb0dec62dbab3817a62895b53e14376702544
Reviewed-on: https://gerrit.chromium.org/gerrit/14410
Commit-Ready: Richard Barnette <jrbarnette@chromium.org>
Tested-by: Richard Barnette <jrbarnette@chromium.org>
Reviewed-by: David James <davidjames@chromium.org>
The variable setup is "FLAGS_force_non_usb", not "FLAGS_force_non".
Trying to run this currently results in:
./image_to_usb.sh: line 189: [: -ne: unary operator expected
Copying USB image .../chromiumos_image.bin to device /dev/sdb...
This should have instead errored out:
Error: Device /dev/sdb does not appear to be a USB or MMC disk!
Without this fix, image_to_usb.sh proceeds to corrupt the non-usb
disk (which in my case happened to be a backing store for lvm where
all my source was stored and ext4 not surprisingly barfed).
BUG=None
TEST=`./image_to_usb.sh --board=x86-alex -y --to=/dev/sdb` (where /dev/sdb is a disk) now errors out instead of clobbering data
TEST=`./image_to_usb.sh --board=x86-alex -y --to=/dev/sdc` (where /dev/sdc is USB) still works
Change-Id: Id691846393c02cf199309495ae2080b15626e684
Reviewed-on: https://gerrit.chromium.org/gerrit/14334
Reviewed-by: Zdenek Behan <zbehan@chromium.org>
Reviewed-by: Chris Wolfe <cwolfe@chromium.org>
Commit-Ready: Mike Frysinger <vapier@chromium.org>
Tested-by: Mike Frysinger <vapier@chromium.org>
Right now, the buildbot won't symbolize any crash that occurs in autotest
because all symbols in /usr/local/autotest are skipped by breakpad. Tweak
cros_generate_breakpad_symbols to not skip over these symbols so that
browser test crashes can be symbolized.
BUG=chromium-os:25061
TEST=Run cros_generate_breakpad_symbols and verify it still completes
successfully, and generates working symbols for autotest that can
be used to symbolize browser test crashes.
Change-Id: I072498060e78b373bd12c94ff95465878301cbce
Reviewed-on: https://gerrit.chromium.org/gerrit/14155
Commit-Ready: David James <davidjames@chromium.org>
Reviewed-by: David James <davidjames@chromium.org>
Tested-by: David James <davidjames@chromium.org>
This reverts commit 6fa1e14c59e541780e49a48f83683db079614d8f
We reverted the glibc-2.11.1-r4 ebuild (it no longer exists), so we have to revert this too since there is no 2.11.1-r4 to use.
Change-Id: Ie8d71eeaf436b348a695d55376e269557ced3b15
Reviewed-on: https://gerrit.chromium.org/gerrit/14061
Reviewed-by: Yunlian Jiang <yunlian@chromium.org>
Tested-by: Yunlian Jiang <yunlian@chromium.org>
Reviewed-by: asharif <asharif@chromium.org>
Commit-Ready: Mike Frysinger <vapier@chromium.org>
Tested-by: Mike Frysinger <vapier@chromium.org>
If we're generating new breakpad symbols, we don't need to keep the
old ones around. Keeping the old ones forever means the debug tarballs
get really large (e.g. >10GB).
This problem makes incremental bots get slower and slower over time. The
chromium.chromiumos bot spends over an hour archiving the debug symbols,
for example.
BUG=chromium-os:24994
TEST=Trybot run of archive stage, generating and uploading debug
symbols.
Change-Id: Ibf57db2561d29085434439ecd4f23e5cec1f598a
Reviewed-on: https://gerrit.chromium.org/gerrit/14040
Commit-Ready: David James <davidjames@chromium.org>
Reviewed-by: David James <davidjames@chromium.org>
Tested-by: David James <davidjames@chromium.org>
There was no reason for it to be platform-specific. Original CL
that added it to ARM (it was already there for x86) is:
<http://gerrit.chromium.org/gerrit/1467>
This change is in preparation for moving platform-specific bits
into ebuilds.
BUG=chromium-os:24808
TEST=Validated that kern_guid gets set properly.
Change-Id: I5544ad3730e05128c0a9b0a4a3a8aee80ef31df5
Reviewed-on: https://gerrit.chromium.org/gerrit/13821
Tested-by: Doug Anderson <dianders@chromium.org>
Reviewed-by: Mike Frysinger <vapier@chromium.org>
Reviewed-by: Mandeep Singh Baines <msb@chromium.org>
Commit-Ready: Doug Anderson <dianders@chromium.org>
Now that emerge supports the flags needed to build packages, we don't
need to special-case it anymore.
BUG=chromium-os:24497
TEST=Trybot run.
Change-Id: I4ca1cd22c309f97fc14f1d7b9eede9128b7f0be1
Reviewed-on: https://gerrit.chromium.org/gerrit/13389
Reviewed-by: Brian Harring <ferringb@chromium.org>
Reviewed-by: Mike Frysinger <vapier@chromium.org>
Tested-by: David James <davidjames@chromium.org>
Commit-Ready: David James <davidjames@chromium.org>
Not everyone got a smooth migration for git/subversion from dev-util
to dev-vcs, so add a hook to manually unmerge the old versions. The
newer packages should recover gracefully after that.
BUG=chromium-os:24360
TEST=build_packages ran ver 23 upgrade and continued on
Change-Id: I0b56f0f0a8b8a7ebd64a4a664e5524f0b7828791
Reviewed-on: https://gerrit.chromium.org/gerrit/13663
Reviewed-by: Doug Anderson <dianders@chromium.org>
Tested-by: Mike Frysinger <vapier@chromium.org>
Commit-Ready: Doug Anderson <dianders@chromium.org>
This comes from not correctly negating all FLAGS and also the weird
way we set PRISTINE_IMAGE_NAME. Addressed in both cases and
simplified FLAGS_* logic in build_image_util.sh
BUG=chromium-os:24627
TEST=build_image base so far.
Change-Id: I92e8550db3ea713cda1f997b702777035145d8d5
Reviewed-on: https://gerrit.chromium.org/gerrit/13636
Tested-by: Chris Sosa <sosa@chromium.org>
Reviewed-by: Mandeep Singh Baines <msb@chromium.org>
Commit-Ready: Chris Sosa <sosa@chromium.org>
"-fstack-protector-all".
Rollout gcc-4.6.0 ebuild r12 that support a new stack protection
option "-fstack-protector-strong".
BUG=None
TEST=manually - build amd64-generic and x86-zgb from scratch.
Change-Id: I35dc315ef376467256266a62cf9e584b8bb3c8e5
Reviewed-on: https://gerrit.chromium.org/gerrit/13546
Tested-by: Han Shen <shenhan@google.com>
Reviewed-by: Han Shen <shenhan@chromium.org>
Reviewed-by: asharif <asharif@chromium.org>
Commit-Ready: Han Shen <shenhan@chromium.org>
This is needed on some ARM boards where ext2 filesystem reading isn't an option,
and where verified boot isn't in use, i.e. with legacy firmware. x86 stores the
kernel here as well.
BUG=none
TEST=build_image on an arm board and check contents for vmlinuz.A and vmlinuz.uimg.A on
partition 12
Change-Id: I89b652cb6ea7ece1627b20be30492100f8db0770
Signed-off-by: Olof Johansson <olofj@chromium.org>
Reviewed-on: https://gerrit.chromium.org/gerrit/13441
Nothing is using it in code and it seems to be under most folks radar- thus remove it
(possibly have it reapear in thirdparty/autotest if it's actually needed).
BUG=None
TEST=N/a
Change-Id: Ie3f43aa427c6cc35aa6f96d8c8631c4b8bff6347
Reviewed-on: https://gerrit.chromium.org/gerrit/4668
Tested-by: Brian Harring <ferringb@chromium.org>
Reviewed-by: Matt Tennant <mtennant@chromium.org>
Commit-Ready: Brian Harring <ferringb@chromium.org>
This reverts commit 1d20fe6813b991899900aaa4f92b965a8f0b511d
Change-Id: I2d07c4c16e56841e397ee62d0371c5edc85c8364
Reviewed-on: https://gerrit.chromium.org/gerrit/13439
Commit-Ready: Olof Johansson <olofj@chromium.org>
Reviewed-by: Olof Johansson <olofj@chromium.org>
Tested-by: Olof Johansson <olofj@chromium.org>
Reviewed-by: Ryan Cui <rcui@chromium.org>
Tested-by: Ryan Cui <rcui@chromium.org>
This is needed on some ARM boards where ext2 filesystem reading isn't an option,
and where verified boot isn't in use, i.e. with legacy firmware. x86 stores the
kernel here as well.
BUG=none
TEST=build_image on an arm board and check contents for vmlinuz.A and vmlinuz.uimg.A on
partition 12
CQ-DEPEND=I81df8471fba34e264ada8fd6f12122d87fbf22d9
Change-Id: I39541644845dde4ff6ddc288afa0ed339ab0d05b
Signed-off-by: Olof Johansson <olofj@chromium.org>
Reviewed-on: https://gerrit.chromium.org/gerrit/12996
If people have whitespace in their .default_board setting, then the cros
utils will act weirdly. Some work the same as if there was no whitespace
(probably because the variable is used unquoted) while others error out
with weird messages (because the variable is used quoted).
Update the helper function to only allow certain characters in the name.
BUG=None
TEST=`printf 'x86-alex\n' > .default_board; cros_workon list --all` works
TEST=`printf 'x86-alex\t\n' > .default_board; cros_workon list --all` errors out
Change-Id: Id83794c13bfddb7fb56b7f8ed8a375eefe6096e0
Reviewed-on: https://gerrit.chromium.org/gerrit/13151
Reviewed-by: Jason Glasgow <jglasgow@chromium.org>
Reviewed-by: David James <davidjames@chromium.org>
Commit-Ready: Mike Frysinger <vapier@chromium.org>
Tested-by: Mike Frysinger <vapier@chromium.org>
BUG=chromium-os:14334
TEST=`emerge sys-kernel/linux-headers` now pulls in version 3.1 & works
TEST=`emerge cross-armv7a-cros-linux-gnueabi/linux-headers` now pulls in version 3.1 & works
TEST=`emerge cross-i686-pc-linux-gnu/linux-headers` now pulls in version 3.1 & works
TEST=`emerge cross-x86_64-cros-linux-gnu/linux-headers` now pulls in version 3.1 & works
TEST=`cbuildbot chromiumos-sdk` worked
TEST=`cbuildbot amd64-generic-full` passes
TEST=`cbuildbot arm-generic-full` passes
TEST=`cbuildbot x86-generic-full` passes
TEST=build_packages+build_image for x86-alex boots
CQ-DEPENDS=13082
Change-Id: I20460c174570ff004be14e82863aab316a1fb572
Reviewed-on: https://gerrit.chromium.org/gerrit/13083
Commit-Ready: Mike Frysinger <vapier@chromium.org>
Reviewed-by: Mike Frysinger <vapier@chromium.org>
Tested-by: Mike Frysinger <vapier@chromium.org>
While we do use sysroot_wrapper bits in the chroot, we do not
use the target of this symlink (nor do we want it in our PATH).
BUG=chromium-os:24111
TEST=cbuildbot x86-alex
Change-Id: I7cf44ac32494dfaac683a4442d30f278bbcfb38c
Reviewed-on: https://gerrit.chromium.org/gerrit/13065
Tested-by: Brian Harring <ferringb@chromium.org>
Reviewed-by: David James <davidjames@chromium.org>
Commit-Ready: Brian Harring <ferringb@chromium.org>
This change makes it possible for partners to access internal prebuilts.
Note that partners will only have access to the actual prebuilts referenced
here if they have access to the right Google Storage key, which are stored
in the overlays themselves.
BUG=chrome-os-partner:7186, chromium-os:17346
TEST=Verify that setup_board now pulls internal prebuilts from chromeos-partner-overlay
instead of chromeos-overlay.
CQ-DEPEND=13071
Change-Id: Ia5220002a18593e614ee67ccad16bb295c8b6d0b
Reviewed-on: https://gerrit.chromium.org/gerrit/13072
Reviewed-by: Ryan Cui <rcui@chromium.org>
Tested-by: David James <davidjames@chromium.org>
My cbuildbot run is creating this file. I don't care about it -> ignore!
BUG=None
TEST=`git status` no longer lists cbuildbot_package.list
Change-Id: I95ac49c84d628fbb52dda8f1df63ab6394e5df8f
Reviewed-on: https://gerrit.chromium.org/gerrit/12957
Reviewed-by: David James <davidjames@chromium.org>
Commit-Ready: Mike Frysinger <vapier@chromium.org>
Tested-by: Mike Frysinger <vapier@chromium.org>
Looks like there was a desync between adding gdb support and arm-eabi
support. We don't provide gdb for the arm-eabi toolchain, so don't
consider it when looking for updates. Otherwise we end up constantly
re-installing the arm-eabi toolchain because there are "updates".
BUG=None
TEST=setup_board for x86-alex stops re-installing the arm-eabi toolchain everytime
Change-Id: I099bc6a411b6cacdd3d7cdd5e4eb872a937678bd
Reviewed-on: https://gerrit.chromium.org/gerrit/12905
Commit-Ready: Mike Frysinger <vapier@chromium.org>
Reviewed-by: Mike Frysinger <vapier@chromium.org>
Tested-by: Mike Frysinger <vapier@chromium.org>
Due to historical reasons, these scripts have existed at
chromiumos-overlay/chrome/scripts, but have belonged
in src/scripts (previously accessed by symlinks here
pointing to their locations).
Transfer them in, rather than relying on symlinks; this
gets us atomic commits w/in crosutils in the process.
Scripts were imported as of 604e3722af59164bc97aa5dcd1407e36495c96d7
BUG=chromium-os:24111
TEST=cbuildbot x86-generic-full
Change-Id: I689f7e05a25d427e24372f206bdb0779bf857820
Reviewed-on: https://gerrit.chromium.org/gerrit/12893
Reviewed-by: David James <davidjames@chromium.org>
Commit-Ready: Brian Harring <ferringb@chromium.org>
Tested-by: Brian Harring <ferringb@chromium.org>
On long running systems, the ssh-agent dir might go stale. This should
not prevent entering the cros chroot though, so skip it if it's invalid.
BUG=None
TEST=`cros_sdk` enters with ssh-agent dir bind mounted
TEST=`rm -rf /tmp/ssh-*/; cros_sdk` enters with ssh-agent dir skipped
Change-Id: I923b031612c0d37a896437c7355cac6c448eef82
Reviewed-on: https://gerrit.chromium.org/gerrit/12758
Reviewed-by: David James <davidjames@chromium.org>
Commit-Ready: Mike Frysinger <vapier@chromium.org>
Tested-by: Mike Frysinger <vapier@chromium.org>
BUG=chromium-os:23903
TEST=full build of x86-zgb, mod_for_test, boot; run dbus-monitor
on tty2 as root, log in, switch back and observe all the dbus
traffic.
Change-Id: Iccdb47bec97260108c73cf346c91c2d9e8c2bc18
Reviewed-on: https://gerrit.chromium.org/gerrit/12593
Commit-Ready: Jim Hebert <jimhebert@chromium.org>
Reviewed-by: Jim Hebert <jimhebert@chromium.org>
Tested-by: Jim Hebert <jimhebert@chromium.org>
This solves two problems (and half):
a) messing with user's preference file is a no-no, if we want a
hardcoded behaviour like this, profile.d is the way to go
b) .bashrc settings are overridden when doing env-update; source
/etc/profile
c) profile.d will also apply to root (although not with sudo su)
BUG=none
TEST=below
1) ./run_chroot_version_hooks --version 21
2) see all fixed, source /etc/profile, and still see my prompt unchanged
Change-Id: I25b4602f4951b17815bcd312a8249320784c67e1
Reviewed-on: https://gerrit.chromium.org/gerrit/12539
Reviewed-by: Mike Frysinger <vapier@chromium.org>
Tested-by: Zdenek Behan <zbehan@chromium.org>
Commit-Ready: Zdenek Behan <zbehan@chromium.org>
* Since dm-verity arguments are now read from the install image upon
recovery, we need not use them in build_kernel_image.
* Also, don't expect or remove /tmp/rootfs.hash, which will not be
generated by build_kernel_image.
* Cleanup of dead code following the elimination of use of root_dev.
* Updated ASCII art for success/failure condition.
* See corresponding changes to initramfs script (extract verity args
from install kernel) and chromeos-initramfs ebuild (pull
dump_kernel_config).
BUG=chromium-os:22530
TEST=Built and successfully installed recovery image on CR-48
Change-Id: I3536c88537bbce277f79f17b676231b67337a0d1
Reviewed-on: https://gerrit.chromium.org/gerrit/12646
Reviewed-by: Gilad Arnold <garnold@chromium.org>
Tested-by: Gilad Arnold <garnold@chromium.org>
Commit-Ready: Gilad Arnold <garnold@chromium.org>
This reverts commit 99182997f90041870db9038837c04be973999800
CL was committed unintentionally; it depends on two other CLs that were not committed yet.
Change-Id: Ica5820b31d7f6857c0553cedb642ee17f5109da9
Reviewed-on: https://gerrit.chromium.org/gerrit/12587
Commit-Ready: Gilad Arnold <garnold@chromium.org>
Reviewed-by: Gilad Arnold <garnold@chromium.org>
Tested-by: Gilad Arnold <garnold@chromium.org>
* Since dm-verity arguments are now read from the install image upon
recovery, we need not use them in build_kernel_image.
* Also, don't expect or remove /tmp/rootfs.hash, which will not be
generated by build_kernel_image.
* Cleanup of dead code following the elimination of use of root_dev.
* Updated ASCII art for success/failure condition.
* See corresponding changes to initramfs script (extract verity args
from install kernel) and chromeos-initramfs ebuild (pull
dump_kernel_config).
BUG=chromium-os:22530
TEST=Built and successfully installed recovery image on CR-48
Change-Id: I146b6ad707d96c9fbc8731a73ae079e80902a565
Reviewed-on: https://gerrit.chromium.org/gerrit/12335
Reviewed-by: Richard Barnette <jrbarnette@chromium.org>
Tested-by: Gilad Arnold <garnold@chromium.org>
Newer versions of util-linux's mount utility will not show:
/dev/loop0 on /some/path type ext3 (mount,opts)
Instead, it finds out the file backing /dev/loop0 and outputs:
/some/file on /some/path type ext3 (mount,opts)
This breaks the make_image_bootable helper that attempts to look up the
loop device that mount_gpt_image.sh happened to pick.
Let's scuttle the idea of parsing `mount` and move directly to what the
kernel has to say via /proc/mounts. Hopefully the ABI there should be
quite a bit more stable.
BUG=None
TEST=build_image works with mount from util-linux-2.16
TEST=build_image (before change) fails with mount from util-linux-2.19
TEST=build_image works with mount from util-linux-2.19
Change-Id: I66908800e82ff2e106face9d57773721e400dc2a
Reviewed-on: https://gerrit.chromium.org/gerrit/11869
Commit-Ready: Mike Frysinger <vapier@chromium.org>
Reviewed-by: Mike Frysinger <vapier@chromium.org>
Tested-by: Mike Frysinger <vapier@chromium.org>
This is final step in ext4 conversion. We have been running with
the ext4 file system but ext3 format for several weeks. This changes
uses the ext4 format for the stateful partition.
Removed make_developer_script_runner.sh as per review.
BUG=chromium-os:20012
TEST=Ran ext4 on all platforms
Change-Id: I8e1564bfa576e9a0ad810879c18223a6c68b18e1
Reviewed-on: https://gerrit.chromium.org/gerrit/11220
Commit-Ready: Paul Taysom <taysom@google.com>
Reviewed-by: Paul Taysom <taysom@google.com>
Tested-by: Paul Taysom <taysom@google.com>
It seems better to catch issues earlier during the build phase rather than later
during the actual test run. Prompted to do this after debugging
crosbug.com/21837.
BUG=chromium-os:23422
TEST=build_image test for x86-alex, amd64-generic, tegra2_kaen with no failures;
build_image factory_test for x86-alex with no failures; also verified that
build_image exits early with a non-zero exit code for amd64-generic without the
fix for crosbug.com/21837.
Change-Id: Ibdcf770d1d854d5a6765734556cf6ee8fc4aae96
Reviewed-on: https://gerrit.chromium.org/gerrit/12102
Tested-by: Darin Petkov <petkov@chromium.org>
Reviewed-by: Sonny Rao <sonnyrao@chromium.org>
Reviewed-by: Richard Barnette <jrbarnette@chromium.org>
Commit-Ready: Darin Petkov <petkov@chromium.org>
Race conditions could prevent /tmp/esp.* from being properly unmounted
if it was quickly mounted then unmounted. If the umount fails,
sleep briefly and then retry.
BUG=chromium-os:23442,chromium-os:23443
TEST=Ran build_image --test, saw umount failure but after script finished
saw that directory was unmounted on second attempt so no leakage
Change-Id: I5b2260f5c99fcfa66027ebcfd69b6e3d5afe4b91
Reviewed-on: https://gerrit.chromium.org/gerrit/12115
Tested-by: Jon Kliegman <kliegs@chromium.org>
Reviewed-by: Chris Sosa <sosa@chromium.org>
Commit-Ready: Jon Kliegman <kliegs@chromium.org>
/tmp/esp.* mountpoints are being leaked in update_bootloaders so clean
these up too.
BUG=chromium-os:23442
TEST=With stale mounts existing, run script. Observe mounts gone
Change-Id: I95729bd7330157d02f27f86da495642263fe8ff6
Reviewed-on: https://gerrit.chromium.org/gerrit/12114
Tested-by: Jon Kliegman <kliegs@chromium.org>
Reviewed-by: Chris Sosa <sosa@chromium.org>
Commit-Ready: Jon Kliegman <kliegs@chromium.org>
See CL https://gerrit.chromium.org/gerrit/#change,11951 for the original CL.
BUG=chromium-os:23407
TEST=Tested on chroot synced on 23/11/11
Change-Id: I039d6b6ee06617dfa9263eab4fe83e128f0773b4
Reviewed-on: https://gerrit.chromium.org/gerrit/12106
Reviewed-by: Peter Mayo <petermayo@chromium.org>
Reviewed-by: Sean Paul <seanpaul@chromium.org>
Tested-by: Sean Paul <seanpaul@chromium.org>
Commit-Ready: Sean Paul <seanpaul@chromium.org>
The current instructions for golo access include additions to the
~/.ssh/config file that are specific to Google distros of ssh. The
filtering mechanism in enter_chroot needed an update to include
these new options to filter out.
BUG=chromium-os:23322
TEST=With a golo-configured .ssh/config, enter chroot and test ssh:
> cros_sdk
> git remote update
Fetching ...
...
Change-Id: Ida9fcdff37ff0eb24c811ad789f82136dca7252f
Reviewed-on: https://gerrit.chromium.org/gerrit/12037
Tested-by: Matt Tennant <mtennant@chromium.org>
Reviewed-by: David James <davidjames@chromium.org>
Reviewed-by: Zdenek Behan <zbehan@chromium.org>
Commit-Ready: Matt Tennant <mtennant@chromium.org>
If people land upgrade hooks of the same version levels independently and
no one notices, we get into an inconsistent state where only one of the
hooks actually runs. Add a sanity check so we bail rather than upgrading
the chroot with an arbitrarily picked script.
BUG=None
TEST=run build_packages with multiple 17_xxx files in a ver 16 chroot and see script error out
TEST=run build_packages with single 17_xxx file in a ver 16 chroot and see successful run
Change-Id: If9a71f60badb7c9643c1a03ad49bb23ffb64f341
Reviewed-on: https://gerrit.chromium.org/gerrit/11972
Reviewed-by: Zdenek Behan <zbehan@chromium.org>
Commit-Ready: Mike Frysinger <vapier@chromium.org>
Tested-by: Mike Frysinger <vapier@chromium.org>
The bashrc that is in each board's /etc/portage/ dir is an old tool from
crossdev which we no longer use/need, so drop it. Especially since it
conflicts with newer bashrc profile stacking.
BUG=chromium-os:21276
TEST=chroot updated to 18 and all /etc/portage/bashrc files in /board/*/ are gone
Change-Id: I51688ce6c04e91506113d920bf1a50a6a822d2f3
Reviewed-on: https://gerrit.chromium.org/gerrit/11908
Reviewed-by: David James <davidjames@chromium.org>
Commit-Ready: Mike Frysinger <vapier@chromium.org>
Tested-by: Mike Frysinger <vapier@chromium.org>
BUG=chromium-os:21244
TEST=./build_packages unmerges old grub and installs new one (with related change)
Change-Id: Iadfbd219a989f71258786591c047ace3931f1e9c
Reviewed-on: https://gerrit.chromium.org/gerrit/11951
Reviewed-by: Bill Richardson <wfrichar@chromium.org>
Tested-by: Anush Elangovan <anush@chromium.org>
The make_chroot script was upgraded to add its customizations to a file
in /etc/sudoers.d/ instead of modifying /etc/sudoers. Then the sudo
ebuild was updated to not modify /etc/sudoers anymore. This meant for
older chroots, the customizations that make_chroot added were lost in
the process.
Add an upgrade hook that creates the split /etc/sudoers.d/ file for older
chroots that did not go through the newer make_chroot.
BUG=chromium-os:11991
TEST=set chroot to 16, deleted file, ran build_packages: chroot updated to 17 and created correct /etc/sudoers.d/90_cros file
TEST=set chroot to 17, create /etc/sudoers.d/90_cros, ran build_packages: chroot updated to 17 and left existing file alone
Change-Id: I279ac3e15380e02b50a752a62cecbd94171fd724
Reviewed-on: https://gerrit.chromium.org/gerrit/11774
Reviewed-by: David James <davidjames@chromium.org>
Commit-Ready: Mike Frysinger <vapier@chromium.org>
Tested-by: Mike Frysinger <vapier@chromium.org>
BUG=chromium-os:21244
TEST=./build_image works with both old and new grub
Change-Id: Idca80f777b7da72da1690bc374a156f910d487b0
Reviewed-on: https://gerrit.chromium.org/gerrit/11876
Reviewed-by: Bill Richardson <wfrichar@chromium.org>
Tested-by: Anush Elangovan <anush@chromium.org>
Commit-Ready: Anush Elangovan <anush@chromium.org>
The script was here to provide transitional notice to developers;
it is no longer needed.
BUG=None
TEST=None
Change-Id: Idfaae066bfb929caa306e1adbf8055a5fe4e69f5
Reviewed-on: https://gerrit.chromium.org/gerrit/11882
Commit-Ready: Richard Barnette <jrbarnette@chromium.org>
Tested-by: Richard Barnette <jrbarnette@chromium.org>
Reviewed-by: Chris Sosa <sosa@chromium.org>
Reviewed-by: Zdenek Behan <zbehan@chromium.org>
