mirrors/flatcar-scripts
1
0
Fork 0
mirror of https://github.com/flatcar/scripts.git synced 2026-05-04 11:51:14 +02:00
Code Issues Packages Projects Releases Wiki Activity

Don't skip over /usr/local/autotest when generating symbols.

Browse Source 
Right now, the buildbot won't symbolize any crash that occurs in autotest
because all symbols in /usr/local/autotest are skipped by breakpad. Tweak
cros_generate_breakpad_symbols to not skip over these symbols so that
browser test crashes can be symbolized.

BUG=chromium-os:25061
TEST=Run cros_generate_breakpad_symbols and verify it still completes
     successfully, and generates working symbols for autotest that can
     be used to symbolize browser test crashes.

Change-Id: I072498060e78b373bd12c94ff95465878301cbce
Reviewed-on: https://gerrit.chromium.org/gerrit/14155
Commit-Ready: David James <davidjames@chromium.org>
Reviewed-by: David James <davidjames@chromium.org>
Tested-by: David James <davidjames@chromium.org>
This commit is contained in:
David James 2012-01-13 10:17:33 -08:00 committed by Gerrit
parent 5d2df83002
commit 2ea8a7859e
1 changed files with 0 additions and 10 deletions
Show Stats Download Patch File Download Diff File Expand all files Collapse all files

10
cros_generate_breakpad_symbols
View File

@ -152,15 +152,6 @@ function process_file() {
fi
return 0
fi
if [ "${text_file#${AUTOTEST_ROOT}}" != "${text_file}" ]; then
# Skip autotest files, they are not part of the image to debug
# and some cause trouble to dump_syms because they are built
# externally (with different build options).
if [ ${FLAGS_verbose} -eq ${FLAGS_TRUE} ]; then
info "Skipping autotest file: ${text_file}"
fi
return 0
fi
if [ ! -f "${text_file}" ]; then
# Allow files to not exist, for instance if they are in the INSTALL_MASK.
warn "Binary does not exist: ${text_file}"
@ -202,7 +193,6 @@ function main() {
info "Writing minidump symbols to ${FLAGS_minidump_symbol_root}"
DEBUG_ROOT="${SYSROOT}/usr/lib/debug"
AUTOTEST_ROOT="${SYSROOT}/usr/local/autotest"
CUMULATIVE_SIZE=0
sudo rm -rf "${FLAGS_minidump_symbol_root}"