talos/internal/integration/cli
Utku Ozdemir 5dff164f1c
fix: fix error output of cli action tracker
Before we started a reboot/shutdown/reset/upgrade action with the action tracker (`--wait`), we were setting a flag to prevent cobra from printing the returned error from the command.

This was to prevent the error from being printed twice, as the reporter of the action tracker already prints any errors occurred during the action execution.

But if the error happens too early - i.e. before we even started the status printer goroutine, then that error wouldn't be printed at all, as we have suppressed the errors.

This PR moves the suppression flag to be set after the status printer is started - so we still do not double-print the errors, but neither do we suppress any early-stage error from being printed.

Closes siderolabs/talos#7900.

Signed-off-by: Utku Ozdemir <utku.ozdemir@siderolabs.com>
2023-10-27 21:16:54 +02:00
..
testdata feat: introduce Talos API access from Kubernetes 2022-08-08 18:27:26 +02:00
apply-config.go fix: send diagnostic output to stderr consistently 2022-12-23 18:41:56 +04:00
cli.go chore: remove old build tags syntax 2022-08-24 17:27:01 +03:00
completion.go chore: rename talos-systems/talos to siderolabs/talos 2022-11-03 16:50:32 +04:00
config.go chore: add output flag for talosctl config info 2023-09-05 21:25:21 +04:00
containers.go refactor: rewrite code to include preliminary support for multi-doc 2023-05-31 18:38:05 +04:00
copy.go chore: rename talos-systems/talos to siderolabs/talos 2022-11-03 16:50:32 +04:00
disk.go chore: rename talos-systems/talos to siderolabs/talos 2022-11-03 16:50:32 +04:00
diskusage.go chore: rename talos-systems/talos to siderolabs/talos 2022-11-03 16:50:32 +04:00
dmesg.go chore: update gen and COSI runtime 2023-09-22 12:13:13 +04:00
etcd.go refactor: rewrite code to include preliminary support for multi-doc 2023-05-31 18:38:05 +04:00
gen.go feat: generate secrets bundle from the machine config 2023-10-25 13:44:14 +04:00
health.go chore: re-enable nolintlint and typecheck linters 2023-08-25 01:05:41 +04:00
image.go release(v1.6.0-alpha.0): prepare release 2023-08-24 17:09:34 +04:00
inject.go chore: rename talos-systems/talos to siderolabs/talos 2022-11-03 16:50:32 +04:00
jsonpath.go chore: fix cilium e2e tests 2023-06-14 15:08:31 +04:00
kubeconfig.go refactor: rewrite code to include preliminary support for multi-doc 2023-05-31 18:38:05 +04:00
list.go refactor: rewrite code to include preliminary support for multi-doc 2023-05-31 18:38:05 +04:00
logs.go chore: rename talos-systems/talos to siderolabs/talos 2022-11-03 16:50:32 +04:00
machineconfig.go feat: update Linux 6.1.1, containerd 1.6.14 2022-12-23 20:30:09 +04:00
memory.go chore: rename talos-systems/talos to siderolabs/talos 2022-11-03 16:50:32 +04:00
meta.go feat: implement APIs to write to META 2023-03-15 22:17:52 +04:00
mounts.go chore: rename talos-systems/talos to siderolabs/talos 2022-11-03 16:50:32 +04:00
netstat.go feat: netstat pod support 2023-03-30 23:39:38 +04:00
patch.go refactor: rewrite code to include preliminary support for multi-doc 2023-05-31 18:38:05 +04:00
pcap.go refactor: rewrite code to include preliminary support for multi-doc 2023-05-31 18:38:05 +04:00
pki.go test: fix 'talosctl gen' tests 2023-10-12 16:24:02 +04:00
processes.go chore: rename talos-systems/talos to siderolabs/talos 2022-11-03 16:50:32 +04:00
read.go chore: rename talos-systems/talos to siderolabs/talos 2022-11-03 16:50:32 +04:00
reboot.go fix: fix error output of cli action tracker 2023-10-27 21:16:54 +02:00
restart.go refactor: rewrite code to include preliminary support for multi-doc 2023-05-31 18:38:05 +04:00
services.go chore: rename talos-systems/talos to siderolabs/talos 2022-11-03 16:50:32 +04:00
stats.go refactor: rewrite code to include preliminary support for multi-doc 2023-05-31 18:38:05 +04:00
support.go refactor: rewrite code to include preliminary support for multi-doc 2023-05-31 18:38:05 +04:00
time.go chore: rename talos-systems/talos to siderolabs/talos 2022-11-03 16:50:32 +04:00
validate.go fix: send diagnostic output to stderr consistently 2022-12-23 18:41:56 +04:00
version.go refactor: replace uncordonNode with controllers 2023-06-13 21:48:42 +04:00