Kristoffer Dalby c1d20a3b8c ssh/tailssh: bypass /usr/bin/login on darwin for non-TTY exec sessions
On macOS the incubator went through /usr/bin/login -pq <user> <shell>
-c <cmd> for any session, including non-TTY 'ssh host cmd' exec
sessions. /usr/bin/login does not propagate the child command's exit
status when invoked this way: it exits 0 once the child has been
spawned, so 'ssh mac exit 42' returned 0 instead of 42 and
'ssh mac /nonexistent/binary' returned 0 instead of 127. The
exit-status frame ordering fix in this branch is still required (the
server has to send the right frames in the right order), but it is
not sufficient on its own when the value being sent is wrong.

For interactive shells (hasTTY) login still gives us the desired
PAM 'remote' session and utmpx accounting, and exit-code propagation
is not user-observable, so the login path is kept. For non-TTY
command exec sessions we now fall through to handleSSHInProcess,
which uses dropPrivileges + cmd.Run + os.Exit(code) — the same path
Linux already uses for non-TTY sessions, and the path that produces
correct exit codes in the integration tests.

Verified against the macOS CI logs from run 25326829991: the artifact
shows the server sending exit-status 0 from /usr/bin/login -pq
... /bin/bash -c 'exit 42', confirming the diagnosis. Verified on
Linux that the fall-through path produces the right exit codes
(integration tests pass 5x consecutively on the full incubator path
including drop-privileges).

Fixes #18256

Signed-off-by: Kristoffer Dalby <kristoffer@tailscale.com>
2026-05-04 15:18:47 +00:00
2026-04-27 18:38:06 -07:00
2026-05-01 14:01:10 -07:00
2026-03-27 08:41:33 +00:00
2026-01-27 16:15:17 -08:00

Tailscale

https://tailscale.com

Private WireGuard® networks made easy

Overview

This repository contains the majority of Tailscale's open source code. Notably, it includes the tailscaled daemon and the tailscale CLI tool. The tailscaled daemon runs on Linux, Windows, macOS, and to varying degrees on FreeBSD and OpenBSD. The Tailscale iOS and Android apps use this repo's code, but this repo doesn't contain the mobile GUI code.

Other Tailscale repos of note:

For background on which parts of Tailscale are open source and why, see https://tailscale.com/opensource/.

Using

We serve packages for a variety of distros and platforms at https://pkgs.tailscale.com.

Other clients

The macOS, iOS, and Windows clients use the code in this repository but additionally include small GUI wrappers. The GUI wrappers on non-open source platforms are themselves not open source.

Building

We always require the latest Go release, currently Go 1.26. (While we build releases with our Go fork, its use is not required.)

go install tailscale.com/cmd/tailscale{,d}

If you're packaging Tailscale for distribution, use build_dist.sh instead, to burn commit IDs and version info into the binaries:

./build_dist.sh tailscale.com/cmd/tailscale
./build_dist.sh tailscale.com/cmd/tailscaled

If your distro has conventions that preclude the use of build_dist.sh, please do the equivalent of what it does in your distro's way, so that bug reports contain useful version information.

Bugs

Please file any issues about this code or the hosted service on the issue tracker.

Contributing

PRs welcome! But please file bugs. Commit messages should reference bugs.

We require Developer Certificate of Origin Signed-off-by lines in commits.

See commit-messages.md (or skim git log) for our commit message style.

About Us

Tailscale is primarily developed by the people at https://github.com/orgs/tailscale/people. For other contributors, see:

WireGuard is a registered trademark of Jason A. Donenfeld.

Description
The easiest, most secure way to use WireGuard and 2FA.
Readme BSD-3-Clause 164 MiB
Languages
Go 95.4%
C 1.6%
TypeScript 1.1%
Shell 0.6%
Swift 0.4%
Other 0.6%