Carrie Edwards
44b0fbba1e
No info annotation for rate/increase when type is histogram ( #16915 )
...
Signed-off-by: Carrie Edwards <edwrdscarrie@gmail.com>
2025-07-24 10:11:37 -07:00
George Krajcsovits
3f59fe1a80
fix(chunkenc): appending histograms with empty buckets ( #16893 )
...
* test(chunkenc): appending histograms with empty buckets and gaps
Append such native histograms that have empty buckets and gaps
between the indexes of those buckets.
There is a special case for appending counter native histograms to a chunk in TSDB: if we append a histogram that is missing some buckets that are already in chunk, then usually that's a counter reset. However if the missing bucket is empty, meaning its value is 0, then we don't consider it missing.
For this case to trigger , we need to write empty buckets into the chunk. Normally native histograms are compacted when we emit them , so this is very rare and compact make sure that there are no multiple continuous empty buckets with gaps between them.
The code that I've added in #14513 did not take into account that you can bypass compact and write histograms with many empty buckets, with gaps between them. These are still valid, so the code has to account for them.
Main fix in the expandIntSpansAndBuckets and expandFloatSpansAndBuckets function. I've also refactored them for clarity. Consequently needed to fix insert and adjustForInserts to also allow gaps between inserts.
I've added some new test cases (data driven test would be nice here, too many cases). And removed the deprecated old function that didn't deal with empty buckets at all.
Signed-off-by: György Krajcsovits <gyorgy.krajcsovits@grafana.com>
Signed-off-by: George Krajcsovits <krajorama@users.noreply.github.com>
Co-authored-by: Björn Rabenstein <beorn@grafana.com>
2025-07-24 18:01:02 +02:00
Julius Volz
13b55ffc81
UI: More inclusive metadata handling for _count/_sum/_bucket suffixes ( #16910 )
...
Although these suffixes always need to be removed before querying metadata for
metrics that follow the Prometheus naming best practices, there can also be
metrics that don't follow these naming practices and have these suffixes
without being part of either a histogram or a summary metric.
Fixes https://github.com/prometheus/prometheus/issues/16907
Signed-off-by: Julius Volz <julius.volz@gmail.com>
2025-07-24 13:54:58 +02:00
buda
f8b3fce845
remote write 2.0: add write handler benchmark for V2 format ( #16687 )
...
Signed-off-by: Sandro Jijavadze <sandrojijavadze@protonmail.com>
2025-07-23 13:51:06 -07:00
Darshan Chaudhary
9b00c296a8
[PERF] PromQL: Pass concrete types to promql functions ( #16797 )
...
Currently, the promql functions take the interface slice []parser.Value as an argument,
which is being implemented by the conrete types Vector, Matrix etc. This PR replaces
the interface with the concrete types, resulting in improved performance.
The inspiration for this PR came from #16698 which does this for binops.
I extended the idea to all promql functions
Signed-off-by: darshanime <deathbullet@gmail.com>
* pass single Matrix
Signed-off-by: darshanime <deathbullet@gmail.com>
---------
Signed-off-by: darshanime <deathbullet@gmail.com>
2025-07-23 17:30:03 +01:00
machine424
9a0bbb60bc
test(tsdb): disable TestDelayedCompaction/delayed_compaction_enabled on windows
...
as flaky because of Time imprecision
fixes https://github.com/prometheus/prometheus/issues/16450
Signed-off-by: machine424 <ayoubmrini424@gmail.com>
2025-07-22 15:30:05 +01:00
Olivier Lemasle
da9b8b2f8d
chore(configuration.md): Fix typo
...
Signed-off-by: Olivier Lemasle <o.lemasle@gmail.com>
2025-07-22 13:50:21 +01:00
Julius Volz
19a8f8c8ea
Merge pull request #16901 from prometheus/configurable-notice-alerts
...
Make query warning/info notice display configurable
2025-07-21 14:24:53 +02:00
Julius Volz
1354bb90be
Make query warning/info notice display configurable
...
Fixes https://github.com/prometheus/prometheus/issues/16888
Signed-off-by: Julius Volz <julius.volz@gmail.com>
2025-07-21 13:03:46 +02:00
Harry John
b09cf6be8d
fix(promql): Ensure native histogram values copied in subqueries ( #16879 )
...
Signed-off-by: 🌲 Harry 🌊 John 🏔 <johrry@amazon.com>
2025-07-21 08:54:54 +02:00
Arthur Silva Sens
3602785a89
Support including scope metadata as metric labels ( #16878 )
...
* Support including scope metadata as metric labels
Signed-off-by: Arthur Silva Sens <arthursens2005@gmail.com>
* Ensure Scope Name, Version and Schema URL aren't overriden by attributes
Signed-off-by: Arthur Silva Sens <arthursens2005@gmail.com>
---------
Signed-off-by: Arthur Silva Sens <arthursens2005@gmail.com>
2025-07-18 13:44:05 -03:00
Charles Korn
46acc974c0
fix(remote): Unregister metrics emitted by remote.WriteStorage when closed ( #16868 )
...
* Unregister metrics emitted by `remote.WriteStorage` when closed
Signed-off-by: Charles Korn <charles.korn@grafana.com>
* Address PR feedback: add test
Signed-off-by: Charles Korn <charles.korn@grafana.com>
---------
Signed-off-by: Charles Korn <charles.korn@grafana.com>
2025-07-17 11:32:15 +02:00
Ayoub Mrini
9dc274687b
Merge pull request #16831 from machine424/nsmeta
...
feat(discovery/kubernetes): allow attaching namespace metadata
2025-07-17 10:30:27 +01:00
Bryan Boreham
6b37b42f6f
Merge pull request #16616 from prymitive/stringLabels
...
Rename labels.go -> labels_slicelabels.go
2025-07-17 09:28:29 +01:00
machine424
b74c3ce153
chore(configuration.md): adjust kubernetes DS config
...
Signed-off-by: machine424 <ayoubmrini424@gmail.com>
2025-07-17 09:55:10 +02:00
machine424
a9f6fdd910
feat(discovery/kubernetes): allow attaching namespace metadata
...
to ingress and service roles.
with the help of claude-4-sonnet
Signed-off-by: machine424 <ayoubmrini424@gmail.com>
2025-07-17 09:53:16 +02:00
Arianna Vespri
a37eb5359a
Upgrade client_golang to v1.23.0-rc.1 ( #16885 )
...
Signed-off-by: Arianna Vespri <arianna.vespri@yahoo.it>
2025-07-16 20:32:15 +02:00
socialsister
869c946370
chore: fix some minor issues in comments
...
Signed-off-by: socialsister <seekseat@qq.com>
2025-07-16 11:24:42 +01:00
Bryan Boreham
a9438f020d
Merge pull request #16870 from prometheus/merge-3.5-into-main
...
Merge release-3.5 into main
2025-07-15 14:30:30 +01:00
Ayoub Mrini
0f0cd5c2cf
chore: add Makefile target to check Node.js version ( #16832 )
...
This helps reduce confusion when UI-related targets fail without
directly indicating a version mismatch.
Automatically runs during UI builds and tests. The check is only
indicative.
The "go" binary can hard stop and print relevant messages on its
own for mismatches, thus not covered here.
supersedes https://github.com/prometheus/prometheus/pull/15106
Signed-off-by: machine424 <ayoubmrini424@gmail.com>
Co-authored-by: Pratham <prathamjagga123@gmail.com>
2025-07-15 12:52:43 +02:00
vanshika
0fc5e75504
scraping: Create a span and send the traceparent header during scrape requests ( #16425 )
...
* Traceparent header
Signed-off-by: Vanshikav123 <vanshikav928@gmail.com>
(cherry picked from commit 44a620dd736e98a77b2d97f288ad87d5dd861544
2025-07-15 09:37:24 +02:00
Bryan Boreham
36ec1e4fb0
Merge branch 'main' into merge-3.5-into-main
...
Signed-off-by: Bryan Boreham <bjboreham@gmail.com>
2025-07-14 15:29:00 +01:00
Bryan Boreham
8be3a9560f
Prepare release 3.5.0
...
Signed-off-by: Bryan Boreham <bjboreham@gmail.com>
2025-07-14 12:38:42 +01:00
github-actions[bot]
3d245e31d3
Merge pull request #16818 from prometheus/dependabot/go_modules/internal/tools/github.com/grpc-ecosystem/grpc-gateway/v2-2.27.1
...
build(deps): bump github.com/grpc-ecosystem/grpc-gateway/v2 from 2.26.3 to 2.27.1 in /internal/tools
2025-07-11 22:08:41 +02:00
github-actions[bot]
6aa6239d0f
Merge pull request #16814 from prometheus/dependabot/go_modules/github.com/ovh/go-ovh-1.9.0
...
build(deps): bump github.com/ovh/go-ovh from 1.8.0 to 1.9.0
2025-07-11 19:16:49 +02:00
Yandi Lee
8eb445b8a4
Discovery.Manager: close sync ch after sender() is stopped ( #14465 )
...
* close sync ch after sender() is stopped
* break if chan is closed
Signed-off-by: liyandi <littlepangdi@163.com>
Co-authored-by: liyandi <liyandi@xiaomi.com>
2025-07-11 17:15:01 +01:00
Bryan Boreham
f1c6fab7e1
Merge pull request #14923 from prometheus/njpm/fix-mockIndex
...
tsdb tests: fix `mockIndex` implementation of `LabelValues` and `LabelNames`
2025-07-11 11:42:00 +01:00
George Krajcsovits
dae80e66a5
test(scrape): make nhcb scrape test more tolerant ( #16862 )
...
Fixes #16689
well, maybe not 100%, but should improve it.
Increase the scrape timeout to be more tolerant of slow test and
also use eventually when checking for targets.
Signed-off-by: György Krajcsovits <gyorgy.krajcsovits@grafana.com>
2025-07-11 12:09:53 +02:00
George Krajcsovits
4662722a8e
chore(promql): improve doc string in promql/durations.go ( #16863 )
...
Signed-off-by: György Krajcsovits <gyorgy.krajcsovits@grafana.com>
2025-07-11 12:07:54 +02:00
dependabot[bot]
d5d601201e
build(deps): bump github.com/grpc-ecosystem/grpc-gateway/v2
...
---
updated-dependencies:
- dependency-name: github.com/grpc-ecosystem/grpc-gateway/v2
dependency-version: 2.27.1
dependency-type: direct:production
update-type: version-update:semver-minor
...
Signed-off-by: dependabot[bot] <support@github.com>
2025-07-11 10:04:09 +00:00
dependabot[bot]
a78f18c666
build(deps): bump github.com/ovh/go-ovh from 1.8.0 to 1.9.0
...
Bumps [github.com/ovh/go-ovh](https://github.com/ovh/go-ovh ) from 1.8.0 to 1.9.0.
- [Release notes](https://github.com/ovh/go-ovh/releases )
- [Commits](https://github.com/ovh/go-ovh/compare/v1.8.0...v1.9.0 )
---
updated-dependencies:
- dependency-name: github.com/ovh/go-ovh
dependency-version: 1.9.0
dependency-type: direct:production
update-type: version-update:semver-minor
...
Signed-off-by: dependabot[bot] <support@github.com>
2025-07-11 10:03:35 +00:00
github-actions[bot]
a740285601
Merge pull request #16812 from prometheus/dependabot/go_modules/github.com/open-telemetry/opentelemetry-collector-contrib/processor/deltatocumulativeprocessor-0.129.0
...
build(deps): bump github.com/open-telemetry/opentelemetry-collector-contrib/processor/deltatocumulativeprocessor from 0.128.0 to 0.129.0
2025-07-11 12:01:47 +02:00
github-actions[bot]
f20e52828c
Merge pull request #16816 from prometheus/dependabot/go_modules/github.com/digitalocean/godo-1.155.0
...
build(deps): bump github.com/digitalocean/godo from 1.152.0 to 1.155.0
2025-07-11 11:57:59 +02:00
github-actions[bot]
c3a683d1bf
Merge pull request #16811 from prometheus/dependabot/go_modules/github.com/linode/linodego-1.52.2
...
build(deps): bump github.com/linode/linodego from 1.52.1 to 1.52.2
2025-07-11 11:57:34 +02:00
dependabot[bot]
74ec898bec
chore(deps): bump ossf/scorecard-action from 2.4.1 to 2.4.2 ( #16677 )
...
Bumps [ossf/scorecard-action](https://github.com/ossf/scorecard-action ) from 2.4.1 to 2.4.2.
- [Release notes](https://github.com/ossf/scorecard-action/releases )
- [Changelog](https://github.com/ossf/scorecard-action/blob/main/RELEASE.md )
- [Commits](f49aabe0b5...05b42c6244
2025-07-11 11:57:05 +02:00
dependabot[bot]
489c22d5b6
chore(deps): bump actions/setup-go from 5.4.0 to 5.5.0 ( #16678 )
...
Bumps [actions/setup-go](https://github.com/actions/setup-go ) from 5.4.0 to 5.5.0.
- [Release notes](https://github.com/actions/setup-go/releases )
- [Commits](0aaccfd150...d35c59abb0
2025-07-11 11:56:37 +02:00
github-actions[bot]
dcdba5fc96
Merge pull request #16676 from prometheus/dependabot/github_actions/dependabot/fetch-metadata-2.4.0
...
chore(deps): bump dependabot/fetch-metadata from 2.3.0 to 2.4.0
2025-07-11 11:56:20 +02:00
github-actions[bot]
6a6682cec0
Merge pull request #16810 from prometheus/dependabot/github_actions/github/codeql-action-3.29.2
...
build(deps): bump github/codeql-action from 3.28.16 to 3.29.2
2025-07-11 11:55:29 +02:00
dependabot[bot]
07028d3cd5
chore(deps): bump golangci/golangci-lint-action from 7.0.0 to 8.0.0 ( #16674 )
...
Bumps [golangci/golangci-lint-action](https://github.com/golangci/golangci-lint-action ) from 7.0.0 to 8.0.0.
- [Release notes](https://github.com/golangci/golangci-lint-action/releases )
- [Commits](1481404843...4afd733a84
2025-07-11 11:55:00 +02:00
dependabot[bot]
83b4cfdf5e
chore(deps): bump golangci/golangci-lint-action in /scripts ( #16679 )
...
Bumps [golangci/golangci-lint-action](https://github.com/golangci/golangci-lint-action ) from 7.0.0 to 8.0.0.
- [Release notes](https://github.com/golangci/golangci-lint-action/releases )
- [Commits](1481404843...4afd733a84
2025-07-11 11:54:27 +02:00
github-actions[bot]
ce74e3918f
Merge pull request #16680 from prometheus/dependabot/github_actions/scripts/actions/setup-go-5.5.0
...
chore(deps): bump actions/setup-go from 5.4.0 to 5.5.0 in /scripts
2025-07-11 11:53:54 +02:00
Cristian Greco
3a5db2d442
ci: address golangci-lint issue with persist-credentials ( #16861 )
...
* ci: address golangci-lint issue with persist-credentials
Fixes the following zizmor warning:
```
warning[artipacked]: credential persistence through GitHub Actions artifacts
--> scripts/golangci-lint.yml:26:9
|
26 | - name: Checkout repository
| _________-
27 | | uses: actions/checkout@11bd71901b # v4.2.2
28 | | # with:
29 | | # persist-credentials: false
| |______________________________________- does not set persist-credentials: false
```
All other actions have been fixed in https://github.com/prometheus/prometheus/pull/16530
Credit to @jharvey10 who also addressed this particular issue in
a5bf67d897
2025-07-11 11:53:32 +02:00
dependabot[bot]
bce1310f0f
build(deps): bump github.com/digitalocean/godo from 1.152.0 to 1.155.0
...
Bumps [github.com/digitalocean/godo](https://github.com/digitalocean/godo ) from 1.152.0 to 1.155.0.
- [Release notes](https://github.com/digitalocean/godo/releases )
- [Changelog](https://github.com/digitalocean/godo/blob/main/CHANGELOG.md )
- [Commits](https://github.com/digitalocean/godo/compare/v1.152.0...v1.155.0 )
---
updated-dependencies:
- dependency-name: github.com/digitalocean/godo
dependency-version: 1.155.0
dependency-type: direct:production
update-type: version-update:semver-minor
...
Signed-off-by: dependabot[bot] <support@github.com>
2025-07-11 09:21:44 +00:00
github-actions[bot]
63980e763e
Merge pull request #16817 from prometheus/dependabot/go_modules/github.com/docker/docker-28.3.0incompatible
...
build(deps): bump github.com/docker/docker from 28.2.2+incompatible to 28.3.0+incompatible
2025-07-11 11:20:31 +02:00
github-actions[bot]
e401c11e43
Merge pull request #16813 from prometheus/dependabot/go_modules/google.golang.org/api-0.239.0
...
build(deps): bump google.golang.org/api from 0.238.0 to 0.239.0
2025-07-11 11:19:59 +02:00
Nicolás Pazos
b43a07248f
tsdb tests: fix mockIndex implementation
...
Signed-off-by: Nicolás Pazos <npazosmendez@gmail.com>
2025-07-10 15:59:38 -03:00
Owen Williams
d2f1f4fb27
config: Add UnderscoreEscapingWithoutSuffixes translation strategy ( #16849 )
...
The last permutation of the translation options does underscore translation but does not add suffixes.
This translation option already exists in Mimir as otel_metric_suffixes_enabled, indicating external demand for this strategy.
There is an accompanying update to prometheus-docs to explain the use of this mode: https://github.com/prometheus/docs/pull/2688
Signed-off-by: Owen Williams <owen.williams@grafana.com>
2025-07-10 11:27:23 -04:00
Björn Rabenstein
b7f984d6d2
Merge pull request #16585 from kapillamba4/fix/16393-strict
...
Convert PromQL tests to new syntax via basic migration mode
2025-07-10 15:45:38 +02:00
Björn Rabenstein
eb3ea163fa
promqltest: add tests for histogram_count(increase(...)) ( #16854 )
...
As `histogram_count` is playing tricks to improve performance, we
better make sure that the limitation of extrapolation below zero still
works as expected.
Signed-off-by: beorn7 <beorn@grafana.com>
2025-07-10 15:44:02 +02:00
Charles Korn
8397b738bf
docs: clarify docs for PromQL aggregation operators ( #16837 )
...
Signed-off-by: Charles Korn <charles.korn@grafana.com>
2025-07-10 15:34:57 +02:00
