1129 Commits

Author SHA1 Message Date
Pavlin Radoslavov
a1e2656a8e Fix a copy-and-paste bug within method
LinkCollectionIntentInstaller.deactivate() to unregister as an installer.

Change-Id: Ia4ba3aefcbdc8c4e4c23c1ab831c71b6c61626f7
2015-02-13 16:10:43 -08:00
Brian O'Connor
e2eac102fc Using replace instead install when there is already an intent
Fixes the problem of flows being left on the data plane

Change-Id: Iec3db8b460123f2744a57d8c08d14c8effe9ec34
2015-02-13 14:16:23 -08:00
Sho SHIMIZU
95a7baf4fa Remove IntentStore access in IntentUpdate subclasses
Change-Id: I923c62f1d34dc2c911323f11990de5c9788bf655
2015-02-13 14:16:23 -08:00
Brian O'Connor
998f0cc744 adding and removing tracked resources
Change-Id: I5030e1c21a61e54f251dbc5760783f1ac2e4d2d7
2015-02-13 14:14:00 -08:00
Brian O'Connor
ea2ba3e713 Intent manager cleanup
Change-Id: I5a83a69cbaa8f498e5c0ed21588dedf15790d877
2015-02-13 14:13:58 -08:00
Sho SHIMIZU
bb4d827c44 Handle exception that is potentially occurred in WithdrawCoordinating
- Introduce a common parent class, AbstractFailed for IntentUpdate
  subclass representing failure
- Write Javadoc for each class representing failure

Change-Id: I3945642f5985ddd66c11b6de1924b9c1d23a5fc6
2015-02-13 14:13:56 -08:00
Sho SHIMIZU
6aa4fb422d Avoid unnecessary state transition
Change state from WithdrawRequest to Withdrawn directly when
there is nothing in the store with the key

Change-Id: Ia38d02bcff8df7aad35fbb975843c6741ff540f4
2015-02-13 14:13:56 -08:00
Jonathan Hart
2f669364ca Generalize the MultiValuedTimestamp.
Change-Id: I691730d59f440778856afd0e4808ba775eccba0a
2015-02-13 14:13:54 -08:00
Ray Milkey
9f74c08c6b Fix intent manager unit tests
Change-Id: I4bdde294a6cd181d3acf9218824645714c227bae
2015-02-13 14:13:53 -08:00
Jonathan Hart
d0ba217c33 Fix javadoc issues
Change-Id: I68b5e8feba625104f9a5c9eb62a56654ddea0516
2015-02-13 14:13:48 -08:00
Brian O'Connor
47bc855fff Updating SimpleIntentStore
Change-Id: Ide940216f05a69875fcb844d36b073e2e4b9988e
2015-02-13 14:13:22 -08:00
Ray Milkey
4f5d93e992 Fixes for ObjectiveTrackerTest and IntentServiceTest
Change-Id: I10acda2220c2012e0aa07493c2dc91b1a6a81109
2015-02-13 14:13:21 -08:00
Ray Milkey
3af1386461 Keys based on longs should display in hexadecimal
Change-Id: I45d826a4e8c24271d6689f9438d5eca78f557241
2015-02-13 14:13:21 -08:00
Jonathan Hart
4fd4ebb9d0 Continue updating GossipIntentStore to new API.
Includes changes to ECMap to support generating timestamps based on values.

Change-Id: Ide55979aaa4f7757e67a6b3efed6e51d45ee318c
2015-02-13 14:12:30 -08:00
Ray Milkey
f9af43c2ea Refactoring of IntentId based APIs
- getIntent
- getIntentState
- getInstallableIntents

Change-Id: I6d2073dfa165e0e5adcef46fe5908b563b481a43
2015-02-13 14:10:55 -08:00
Brian O'Connor
5811ac2285 Updating MockFlowRuleService with new semantics
Change-Id: I0a373e6cb25728ca48736902feedc3ed8869fa44
2015-02-13 14:10:55 -08:00
Sho SHIMIZU
b5cd581d4e Handle exception when installing fails
- Catch an IntentException in InstallCoordinating and Installing
- Remove FlowRuleBatchOperationConvertionException because it is unused

Change-Id: I99cf07df811ba8489feb75088f83ddc4ebd93c9e
2015-02-13 14:10:55 -08:00
Sho SHIMIZU
877ec2c51f Handle exception when compiling fails
- Change arguments of the constructor of PathNotFoundException
- Change the catched exception in Compiling.execute()

Change-Id: I3b639ffd585900c2a6dd99aeeb313bf20c6104f4
2015-02-13 14:10:55 -08:00
Sho SHIMIZU
37a24a887a Split Withdrawing class into two classes WithdrawCoordinating and Withdrawing
Resolve ONOS-992
- Rename Coordinating to InstallCoordinating for naming consistency
- Add Javadoc to newly added/modified classes
- Rename uninstallIntent() to uninstallCoordinate() in IntentManager
- Rename coordinate() to installCoordinate() in IntentManager

Change-Id: I226592d96cfd8caf248addab2db0d28803c7ca12
2015-02-13 14:10:55 -08:00
Brian O'Connor
ba1abbe032 adding log for error case
Change-Id: Id0f779ad951ef9d11f6b0afeda2d3cba9239f46a
2015-02-13 14:10:48 -08:00
Brian O'Connor
7775bdaa09 Intent F/W improvements
- aggregate installables into FlowRuleOperations
 - added some impl. to SimpleIntentStore
 - created Coordinating State

Change-Id: I5b26ec1fdb7aaff9d5da4f21b2d5a249568ac5ac
2015-02-13 14:10:48 -08:00
Sho SHIMIZU
0e5cdf259d Remove obsolete comment
Change-Id: Ib14cfa5b287d5852011fe9b16f7397a1da306a45
2015-02-13 14:10:47 -08:00
Sho SHIMIZU
d2d9974332 Ensure a CompletedIntentUpdate subclass is the final state
Change-Id: Icecf8a45fad7cb80f3953dcfc081c344d3fa0adb
2015-02-13 14:10:47 -08:00
Sho SHIMIZU
6a2952909a Add missing @Override annotation
Change-Id: Id6bf4bd0ef9a9094ea5523b2df8ecdaee365ee50
2015-02-13 14:10:47 -08:00
Ray Milkey
5b3717ea46 Add keys to intents
- use Key class rather than String for intent keys
- add CLI option to specify a string key
- add key field to constructors for connectivity intents
- translate id into a key if no key is specified

Change-Id: I69ffbad93bc3daddf06a67cb0cffa2130e781b37
2015-02-13 14:10:47 -08:00
Brian O'Connor
0e271dc6d2 Refactored intermediate IntentUpdate classes
Change-Id: I3d4a435ef4aa97559d5407d49f45519098c3f193
2015-02-13 14:10:47 -08:00
Sho SHIMIZU
5f281a45e4 Refactor: rename "ops" to "data"
Change-Id: I92fc471e545e880d90079923c47c405b29853ed2
2015-02-13 14:10:47 -08:00
Brian O'Connor
db15b04081 started work to parrallize compliation and "installation"
Change-Id: I2e7f03b9f8074ef6f9e1c186009ed3cad6980b49
2015-02-13 14:10:46 -08:00
Brian O'Connor
098da072fe fixed typo and undeprecated a method
Change-Id: Ia15c4df9978ac66d4cd5288f9462d3238958893e
2015-02-13 14:10:46 -08:00
Sho SHIMIZU
5cb438e386 Pull out inner IntentUpdate sub-classes from IntentManager
Change-Id: Iefec2e3d5929d0e85e40bee24ba4fd0679c13b19
2015-02-13 14:10:46 -08:00
Sho SHIMIZU
8d9d136bd2 Extract a method to create a list of FlowRuleBatchOperation
- Define FlowRuleBatchOperationConvertionException, which is a
  new IntentException sub-class

Change-Id: I798303fa986f573c885b8712ac1dfee1bcaadf95
2015-02-13 14:10:46 -08:00
Sho SHIMIZU
c708f3b4af Remove CompilingFailed because it does nothing
Change-Id: Ibeb244d0a9ebfbf019bc72e1efeacb73c3140cb2
2015-02-13 14:10:46 -08:00
Sho SHIMIZU
46f48fb7e9 Change the return type of IntentAccumulator.reduce()
Change-Id: I31b57537c800e1599f19e4c0a4156db9df0406af
2015-02-13 14:10:46 -08:00
Sho SHIMIZU
946913c275 Remove calls of IntentStore.batchWrite()
We are changing the write behavior to IntentStore, then
calls of IntentStore.batchWrite will be replaced.

Change-Id: Id9685d5631fea02f1d2ef30e12c503c7cf2c44ef
2015-02-13 14:10:45 -08:00
Ray Milkey
2468502d4c Removed deprecated intent operations
Change-Id: I2ca316dab4c1ac1a66fb4ddf101c4adf3302dcd2
2015-02-13 14:10:45 -08:00
Ray Milkey
2da272b94e Removed deprecated classes/interfaces
IntentBatchLeaderEvent
IntentBatchListener
IntentBatchService

Change-Id: I712f0eb0b26d9bfaa820a14022c1dd30943fab27
2015-02-13 14:10:45 -08:00
Sho SHIMIZU
55a551869f Remove comments that won't get meaningful during refactoring
Change-Id: Ia826e01b48821d167bb5f690b768e8305798a2fd
2015-02-13 14:10:45 -08:00
Sho SHIMIZU
62808d1165 Enforce overrinding execute() method in IntentUpdate subclasses
Change-Id: I02cf03abd60f771357b98bbd79c83eb3e0dce958
2015-02-13 14:10:45 -08:00
Sho SHIMIZU
6cb01e282b Remove class that is no longer used
Change-Id: I473b70e1cffba9728a3ebac23250b846a593a040
2015-02-13 14:09:08 -08:00
Sho SHIMIZU
39db1bb497 Remove classes that are no longer used
Change-Id: Idb5cfdadf9e6062b59500200a551ed5deaa362d7
2015-02-13 14:09:08 -08:00
Brian O'Connor
03406a4702 IntentStore interface changes
Change-Id: Ifa8728fb4c7edcc6d58a5e071f7252493ab2a578
2015-02-13 14:07:52 -08:00
Brian O'Connor
b499b3594d Updates to Intent Manager and store interface
Change-Id: Ida612bf5d0f4abe7e81d2f307a80f989603015e7
2015-02-13 13:59:20 -08:00
Ray Milkey
24226a2175 Start IntentOperations removal
Change-Id: Ib5fb9c19b37e447a62c61fa33bb98f3d789cbefa
2015-02-13 13:59:20 -08:00
Brian O'Connor
cff03322bf Started refactoring Intent Manager
Introduced IntentData and reworked APIs

Change-Id: I1fa437ceb1b72c4017ac2da1573bfbeb64c0632a
2015-02-13 13:59:19 -08:00
Pavlin Radoslavov
cef5206209 Use the correct IPv6 source address when forwarding NDP requests
on external ports.

This fixes ONOS-1021

Also, a minor optimization when forwarding the ARP or NDP request
on external ports.

Change-Id: Ic745e1af1f0a0602751977726a850f48afe84262
2015-02-13 14:19:58 +00:00
Dusan Pajin
a22b970637 ProxyArpManager - fix IPv6 ND Adv issue with Option fields and ARP/NDP Reply
with first IP address from Host service

This fixes ONOS-1010

Also, add protocol-related constants to class NeighborAdvertisement.

Change-Id: Iacf9e48a8a03a86e1cc4e89e7e2b2b4ccc4a7e3a
2015-02-12 22:25:31 +00:00
sangho
7ff01813fe ONOS-944: Implemented a Group operation failure handler in GroupManger and SimpleGroupStore.
Change-Id: Ib3be4d534ceff04af2dad0c062fd4cd63d49ee82
2015-02-11 23:56:53 +00:00
Brian O'Connor
72cb19a90e Implementation of new Flow Subsystem:
The subsystem no longer returns futures for tracking completion of work.
Notifications are explicitely returned via a call back mechanism. Also, the
subsystem is now asynchronous.

Change-Id: I1a4cef931c24820f9ae9ed9a5398f163f05dfbc9

more flowservice improvements

Change-Id: I5c9c1b6be4b2ebfa523b64f6f52e7634b7d3e05f

more flowservice impl

Change-Id: I05f6774460effb53ced8c36844bcda2f8f6c096f

Manager to store functional (at least i believe it)

Change-Id: I09b04989bd1004c98fe0bafed4c76714b9155d53

flow subsystem functional: need to fix unit tests

Change-Id: I1667f25b91320f625a03e5e1d5e92823184d9de0

flow subsystem functional

Change-Id: I429b3335c16d4fc16f5d55f233dd37c4d1d6111d

finished refactor of flow subsystem

Change-Id: I1899abc6ff6a974a2018d936cc555049c70a6804

fix for null flow provider to use new api

Change-Id: If2fd9bd5baf74d9c61c5c8085cef8bc2d204cbdc
2015-02-11 21:28:01 +00:00
alshabib
fd3cc05f65 fix for mastership race condition.
Change-Id: Id219bdf00f3d6501027566d54342c5d7c1b27789
2015-02-10 15:16:57 -08:00
Kunihiro Ishiguro
1eab7d5f25 Add IPv6 HostManager test.
Change-Id: I84a54b3635fd5b7a2a591f9bcf54cb3f7bceaddb
2015-02-10 18:13:45 +00:00