1129 Commits

Author SHA1 Message Date
Sho SHIMIZU
64d4867b46 Add unit tests for Installing phase
Change-Id: I8955d20d523daf3abd8e1ef597bf5c26254ca68a
2015-02-25 08:59:37 -08:00
Sho SHIMIZU
0a3bb1d9ed Add unit tests for InstallCoordinating phase
Change-Id: I49764e9fef761ff0a31da77a2f3a22a3f16fdb63
2015-02-24 23:46:56 +00:00
Sho SHIMIZU
892509aa5f Add unit tests for Compiling phase
Change-Id: Ib28e48ad0f4e26f56bd2d416ee7f19f9c420a63d
2015-02-24 23:44:22 +00:00
Sho SHIMIZU
d42058eb89 Rename IntentBatchPreprocess to make its name consistent with behavior
Remove "Pre" from the name

Change-Id: I87da1d9e0f4308ff6a545012c26b6618b8415338
2015-02-24 19:32:03 +00:00
Sho SHIMIZU
214ac322b1 Tighten visibility because it is not needed to be public
Change-Id: I5925eeff3efa8d3581be1efd4763ad16d6414c9e
2015-02-24 19:28:40 +00:00
Sho SHIMIZU
559e4b9560 Remove unused method/constructor/fields/constants
Change-Id: I38d77cf30ab9948acd74d24fcc15c65749fc347b
2015-02-24 19:28:04 +00:00
Sho SHIMIZU
ce49b605d6 Remove dependency on IntentData and IntentStore from IntentWorker
- Make createInitialPhase() static and move it to IntentProcessPhase
  - Additionally, rename to newInitialPhase()
- IntentWorker's constructor receives an initial intent process phase

Change-Id: I4774493230a008fc5530d9d90b262e1eb441f946
2015-02-24 19:27:59 +00:00
Sho SHIMIZU
662c3dbf1b Pull out IntentWorker from IntentManager
- IntentWorker is placed in phase package
- Make public IntentProcessPhase subclasses package private now

Change-Id: Ie7d218fe5d8a516f3913ff8881d9d17cfd8e4c46
2015-02-24 19:27:58 +00:00
Sho SHIMIZU
e38adb343a Remove reference to a field of IntentManager from IntentWorker
Change-Id: I3ab69f3bcdaa92516783dec096a80220edfc55d5
2015-02-24 19:27:58 +00:00
Sho SHIMIZU
0cb6fe6557 Remove reference to a field of IntentManager from IntentWorker
Change-Id: I094c4019fbe8af342e2dae2a1c5ad780728cf27a
2015-02-24 19:27:57 +00:00
Sho SHIMIZU
b413be88c1 Remove createIntentUpdate() a method under IntentWorker
Because the method is only accessed from IntentWorker

Change-Id: Id80a93a7dfdaabc0c78a519a47fd979572d990ef
2015-02-24 19:27:57 +00:00
Pavlin Radoslavov
89edb541d7 Added IPv6 support to HostMonitor
This fixes ONOS-635

Change-Id: I49cb135af38d54298ba950d5ce1cc110a6f3184d
2015-02-24 08:43:39 +00:00
Ray Milkey
43a2822c10 Refactor tests to use shared mock implementations
Change-Id: Iba4e44b7bb88f8a31add9475a9155f85375ae61a
2015-02-23 22:44:24 +00:00
Ray Milkey
5a7787a62c Unit test for intent accumulator
Change-Id: Id9f8c918bdddc7fe24e4eb283676fd94275e58cf
2015-02-23 13:58:21 -08:00
Thomas Vachuska
4c6c377110 Fixed javadocs.
Change-Id: I74064c7e6dce702c769272cfa5dba99a61ea5abc
2015-02-23 08:50:49 -08:00
Thomas Vachuska
a132e3acd3 Made intent perf app multi-threaded; doesn't seem to help.
Made Jono's changes to ECM per Madan's suggesion.
Added cell beast.
Re-enabled anti-entropy.
Added ability to push bits through test proxy for faster upload.

Change-Id: I1455d6d443a697d7a3973c88cb81bfdac0e1dd7f
2015-02-22 20:31:04 +00:00
Thomas Vachuska
6f94deddef Converted all executors that previously used namedThreads to use groupedThreads instead.
Change-Id: I048709308270de5b7552bc4e8395b0f7201d5949
2015-02-21 14:02:38 -08:00
Sho SHIMIZU
6c28f8371c ONOS-1066: Move IntentCompilers to the dedicated package
Change-Id: I3e588cab0559093d389c9d44d2c7df536cabe953
2015-02-21 18:05:12 +00:00
Sho SHIMIZU
b70521702d Remove dependency on PointToPointIntentCompiler
Create an installable intent, not relying on an IntentCompiler.
This change enables IntentCompilers to be moved to a dedicated package.

Reference: ONOS-1066

Change-Id: Ie5bca33720232afaa4d6642d4f9fda933f6d00e3
2015-02-21 18:01:51 +00:00
Sho SHIMIZU
0e738806ff Move unit tests to PointToPointIntentCompilerTest
The unit tests only depend on PointToPointIntentCompiler and it would be
obstacles when IntentCompiler subclasses are moved to a dedicated package

Change-Id: Ifbfe5ef2a4bae014d2b6cae599fe8860a54e01ca
Reference: ONOS-1066
2015-02-21 17:58:07 +00:00
Sho SHIMIZU
575a364517 Remove obsolete todo comment
Change-Id: I9ebb573e8c259abd71f2cc90bae20764c10cf620
2015-02-21 09:47:50 -08:00
Sho SHIMIZU
b0a47d41c8 ONOS-1048 - Define interfaces instead of using IntentManager
- Define IntentProcessor interface containing methods to process an intent
- Pull out IntentCompiler related tasks to CompilerRegistry
- Pull out IntentInstaller related tasks to InstallerRegistry
- Create an IntentProcessor subclass as inner class in IntentManager

Change-Id: Ia3e8d574a1053e7ddc9b961873ef758c9e0b1b26
2015-02-21 09:33:13 -08:00
Pavlin Radoslavov
b9e50dff43 Fixed a bug when parsing configuration properties for ReactiveForwarding
by catching the appropriate exception.

Apparently, if a property is configured/enabled in file Foo.cfg, e.g.:
  flowTimeout = 10
then the corresponding object/value in the Dictionary returned by
ComponentContext.getProperties()
has class type String.

However, if the property is commented-out, e.g.:

then the Dictionary still contains an entry for "flowTimeout", but
its class type is Integer.

Also, updated similar code elsewhere that was catching the generic
Exception with catching more specific exception(s).

Change-Id: I33ec348eb9efe3188e22cfc8cee2bb704948726d
2015-02-21 15:57:17 +00:00
Brian O'Connor
64a0369dfb IntentInstaller: changing from Set to Collection to improve perf
Change-Id: Ia7f0f7d893645c7528ac9f51acff133f6d82383d
2015-02-20 22:15:46 -08:00
Sho SHIMIZU
1ee563a503 Remove unnecessary non-null check assertions
Private methods need to ensure to return a non-null value

Change-Id: Ie1fffc52282660c4d32c8fbedd9f47049b2e74ae
2015-02-21 05:53:30 +00:00
Ray Milkey
144eec5207 Fix Javadoc warnings
Change-Id: I366f2b9f3c11645a3392e0689619bfbad7a9eedd
2015-02-20 20:54:26 +00:00
Brian O'Connor
be28a87c0e Chaning IntentStore.isMaster to take a key
Change-Id: I2d04a6aa7418e06137b0688bcb4e3af060a02b63
2015-02-19 21:50:20 -08:00
Ray Milkey
71ade56cbf Refactor Intent subsystem to eliminate using FlowRuleBatchOperation
Change-Id: Iee76dac5fa9935713ffc370b34ac47d9286ff351
2015-02-20 00:59:03 +00:00
Ray Milkey
cc53abd74e Favor adapter classes over service interfaces in unit tests
In unit tests that are mocking an entire interface, instead
extend the Adapter class so the unused method overrides
are no longer needed.

Change-Id: I6e332cc5cb59410f163deea223fbc94e73d83917
2015-02-20 00:35:32 +00:00
Thomas Vachuska
718d399045 Fixing javadoc configuration and adding some package documentation.
Change-Id: Ibeb58b954b1d5ed1939a70afda3f5523807cee23
2015-02-19 19:08:12 +00:00
Thomas Vachuska
ecb63c5a01 Updated accumulator documentation and refactored names to remove the event heritage.
Change-Id: I2238ab1215281702e670a406fb901ba8a4ef85ce
2015-02-19 18:26:00 +00:00
Pavlin Radoslavov
a2626ef982 Implemented a mechanism to easily add and access Neighbor Discovery protocol
packet options.

Fixes ONOS-1011

Change-Id: I94daa3f3c1297fb9a7b44901927738a29aff030a
2015-02-19 17:17:56 +00:00
Brian O'Connor
b715f62e6c PathIntentInstaller: avoiding calls to Resource Store when unnecessary
Change-Id: I846ca543f922063ddc67a06353f43c590bd57d96
2015-02-18 21:04:54 -08:00
Brian O'Connor
bdc7f00e92 Changing IntentManager to use groupedThreads
Change-Id: I83854c2d6d6fcc8b10a0f50e625aa4be5ff255bb
2015-02-18 21:04:54 -08:00
Brian O'Connor
d12267c7b1 changing FlowRuleManager from cached threadpool to fixed thread pool
Change-Id: Ie24dae672e699447b55411bf3492efa96e2e16c2
2015-02-18 21:04:54 -08:00
alshabib
78baaf2af2 fix for flows stuck in pending add state
Problem is due to two packet requests from different services
for the same selector resulting in the same flow rule.
Since these rules where the same, only one ended up on the data plane,
but sadly only the first request made it into the flow service meaning
that in cases where what was in the flow service does not match what is
on the dataplane resulting in a PENDING_ADD situation.

Change-Id: I4c03e753be6e198e04f0b5263a2aa8cf2edc51e1
2015-02-19 03:05:17 +00:00
Sho SHIMIZU
36a8a6e8ef Move IntentUpdate subclasses to the dedicated package
Resolve ONOS-1051
- Create package "phase" under intent.impl
- Rename IntentUpdate and CompletedIntentUpdate
  - IntentUpdate -> IntentProcessPhase
  - CompletedIntentUpdate -> FinalIntentProcessPhase
- Loosen method/field visibility as short term hack

Change-Id: Idc0fd9a74aadd227d62006d00fee473c63b1fc05
2015-02-18 21:24:10 +00:00
Ray Milkey
024798622b ONOS-1058 - Add application Id to intent withdraw command
Change-Id: I6f660f2e115e4acc9d3c7d1ab2e2115caaf1822f
2015-02-18 19:09:03 +00:00
Ray Milkey
da36c40e9d ONOS-1057 - Remove references to deprecated applyBatch() method
Change-Id: I9215fde6be2acaa2becea58d8b6e5b171ff16817
2015-02-18 18:59:48 +00:00
Hongtao Yin
36f79aa93b Updated calendar server code. Added intent for bi-dirctional path. Added latency as one more parameter in constraints.
Added exception catch for parsing parameters.

Fixed Jenkins checking errors.

Use intent key and 2way intent P2P setup.

Change-Id: Ib2bd25deb793b2a34179cbf8794ca5aa3e427f91
2015-02-18 06:29:22 +00:00
Sho SHIMIZU
d3dcaa16b1 Fix comments
- Delete obsolete TODO comment
- Write Javadoc for IntentUpdate subclasses which have no Javadoc

Change-Id: I2b233fa9741733fd3642bbbe639990b1ce0b7405
2015-02-18 06:27:18 +00:00
Brian O'Connor
ab8ef82294 Fixing bug in withdraw request when current intent is null
Also, demoting some log levels

Change-Id: I4c7e85bc2bc06e08fe62819d4f66ec8111050a07
2015-02-17 18:08:54 -08:00
Brian O'Connor
916de34f16 Disabling FlowRuleExtService components
Change-Id: Ia4a53da3af577280966ad06cb343bcdb4eb68d01
2015-02-17 18:07:32 -08:00
Marc De Leenheer
b473b9dd2d Injecting topology through JSON ConfigProvider works for multi-instance (ONOS-490).
Change-Id: Ib977f4cf9a59ddec360072891fd803c6f9ee84f1

Injecting optical device annotations and ports works for multi-instance (ONOS-870).

Change-Id: Icdde16ef72fc4e47eec7213250b04902083f0537
2015-02-17 23:55:59 +00:00
alshabib
a66a05635c do not initialise the flowext subsystem
Change-Id: I760a95a27fce91c80b5f5f3d396c80e4b0eca378
2015-02-17 15:50:54 -08:00
Ray Milkey
f7329c77eb Remove some deprecated APIs and warnings from BatchOperationEntry
Change-Id: I44daf9646f6d2a60fd7c0ce96d6692ab8a9cdda2
2015-02-17 20:53:41 +00:00
Hongtao Yin
142b758ba3 Initial implementation: The init extended flow rule and store interface APIs
The APIs are for supporting service data to install on network devices.
This is related to JIRA ticket ID ONOS-869.

Updated API code and added implementation code files.

Modified API for supporting payload abstruction, and added routing mechanism for pushing flow rules to devices.
Added more javadoc, and fixed some minor issues.

Updated javadoc, removed unnecessary method, and test code.

Change-Id: I105defc92a9e01b30601fcb56a9dafa086d4adc0
2015-02-17 11:29:03 -08:00
alshabib
93cb57f160 Fix a bug where default rules were not pushed after restarting mininet.
Change-Id: Icf4c7ed009a5938d28b58128cfc226067a0d4c9e
2015-02-17 18:43:34 +00:00
Srikanth Vavilapalli
ed12ae5e81 ONOS-985: Sample integration test application for group subsystem
Change-Id: I68352f922e5c7a0800fcc4fa839955769bf925a6
2015-02-17 17:58:49 +00:00
Michele Santuari
4b6019e449 ONOS-631 #Initial MPLS intent implementation
Change-Id: I6f906b953f06f395cc67e612648802e333c0e581
2015-02-14 10:00:48 +00:00