mirrors/k3d
1
0
Fork 0
Code Issues Pull Requests Projects Releases Wiki Activity

fix/clusterCreate: use StringSlice for k3s-server|agent-arg flag

Browse Source 
- required due to StringArray incompatibility in Viper
Fixes #482
This commit is contained in:
iwilltry42 2021-02-06 20:57:51 +01:00
parent b8d0872ba9
commit e2a05c1f39
No known key found for this signature in database
GPG Key ID: 7BA57AD1CFF16110
2 changed files with 8 additions and 2 deletions
Show Stats Download Patch File Download Diff File Expand all files Collapse all files

6
CHANGELOG.md
View File

@ -1,5 +1,11 @@
# Changelog # Changelog
## v4.1.1
### Fixes
- fix: `--k3s-server-arg` and `--k3s-agent-arg` didn't work (Viper StringArray incompatibility) (#482)
## v4.1.0 ## v4.1.0
### Highlights ### Highlights

4
cmd/cluster/clusterCreate.go
View File

@ -323,10 +323,10 @@ func NewCmdClusterCreate() *cobra.Command {
_ = cfgViper.BindPFlag("registries.config", cmd.Flags().Lookup("registry-config")) _ = cfgViper.BindPFlag("registries.config", cmd.Flags().Lookup("registry-config"))
/* k3s */ /* k3s */
cmd.Flags().StringArray("k3s-server-arg", nil, "Additional args passed to the `k3s server` command on server nodes (new flag per arg)") cmd.Flags().StringSlice("k3s-server-arg", nil, "Additional args passed to the `k3s server` command on server nodes (new flag per arg)")
_ = cfgViper.BindPFlag("options.k3s.extraserverargs", cmd.Flags().Lookup("k3s-server-arg")) _ = cfgViper.BindPFlag("options.k3s.extraserverargs", cmd.Flags().Lookup("k3s-server-arg"))
cmd.Flags().StringArray("k3s-agent-arg", nil, "Additional args passed to the `k3s agent` command on agent nodes (new flag per arg)") cmd.Flags().StringSlice("k3s-agent-arg", nil, "Additional args passed to the `k3s agent` command on agent nodes (new flag per arg)")
_ = cfgViper.BindPFlag("options.k3s.extraagentargs", cmd.Flags().Lookup("k3s-agent-arg")) _ = cfgViper.BindPFlag("options.k3s.extraagentargs", cmd.Flags().Lookup("k3s-agent-arg"))
/* Subcommands */ /* Subcommands */