From e2a05c1f39a3c75cbddaf93ccff3030513d1e9ad Mon Sep 17 00:00:00 2001 From: iwilltry42 Date: Sat, 6 Feb 2021 20:57:51 +0100 Subject: [PATCH] fix/clusterCreate: use StringSlice for k3s-server|agent-arg flag - required due to StringArray incompatibility in Viper Fixes #482 --- CHANGELOG.md | 6 ++++++ cmd/cluster/clusterCreate.go | 4 ++-- 2 files changed, 8 insertions(+), 2 deletions(-) diff --git a/CHANGELOG.md b/CHANGELOG.md index a41ce3c4..27967d76 100644 --- a/CHANGELOG.md +++ b/CHANGELOG.md @@ -1,5 +1,11 @@ # Changelog +## v4.1.1 + +### Fixes + +- fix: `--k3s-server-arg` and `--k3s-agent-arg` didn't work (Viper StringArray incompatibility) (#482) + ## v4.1.0 ### Highlights diff --git a/cmd/cluster/clusterCreate.go b/cmd/cluster/clusterCreate.go index 5ca69629..5af065d2 100644 --- a/cmd/cluster/clusterCreate.go +++ b/cmd/cluster/clusterCreate.go @@ -323,10 +323,10 @@ func NewCmdClusterCreate() *cobra.Command { _ = cfgViper.BindPFlag("registries.config", cmd.Flags().Lookup("registry-config")) /* k3s */ - cmd.Flags().StringArray("k3s-server-arg", nil, "Additional args passed to the `k3s server` command on server nodes (new flag per arg)") + cmd.Flags().StringSlice("k3s-server-arg", nil, "Additional args passed to the `k3s server` command on server nodes (new flag per arg)") _ = cfgViper.BindPFlag("options.k3s.extraserverargs", cmd.Flags().Lookup("k3s-server-arg")) - cmd.Flags().StringArray("k3s-agent-arg", nil, "Additional args passed to the `k3s agent` command on agent nodes (new flag per arg)") + cmd.Flags().StringSlice("k3s-agent-arg", nil, "Additional args passed to the `k3s agent` command on agent nodes (new flag per arg)") _ = cfgViper.BindPFlag("options.k3s.extraagentargs", cmd.Flags().Lookup("k3s-agent-arg")) /* Subcommands */