ACK frames are either of type 0x02 or 0x03. The latter is an indication that it contains extra ECN related fields. In haproxy QUIC stack, this is considered as a different frame type, set to QUIC_FT_ACK_ECN, with its own set of builder/parser functions. This patch fixes ACK ECN parsing function. Indeed, the latter suffered from two issues. First, 'first ACK range' and 'ACK ranges' were inverted. Then, the three remaining ECN fields were simply ignored by the parsing function. This issue can cause desynchronization in the frames parsing code, which may result in various result. Most of the time, the connection will be aborted by haproxy due to an invalid frame content read. Note that this issue was not detected earlier as most clients do not enable ECN support if the peer is not able to emit ACK ECN frame first, which haproxy currently never sends. Nevertheless, this is not the case for every client implementation, thus proper ACK ECN parsing is mandatory for a proper QUIC stack support. Fix this by adjusting quic_parse_ack_ecn_frame() function. The remaining ECN fields are parsed to ensure correct packet parsing. Currently, they are not used by the congestion controller. This must be backported up to 2.6.
HAProxy
HAProxy is a free, very fast and reliable reverse-proxy offering high availability, load balancing, and proxying for TCP and HTTP-based applications.
Installation
The INSTALL file describes how to build HAProxy. A list of packages is also available on the wiki.
Getting help
The discourse and the mailing-list are available for questions or configuration assistance. You can also use the slack or IRC channel. Please don't use the issue tracker for these.
The issue tracker is only for bug reports or feature requests.
Documentation
The HAProxy documentation has been split into a number of different files for ease of use. It is available in text format as well as HTML. The wiki is also meant to replace the old architecture guide.
Please refer to the following files depending on what you're looking for:
- INSTALL for instructions on how to build and install HAProxy
- BRANCHES to understand the project's life cycle and what version to use
- LICENSE for the project's license
- CONTRIBUTING for the process to follow to submit contributions
The more detailed documentation is located into the doc/ directory:
- doc/intro.txt for a quick introduction on HAProxy
- doc/configuration.txt for the configuration's reference manual
- doc/lua.txt for the Lua's reference manual
- doc/SPOE.txt for how to use the SPOE engine
- doc/network-namespaces.txt for how to use network namespaces under Linux
- doc/management.txt for the management guide
- doc/regression-testing.txt for how to use the regression testing suite
- doc/peers.txt for the peers protocol reference
- doc/coding-style.txt for how to adopt HAProxy's coding style
- doc/internals for developer-specific documentation (not all up to date)
License
HAProxy is licensed under GPL 2 or any later version, the headers under LGPL 2.1. See the LICENSE file for a more detailed explanation.
