mirrors/haproxy
1
0
Fork 0
mirror of https://git.haproxy.org/git/haproxy.git/ synced 2025-08-07 23:56:57 +02:00
Code Issues Projects Releases Wiki Activity

MINOR: queue: Replace if() + abort() with BUG_ON()

Browse Source 
see 5cd4bbd7a ("BUG/MAJOR: threads/queue: Fix thread-safety issues on the queues management")
This commit is contained in:
Tim Duesterhus 2022-02-28 19:16:31 +01:00 committed by Willy Tarreau
parent 0dd8dd6c71
commit cc8348fbc1
1 changed files with 7 additions and 8 deletions
Show Stats Download Patch File Download Diff File Expand all files Collapse all files

15
src/queue.c
View File

@ -567,14 +567,13 @@ int pendconn_dequeue(struct stream *strm)
struct pendconn *p; struct pendconn *p;
int is_unlinked; int is_unlinked;
if (unlikely(!strm->pend_pos)) { /* unexpected case because it is called by the stream itself and
/* unexpected case because it is called by the stream itself and * only the stream can release a pendconn. So it is only
* only the stream can release a pendconn. So it is only * possible if a pendconn is released by someone else or if the
* possible if a pendconn is released by someone else or if the * stream is supposed to be queued but without its associated
* stream is supposed to be queued but without its associated * pendconn. In both cases it is a bug! */
* pendconn. In both cases it is a bug! */ BUG_ON(!strm->pend_pos);
abort();
}
p = strm->pend_pos; p = strm->pend_pos;
/* note below : we need to grab the queue's lock to check for emptiness /* note below : we need to grab the queue's lock to check for emptiness