From cc8348fbc14cbf9c696fc448fdc681e48ce1f751 Mon Sep 17 00:00:00 2001 From: Tim Duesterhus Date: Mon, 28 Feb 2022 19:16:31 +0100 Subject: [PATCH] MINOR: queue: Replace if() + abort() with BUG_ON() see 5cd4bbd7a ("BUG/MAJOR: threads/queue: Fix thread-safety issues on the queues management") --- src/queue.c | 15 +++++++-------- 1 file changed, 7 insertions(+), 8 deletions(-) diff --git a/src/queue.c b/src/queue.c index b1be766b9..002b94b85 100644 --- a/src/queue.c +++ b/src/queue.c @@ -567,14 +567,13 @@ int pendconn_dequeue(struct stream *strm) struct pendconn *p; int is_unlinked; - if (unlikely(!strm->pend_pos)) { - /* unexpected case because it is called by the stream itself and - * only the stream can release a pendconn. So it is only - * possible if a pendconn is released by someone else or if the - * stream is supposed to be queued but without its associated - * pendconn. In both cases it is a bug! */ - abort(); - } + /* unexpected case because it is called by the stream itself and + * only the stream can release a pendconn. So it is only + * possible if a pendconn is released by someone else or if the + * stream is supposed to be queued but without its associated + * pendconn. In both cases it is a bug! */ + BUG_ON(!strm->pend_pos); + p = strm->pend_pos; /* note below : we need to grab the queue's lock to check for emptiness