mirrors/haproxy
1
0
Fork 0
mirror of https://git.haproxy.org/git/haproxy.git/ synced 2025-09-22 14:21:25 +02:00
Code Issues Projects Releases Wiki Activity

MINOR: h2: don't turn HTX header names to lower case anymore

Browse Source 
Since HTX stores header names in lower case already, we don't need to
do it again anymore. This increased H2 performance by 2.7% on quick
tests, now making H2 overr HTX about 5.5% faster than H2 over H1.
This commit is contained in:
Willy Tarreau 2018-12-07 08:57:20 +01:00
parent ed00e345e2
commit c2a10d4b4c
1 changed files with 0 additions and 24 deletions
Show Stats Download Patch File Download Diff File Expand all files Collapse all files

24
src/mux_h2.c
View File

@ -3843,18 +3843,6 @@ static size_t h2s_htx_frt_make_resp_headers(struct h2s *h2s, struct htx *htx)
list[hdr].n = htx_get_blk_name(htx, blk); list[hdr].n = htx_get_blk_name(htx, blk);
list[hdr].v = htx_get_blk_value(htx, blk); list[hdr].v = htx_get_blk_value(htx, blk);
#if 1
{
/* FIXME: header names MUST be lower case in H2. For now it's
* not granted by HTX so let's force them now.
*/
char *p;
for (p = list[hdr].n.ptr; p != list[hdr].n.ptr + list[hdr].n.len; p++)
if (unlikely(isupper(*p)))
*p = tolower(*p);
}
#endif
hdr++; hdr++;
} }
@ -4069,18 +4057,6 @@ static size_t h2s_htx_bck_make_req_headers(struct h2s *h2s, struct htx *htx)
list[hdr].n = htx_get_blk_name(htx, blk); list[hdr].n = htx_get_blk_name(htx, blk);
list[hdr].v = htx_get_blk_value(htx, blk); list[hdr].v = htx_get_blk_value(htx, blk);
#if 1
{
/* FIXME: header names MUST be lower case in H2. For now it's
* not granted by HTX so let's force them now.
*/
char *p;
for (p = list[hdr].n.ptr; p != list[hdr].n.ptr + list[hdr].n.len; p++)
if (unlikely(isupper(*p)))
*p = tolower(*p);
}
#endif
hdr++; hdr++;
} }