From c2a10d4b4cfcfaaa478f88652a9ccd2eb1fb211e Mon Sep 17 00:00:00 2001 From: Willy Tarreau Date: Fri, 7 Dec 2018 08:57:20 +0100 Subject: [PATCH] MINOR: h2: don't turn HTX header names to lower case anymore Since HTX stores header names in lower case already, we don't need to do it again anymore. This increased H2 performance by 2.7% on quick tests, now making H2 overr HTX about 5.5% faster than H2 over H1. --- src/mux_h2.c | 24 ------------------------ 1 file changed, 24 deletions(-) diff --git a/src/mux_h2.c b/src/mux_h2.c index dd321ece0..2c8d1cc96 100644 --- a/src/mux_h2.c +++ b/src/mux_h2.c @@ -3843,18 +3843,6 @@ static size_t h2s_htx_frt_make_resp_headers(struct h2s *h2s, struct htx *htx) list[hdr].n = htx_get_blk_name(htx, blk); list[hdr].v = htx_get_blk_value(htx, blk); - -#if 1 - { - /* FIXME: header names MUST be lower case in H2. For now it's - * not granted by HTX so let's force them now. - */ - char *p; - for (p = list[hdr].n.ptr; p != list[hdr].n.ptr + list[hdr].n.len; p++) - if (unlikely(isupper(*p))) - *p = tolower(*p); - } -#endif hdr++; } @@ -4069,18 +4057,6 @@ static size_t h2s_htx_bck_make_req_headers(struct h2s *h2s, struct htx *htx) list[hdr].n = htx_get_blk_name(htx, blk); list[hdr].v = htx_get_blk_value(htx, blk); - -#if 1 - { - /* FIXME: header names MUST be lower case in H2. For now it's - * not granted by HTX so let's force them now. - */ - char *p; - for (p = list[hdr].n.ptr; p != list[hdr].n.ptr + list[hdr].n.len; p++) - if (unlikely(isupper(*p))) - *p = tolower(*p); - } -#endif hdr++; }