mirrors/haproxy
1
0
Fork 0
mirror of https://git.haproxy.org/git/haproxy.git/ synced 2025-08-07 07:37:02 +02:00
Code Issues Projects Releases Wiki Activity

BUG/MINOR: hlua_fcn/queue: fix reference leak

Browse Source 
When pushing a lua object through lua Queue class, a new reference is
created from the object so that it can be safely restored when needed.

Likewise, when popping an object from lua Queue class, the object is
restored at the top of the stack via its reference id.

However, once the object is restored the related queue entry is removed,
thus the object reference must be dropped to prevent reference leak.
This commit is contained in:
Aurelien DARRAGON 2023-05-10 19:47:08 +02:00 committed by Christopher Faulet
parent bd8a94a759
commit c0af7cdba2
1 changed files with 5 additions and 0 deletions
Show Stats Download Patch File Download Diff File Expand all files Collapse all files

5
src/hlua_fcn.c
View File

@ -600,6 +600,11 @@ static int _hlua_queue_pop(lua_State *L, struct hlua_queue *queue)
/* push lua obj on the stack */
hlua_pushref(L, item->ref);
/* obj ref should be released right away since it was pushed
* on the stack and will not be used anymore
*/
hlua_unref(L, item->ref);
/* free the queue item */
pool_free(pool_head_hlua_queue, item);