mirrors/haproxy
1
0
Fork 0
mirror of https://git.haproxy.org/git/haproxy.git/ synced 2025-09-29 01:31:19 +02:00
Code Issues Projects Releases Wiki Activity

[BUG] counters: fix segfault on missing counters for a listener

Browse Source 
If a frontend does not set 'option socket-stats', a 'clear counters'
on the stats socket could segfault because li->counters is NULL. The
correct fix is to check for NULL before as this is a valid situation.
This commit is contained in:
Willy Tarreau 2009-10-05 00:45:38 +02:00
parent 6f61b21524
commit ba255bc3c8
1 changed files with 2 additions and 1 deletions
Show Stats Download Patch File Download Diff File Expand all files Collapse all files

3
src/dumpstats.c
View File

@ -317,7 +317,8 @@ int stats_sock_parse_request(struct stream_interface *si, char *line)
memset(&sv->counters, 0, sizeof(sv->counters)); memset(&sv->counters, 0, sizeof(sv->counters));
for (li = px->listen; li; li = li->next) for (li = px->listen; li; li = li->next)
memset(li->counters, 0, sizeof(*li->counters)); if (li->counters)
memset(li->counters, 0, sizeof(*li->counters));
} }
return 1; return 1;