From ba255bc3c889cf8dd31b941ede6f8603ce8f758e Mon Sep 17 00:00:00 2001 From: Willy Tarreau Date: Mon, 5 Oct 2009 00:45:38 +0200 Subject: [PATCH] [BUG] counters: fix segfault on missing counters for a listener If a frontend does not set 'option socket-stats', a 'clear counters' on the stats socket could segfault because li->counters is NULL. The correct fix is to check for NULL before as this is a valid situation. --- src/dumpstats.c | 3 ++- 1 file changed, 2 insertions(+), 1 deletion(-) diff --git a/src/dumpstats.c b/src/dumpstats.c index 1317cc080..f59bf9071 100644 --- a/src/dumpstats.c +++ b/src/dumpstats.c @@ -317,7 +317,8 @@ int stats_sock_parse_request(struct stream_interface *si, char *line) memset(&sv->counters, 0, sizeof(sv->counters)); for (li = px->listen; li; li = li->next) - memset(li->counters, 0, sizeof(*li->counters)); + if (li->counters) + memset(li->counters, 0, sizeof(*li->counters)); } return 1;