mirrors/haproxy
1
0
Fork 0
mirror of https://git.haproxy.org/git/haproxy.git/ synced 2025-09-23 06:41:32 +02:00
Code Issues Projects Releases Wiki Activity

BUG/MEDIUM: resolvers: Don't set an address-less server as UP

Browse Source 
when a server status is updated based on a SRV item, it is always set to UP,
regardless it has an IP address defined or not. For instance, if only a SRV
item is received, with no additional record, only the server hostname is
defined. We must wait to have an IP address to set the server as UP.

This patch must be backported as far as 2.2.
This commit is contained in:
Christopher Faulet 2021-03-10 15:34:52 +01:00
parent bca680ba90
commit ab177ac1f3
1 changed files with 2 additions and 2 deletions
Show Stats Download Patch File Download Diff File Expand all files Collapse all files

4
src/resolvers.c
View File

@ -659,8 +659,8 @@ static void resolv_check_response(struct resolv_resolution *res)
send_log(srv->proxy, LOG_NOTICE, "%s", msg); send_log(srv->proxy, LOG_NOTICE, "%s", msg);
} }
/* now we have an IP address associated to this server, we can update its status */ /* Update the server status */
snr_update_srv_status(srv, 0); snr_update_srv_status(srv, (srv->addr.ss_family != AF_INET && srv->addr.ss_family != AF_INET6));
srv->svc_port = item->port; srv->svc_port = item->port;
srv->flags &= ~SRV_F_MAPPORTS; srv->flags &= ~SRV_F_MAPPORTS;