From ab177ac1f31b5c6c2e4f7d023923dd668cce3076 Mon Sep 17 00:00:00 2001 From: Christopher Faulet Date: Wed, 10 Mar 2021 15:34:52 +0100 Subject: [PATCH] BUG/MEDIUM: resolvers: Don't set an address-less server as UP when a server status is updated based on a SRV item, it is always set to UP, regardless it has an IP address defined or not. For instance, if only a SRV item is received, with no additional record, only the server hostname is defined. We must wait to have an IP address to set the server as UP. This patch must be backported as far as 2.2. --- src/resolvers.c | 4 ++-- 1 file changed, 2 insertions(+), 2 deletions(-) diff --git a/src/resolvers.c b/src/resolvers.c index 96431f47e..859189d1a 100644 --- a/src/resolvers.c +++ b/src/resolvers.c @@ -659,8 +659,8 @@ static void resolv_check_response(struct resolv_resolution *res) send_log(srv->proxy, LOG_NOTICE, "%s", msg); } - /* now we have an IP address associated to this server, we can update its status */ - snr_update_srv_status(srv, 0); + /* Update the server status */ + snr_update_srv_status(srv, (srv->addr.ss_family != AF_INET && srv->addr.ss_family != AF_INET6)); srv->svc_port = item->port; srv->flags &= ~SRV_F_MAPPORTS;