mirrors/haproxy
1
0
Fork 0
mirror of https://git.haproxy.org/git/haproxy.git/ synced 2025-09-23 06:41:32 +02:00
Code Issues Projects Releases Wiki Activity

MINOR: mux-quic: strengthen qcs_send_metadata() usage

Browse Source 
This function is reserved for QCS instance where no data was emitted.
A BUG_ON() ensures this by checking that streamdesc buf_list is empty.

However, this condition would not be enough if data were previously
emitted but already fully acknowledged. Thus, extend the condition by
also checking the streamdesc ack_offset is 0.
This commit is contained in:
Amaury Denoyelle 2024-10-01 16:17:03 +02:00
parent fdc16c1e01
commit 12782da020
1 changed files with 1 additions and 1 deletions
Show Stats Download Patch File Download Diff File Expand all files Collapse all files

2
src/mux_quic.c
View File

@ -737,7 +737,7 @@ void qcs_send_metadata(struct qcs *qcs)
/* Reserved for stream with Tx capability. */ /* Reserved for stream with Tx capability. */
BUG_ON(!qcs->stream); BUG_ON(!qcs->stream);
/* Cannot use if some data already transferred for this stream. */ /* Cannot use if some data already transferred for this stream. */
BUG_ON(!LIST_ISEMPTY(&qcs->stream->buf_list)); BUG_ON(qcs->stream->ack_offset || !LIST_ISEMPTY(&qcs->stream->buf_list));
qcs->stream->flags |= QC_SD_FL_OOB_BUF; qcs->stream->flags |= QC_SD_FL_OOB_BUF;
} }