From 12782da020d2f31d84659ad5964f9618ea13ca11 Mon Sep 17 00:00:00 2001 From: Amaury Denoyelle Date: Tue, 1 Oct 2024 16:17:03 +0200 Subject: [PATCH] MINOR: mux-quic: strengthen qcs_send_metadata() usage This function is reserved for QCS instance where no data was emitted. A BUG_ON() ensures this by checking that streamdesc buf_list is empty. However, this condition would not be enough if data were previously emitted but already fully acknowledged. Thus, extend the condition by also checking the streamdesc ack_offset is 0. --- src/mux_quic.c | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/src/mux_quic.c b/src/mux_quic.c index af03eb881..630e98bbc 100644 --- a/src/mux_quic.c +++ b/src/mux_quic.c @@ -737,7 +737,7 @@ void qcs_send_metadata(struct qcs *qcs) /* Reserved for stream with Tx capability. */ BUG_ON(!qcs->stream); /* Cannot use if some data already transferred for this stream. */ - BUG_ON(!LIST_ISEMPTY(&qcs->stream->buf_list)); + BUG_ON(qcs->stream->ack_offset || !LIST_ISEMPTY(&qcs->stream->buf_list)); qcs->stream->flags |= QC_SD_FL_OOB_BUF; }