mirror of
https://github.com/flatcar/scripts.git
synced 2026-01-08 18:12:17 +01:00
As-is safe_umount is extremely dangerous. When passed multiple mount points and any one of them fail with a "not mounted" or "doesn't exist" error then any others that fail with a more serious error will be silently ignored. This can cause untold sadness when running deleting a chroot with cros_sdk if /mnt/host/source is left mounted, all your code will be gone. To avoid this situation remove *ALL* this extra logic and die very loudly when umount fails. Due to the way bind mounts interact with this code "not mounted" so when unmounting a full tree we need to still need to gracefully retry when the first umount fails.
Description
Languages
Shell
93%
Python
6.9%