The problem here is that most were doing their exiting w/in a subshell;
exit within a subshell kills the subshell, not the parent. Not all scripts
were using set -e (which would pick up the failing subshell); as such
just rewriting them to remove the potential via eliminateing the subshelling.
Beyond that, removed a couple of custom (working, although non-standard)
approaches, and removed a duplicate common.sh sourc'ing w/in mk_memento_images.sh
TEST=force 'find_common_sh' to fail, note the scripts fails to exit
BUG=none
Change-Id: Ia1108a091a6399ad6aedd3cade4a107f4411686c
Reviewed-on: http://gerrit.chromium.org/gerrit/3905
Reviewed-by: Brian Harring <ferringb@chromium.org>
Tested-by: Brian Harring <ferringb@chromium.org>
The messages printed out by the code that checks if chromium's libcros and the system's libcros are
in sync were kind of confusing and not quite accurate. The system library implements a range of API
versions, and it is chromium that requires a particular version of the API. The messages now clearly
reflect this.
BUG=None
TEST=manual
Change-Id: I7308d7eb724edfb7fa11edbe0fbec86ee12c5afe
Reviewed-on: http://gerrit.chromium.org/gerrit/1136
Reviewed-by: David James <davidjames@chromium.org>
Tested-by: Chris Masone <cmasone@chromium.org>
This is needed for eliminating the dependency between chromeos-chrome and libcros.
This also has the benefit that builds will fail if you take a binary version of
chromeos-chrome with an incompatible version of libcros.
BUG=chromium-os:15145, chromium-os:15148
TEST=build_packages --nousepkg && build_image.
Test that test_image fails when libcros version is wrong.
Change-Id: I46cbc4494d36b13ba1bdda699eccb6dc7fea162c
Reviewed-on: http://gerrit.chromium.org/gerrit/633
Reviewed-by: Zdenek Behan <zbehan@chromium.org>
Reviewed-by: David James <davidjames@chromium.org>
Tested-by: David James <davidjames@chromium.org>
