mirror of
https://github.com/flatcar/scripts.git
synced 2025-09-23 22:51:03 +02:00
Move libcros check from chromeos-chrome into test_build_root.
This is needed for eliminating the dependency between chromeos-chrome and libcros. This also has the benefit that builds will fail if you take a binary version of chromeos-chrome with an incompatible version of libcros. BUG=chromium-os:15145, chromium-os:15148 TEST=build_packages --nousepkg && build_image. Test that test_image fails when libcros version is wrong. Change-Id: I46cbc4494d36b13ba1bdda699eccb6dc7fea162c Reviewed-on: http://gerrit.chromium.org/gerrit/633 Reviewed-by: Zdenek Behan <zbehan@chromium.org> Reviewed-by: David James <davidjames@chromium.org> Tested-by: David James <davidjames@chromium.org>
This commit is contained in:
parent
6eaddfef05
commit
f86703dd5d
@ -227,6 +227,9 @@ emerge_to_image() {
|
||||
"$@" ${EMERGE_JOBS}
|
||||
}
|
||||
|
||||
# Check that the build root is sane.
|
||||
"${SCRIPTS_DIR}/test_build_root" --root="${BOARD_ROOT}"
|
||||
|
||||
# Freshen kernel with correct USE flags. This is a noop if we have
|
||||
# the right kernel prebuilt. Factory install uses USE="initramfs".
|
||||
# We don't allow building from source with the image as a target,
|
||||
|
118
test_build_root
Executable file
118
test_build_root
Executable file
@ -0,0 +1,118 @@
|
||||
#!/bin/bash
|
||||
|
||||
# Copyright (c) 2010 The Chromium OS Authors. All rights reserved.
|
||||
# Use of this source code is governed by a BSD-style license that can be
|
||||
# found in the LICENSE file.
|
||||
|
||||
# --- BEGIN COMMON.SH BOILERPLATE ---
|
||||
# Load common CrOS utilities. Inside the chroot this file is installed in
|
||||
# /usr/lib/crosutils. Outside the chroot we find it relative to the script's
|
||||
# location.
|
||||
find_common_sh() {
|
||||
local common_paths=(/usr/lib/crosutils $(dirname "$(readlink -f "$0")"))
|
||||
local path
|
||||
|
||||
SCRIPT_ROOT=
|
||||
for path in "${common_paths[@]}"; do
|
||||
if [ -r "${path}/common.sh" ]; then
|
||||
SCRIPT_ROOT=${path}
|
||||
break
|
||||
fi
|
||||
done
|
||||
}
|
||||
|
||||
find_common_sh
|
||||
. "${SCRIPT_ROOT}/common.sh" || (echo "Unable to load common.sh" && exit 1)
|
||||
# --- END COMMON.SH BOILERPLATE ---
|
||||
|
||||
# Flags
|
||||
DEFINE_string root "" \
|
||||
"The root file system to check."
|
||||
|
||||
# Parse command line
|
||||
FLAGS "$@" || exit 1
|
||||
eval set -- "${FLAGS_ARGV}"
|
||||
|
||||
# Die on any errors
|
||||
set -e
|
||||
|
||||
# Check all parts of a pipe
|
||||
set -o pipefail
|
||||
|
||||
ROOT="$FLAGS_root"
|
||||
if [[ ! -d "$ROOT" ]]; then
|
||||
echo "Error: Root FS does not exist ($ROOT)"
|
||||
exit 1
|
||||
fi
|
||||
|
||||
BINARIES="$ROOT/usr/bin/Xorg
|
||||
$ROOT/usr/bin/chromeos-wm
|
||||
$ROOT/boot/vmlinuz
|
||||
$ROOT/sbin/session_manager
|
||||
$ROOT/bin/sed
|
||||
$ROOT/opt/google/chrome/chrome"
|
||||
|
||||
EXITCODE=0
|
||||
for i in $BINARIES; do
|
||||
if ! [[ -f $i ]]; then
|
||||
echo test_build_root: Cannot find $i
|
||||
EXITCODE=1
|
||||
fi
|
||||
done
|
||||
|
||||
# Extract the version number from lines like:
|
||||
# kCrosAPIMinVersion = 29,
|
||||
# kCrosAPIVersion = 30
|
||||
extract_cros_version() {
|
||||
NAME="$1"
|
||||
FILE="$2"
|
||||
VERSION=$(perl -ne "print \$1 if /^\\s*${NAME}\\s*=\\s*(\\d+)/" "$FILE")
|
||||
test -z "$VERSION" && die "Failed to get $NAME from $FILE"
|
||||
echo $VERSION
|
||||
}
|
||||
|
||||
# Check the libcros version compatibility, like we do in libcros at run time.
|
||||
# See also platform/cros/version_check.cc and load.cc.
|
||||
check_cros_version() {
|
||||
CHROME_CROS="${ROOT}/opt/google/chrome/include/chromeos_cros_api.h"
|
||||
SYSTEM_CROS="${ROOT}/usr/include/cros/chromeos_cros_api.h"
|
||||
|
||||
if [ ! -f "$SYSTEM_CROS" ]; then
|
||||
echo "test_build_root: Missing libcros headers."
|
||||
return 1
|
||||
fi
|
||||
|
||||
|
||||
if [ ! -f "$CHROME_CROS" ]; then
|
||||
# For compatiblity with old versions of Chrome which don't install headers
|
||||
# and already check the libcros version, skip the check here.
|
||||
return 0
|
||||
fi
|
||||
|
||||
# Get the version of libcros in the chromium tree.
|
||||
VERSION=$(extract_cros_version kCrosAPIVersion "${CHROME_CROS}")
|
||||
|
||||
# Get the min version of libcros in the chromium os tree.
|
||||
MIN_VERSION=$(extract_cros_version kCrosAPIMinVersion "${SYSTEM_CROS}")
|
||||
|
||||
# Get the max version of libcros in the chromium os tree.
|
||||
MAX_VERSION=$(extract_cros_version kCrosAPIVersion "${SYSTEM_CROS}")
|
||||
|
||||
if [ "$MIN_VERSION" -gt "$VERSION" ]; then
|
||||
echo "test_build_root: System libcros not compatible with Chromium."
|
||||
echo "Chromium has version $VERSION, but system requires $MIN_VERSION or"
|
||||
echo "later."
|
||||
return 1
|
||||
fi
|
||||
if [ "$VERSION" -gt "$MAX_VERSION" ]; then
|
||||
echo "test_build_root: System libcros not compatible with Chromium headers."
|
||||
echo "Chromium has version $VERSION, but system requires $MAX_VERSION or"
|
||||
echo "earlier."
|
||||
return 1
|
||||
fi
|
||||
return 0
|
||||
}
|
||||
|
||||
check_cros_version || EXITCODE=1
|
||||
|
||||
exit $EXITCODE
|
Loading…
x
Reference in New Issue
Block a user