Besides changing a lot of _ to not _, I added lots of docstrings, moved things around,
factored out the Marking component of the EBuildStableMarker (for use with other CL),
and fixed the version logic.
The versioning logic was too hacktastic. So I took a note from David's changes to
take the information from pkgsplit rather than doing the ugly parsing I was doing before.
This is much more robust in the case of no _r*'s and _rc or _alpha*, etc.
This CL also adds the ability to test Push changes in 2 ways. One using --dryrun which allows someone to call it by not actually push to the remote server and two, a unit test for the Push method.
Used in http://codereview.chromium.org/4798001/
BUG=chromiumos:8693
TEST=Ran unit tests and chrome mark as stable. Will run some more tests.
Committed: http://chrome-svn/viewvc/chromeos?view=rev&revision=be485ce
Review URL: http://codereview.chromium.org/5172003
Change-Id: I6d1231c6f46d8cc2e5fb57d04f2d3417cfbfb4f8
Besides changing a lot of _ to not _, I added lots of docstrings, moved things around,
factored out the Marking component of the EBuildStableMarker (for use with other CL),
and fixed the version logic.
The versioning logic was too hacktastic. So I took a note from David's changes to
take the information from pkgsplit rather than doing the ugly parsing I was doing before.
This is much more robust in the case of no _r*'s and _rc or _alpha*, etc.
This CL also adds the ability to test Push changes in 2 ways. One using --dryrun which allows someone to call it by not actually push to the remote server and two, a unit test for the Push method.
Used in http://codereview.chromium.org/4798001/
BUG=chromiumos:8693
TEST=Ran unit tests and chrome mark as stable. Will run some more tests.
Review URL: http://codereview.chromium.org/5172003
Change-Id: I4319dcd3a4235474ecfd61c680a5242bab5bd00b
Besides changing a lot of _ to not _, I added lots of docstrings, moved things around,
factored out the Marking component of the EBuildStableMarker (for use with other CL),
and fixed the version logic.
The versioning logic was too hacktastic. So I took a note from David's changes to
take the information from pkgsplit rather than doing the ugly parsing I was doing before.
This is much more robust in the case of no _r*'s and _rc or _alpha*, etc.
Used in http://codereview.chromium.org/4798001/
BUG=chromiumos:8693
TEST=Ran unit tests and chrome mark as stable. Will run some more tests.
Review URL: http://codereview.chromium.org/5172003
Change-Id: Id6ef9a480591d1a28352f360c6d076564b43e318
Change-Id: I413d21dd60ce822af65d5c7c22fd2dba67858d43
BUG=6113
TEST=Ran unit tests and also created my own 9999 ebuild and ran with --all and
saw 0.0.1-r1.ebuild get created in stabilizing_branch
Review URL: http://codereview.chromium.org/4449001
What's new?
- cros_mark_all_as_stable is now in Python and has unit tests.
- We now detect and report coding errors that can cause incorrect behavior.
E.g., if 9999 ebuild or stable ebuild can't be found, we report a hard
failure so that developers will know about the problem.
- We now check that git hashes we report actually match up with the
right repository.
- Unified diff of changes are now printed to stdout, so that developers
can see a list of the changes and debug any problems.
- cros_mark_all_as_stable now takes 2.5 seconds to run.
BUG=chromium-os:7795
TEST=Manually examined diff output from run of cros_mark_all_as_stable
on full repository.
Change-Id: I762597c9b94e5f8e8171b83c966ad54e21a65c1b
Review URL: http://codereview.chromium.org/3798003
cros_mark_as_stable.py was updated on Sep 8, but the unit test was not updated
to match. This patch fixes the unit test.
BUG=chromium-os:7586
TEST=Ran unit test.
Change-Id: I283ef33e172a95efc41b4090dc4f67c9d84dd9a3
Review URL: http://codereview.chromium.org/3682003
Code was changed to add a CR. Fix tests to accomodate.
BUG=5258
TEST=Unittests pass again.
Change-Id: Iacdbffb14d14f60a43883db3ee12b99a5eeb9f65
Review URL: http://codereview.chromium.org/3014045
