mirror of
https://github.com/flatcar/scripts.git
synced 2025-08-08 05:26:58 +02:00
6be0f08169
What's new?
- cros_mark_all_as_stable is now in Python and has unit tests.
- We now detect and report coding errors that can cause incorrect behavior.
E.g., if 9999 ebuild or stable ebuild can't be found, we report a hard
failure so that developers will know about the problem.
- We now check that git hashes we report actually match up with the
right repository.
- Unified diff of changes are now printed to stdout, so that developers
can see a list of the changes and debug any problems.
- cros_mark_all_as_stable now takes 2.5 seconds to run.
BUG=chromium-os:7795
TEST=Manually examined diff output from run of cros_mark_all_as_stable
on full repository.
Change-Id: I762597c9b94e5f8e8171b83c966ad54e21a65c1b
Review URL: http://codereview.chromium.org/3798003
307 lines
12 KiB
Python
Executable File
307 lines
12 KiB
Python
Executable File
#!/usr/bin/python
|
|
|
|
# Copyright (c) 2010 The Chromium OS Authors. All rights reserved.
|
|
# Use of this source code is governed by a BSD-style license that can be
|
|
# found in the LICENSE file.
|
|
|
|
"""Unit tests for cros_mark_as_stable.py."""
|
|
|
|
|
|
import mox
|
|
import os
|
|
import sys
|
|
import unittest
|
|
|
|
# Required to include '.' in the python path.
|
|
sys.path.append(os.path.dirname(__file__))
|
|
import cros_mark_as_stable
|
|
|
|
class GitBranchTest(mox.MoxTestBase):
|
|
|
|
def setUp(self):
|
|
mox.MoxTestBase.setUp(self)
|
|
# Always stub RunCommmand out as we use it in every method.
|
|
self.mox.StubOutWithMock(cros_mark_as_stable, '_SimpleRunCommand')
|
|
self._branch = 'test_branch'
|
|
|
|
def testCreateBranchNoPrevious(self):
|
|
# Test init with no previous branch existing.
|
|
branch = cros_mark_as_stable._GitBranch(self._branch)
|
|
self.mox.StubOutWithMock(branch, 'Exists')
|
|
self.mox.StubOutWithMock(branch, '_Checkout')
|
|
branch.Exists().AndReturn(False)
|
|
branch._Checkout(self._branch)
|
|
self.mox.ReplayAll()
|
|
branch.CreateBranch()
|
|
self.mox.VerifyAll()
|
|
|
|
def testCreateBranchWithPrevious(self):
|
|
# Test init with previous branch existing.
|
|
branch = cros_mark_as_stable._GitBranch(self._branch)
|
|
self.mox.StubOutWithMock(branch, 'Exists')
|
|
self.mox.StubOutWithMock(branch, 'Delete')
|
|
self.mox.StubOutWithMock(branch, '_Checkout')
|
|
branch.Exists().AndReturn(True)
|
|
branch.Delete()
|
|
branch._Checkout(self._branch)
|
|
self.mox.ReplayAll()
|
|
branch.CreateBranch()
|
|
self.mox.VerifyAll()
|
|
|
|
def testCheckoutCreate(self):
|
|
# Test init with no previous branch existing.
|
|
cros_mark_as_stable._SimpleRunCommand(
|
|
'git checkout -b %s cros/master' % self._branch)
|
|
self.mox.ReplayAll()
|
|
branch = cros_mark_as_stable._GitBranch(self._branch)
|
|
branch._Checkout(self._branch)
|
|
self.mox.VerifyAll()
|
|
|
|
def testCheckoutNoCreate(self):
|
|
# Test init with previous branch existing.
|
|
cros_mark_as_stable._SimpleRunCommand('git checkout cros/master')
|
|
self.mox.ReplayAll()
|
|
branch = cros_mark_as_stable._GitBranch(self._branch)
|
|
branch._Checkout('cros/master', False)
|
|
self.mox.VerifyAll()
|
|
|
|
def testDelete(self):
|
|
branch = cros_mark_as_stable._GitBranch(self._branch)
|
|
self.mox.StubOutWithMock(branch, '_Checkout')
|
|
branch._Checkout('cros/master', create=False)
|
|
cros_mark_as_stable._SimpleRunCommand('git branch -D ' + self._branch)
|
|
self.mox.ReplayAll()
|
|
branch.Delete()
|
|
self.mox.VerifyAll()
|
|
|
|
def testExists(self):
|
|
branch = cros_mark_as_stable._GitBranch(self._branch)
|
|
|
|
# Test if branch exists that is created
|
|
cros_mark_as_stable._SimpleRunCommand('git branch').AndReturn(
|
|
'%s %s' % (self._branch, 'cros/master'))
|
|
self.mox.ReplayAll()
|
|
self.assertTrue(branch.Exists())
|
|
self.mox.VerifyAll()
|
|
|
|
|
|
class EBuildTest(mox.MoxTestBase):
|
|
|
|
def setUp(self):
|
|
mox.MoxTestBase.setUp(self)
|
|
|
|
def testInit(self):
|
|
self.mox.StubOutWithMock(cros_mark_as_stable._EBuild, '_ParseEBuildPath')
|
|
|
|
ebuild_path = '/overlay/cat/test_package/test_package-0.0.1-r1.ebuild'
|
|
cros_mark_as_stable._EBuild._ParseEBuildPath(
|
|
ebuild_path).AndReturn(['/overlay/cat/test_package-0.0.1',
|
|
'/overlay/cat/test_package',
|
|
1])
|
|
self.mox.StubOutWithMock(cros_mark_as_stable.fileinput, 'input')
|
|
mock_file = ['EAPI=2', 'CROS_WORKON_COMMIT=old_id',
|
|
'KEYWORDS=\"~x86 ~arm\"', 'src_unpack(){}']
|
|
cros_mark_as_stable.fileinput.input(ebuild_path).AndReturn(mock_file)
|
|
|
|
self.mox.ReplayAll()
|
|
ebuild = cros_mark_as_stable._EBuild(ebuild_path)
|
|
self.mox.VerifyAll()
|
|
self.assertEquals(ebuild.package, 'cat/test_package')
|
|
self.assertEquals(ebuild.ebuild_path, ebuild_path)
|
|
self.assertEquals(ebuild.ebuild_path_no_revision,
|
|
'/overlay/cat/test_package-0.0.1')
|
|
self.assertEquals(ebuild.ebuild_path_no_version,
|
|
'/overlay/cat/test_package')
|
|
self.assertEquals(ebuild.current_revision, 1)
|
|
|
|
def testParseEBuildPath(self):
|
|
# Test with ebuild with revision number.
|
|
no_rev, no_version, revision = cros_mark_as_stable._EBuild._ParseEBuildPath(
|
|
'/path/test_package-0.0.1-r1.ebuild')
|
|
self.assertEquals(no_rev, '/path/test_package-0.0.1')
|
|
self.assertEquals(no_version, '/path/test_package')
|
|
self.assertEquals(revision, 1)
|
|
|
|
def testParseEBuildPathNoRevisionNumber(self):
|
|
# Test with ebuild without revision number.
|
|
no_rev, no_version, revision = cros_mark_as_stable._EBuild._ParseEBuildPath(
|
|
'/path/test_package-0.0.1.ebuild')
|
|
self.assertEquals(no_rev, '/path/test_package-0.0.1')
|
|
self.assertEquals(no_version, '/path/test_package')
|
|
self.assertEquals(revision, 0)
|
|
|
|
|
|
class EBuildStableMarkerTest(mox.MoxTestBase):
|
|
|
|
def setUp(self):
|
|
mox.MoxTestBase.setUp(self)
|
|
self.mox.StubOutWithMock(cros_mark_as_stable, '_SimpleRunCommand')
|
|
self.mox.StubOutWithMock(cros_mark_as_stable, 'RunCommand')
|
|
self.mox.StubOutWithMock(os, 'unlink')
|
|
self.m_ebuild = self.mox.CreateMock(cros_mark_as_stable._EBuild)
|
|
self.m_ebuild.package = 'test_package'
|
|
self.m_ebuild.current_revision = 1
|
|
self.m_ebuild.ebuild_path_no_revision = '/path/test_package-0.0.1'
|
|
self.m_ebuild.ebuild_path_no_version = '/path/test_package'
|
|
self.m_ebuild.ebuild_path = '/path/test_package-0.0.1-r1.ebuild'
|
|
self.revved_ebuild_path = '/path/test_package-0.0.1-r2.ebuild'
|
|
|
|
def testRevEBuild(self):
|
|
self.mox.StubOutWithMock(cros_mark_as_stable.fileinput, 'input')
|
|
self.mox.StubOutWithMock(cros_mark_as_stable.os.path, 'exists')
|
|
self.mox.StubOutWithMock(cros_mark_as_stable.shutil, 'copyfile')
|
|
m_file = self.mox.CreateMock(file)
|
|
|
|
# Prepare mock fileinput. This tests to make sure both the commit id
|
|
# and keywords are changed correctly.
|
|
mock_file = ['EAPI=2', 'CROS_WORKON_COMMIT=old_id',
|
|
'KEYWORDS=\"~x86 ~arm\"', 'src_unpack(){}']
|
|
|
|
ebuild_9999 = self.m_ebuild.ebuild_path_no_version + '-9999.ebuild'
|
|
cros_mark_as_stable.os.path.exists(ebuild_9999).AndReturn(True)
|
|
cros_mark_as_stable.shutil.copyfile(ebuild_9999, self.revved_ebuild_path)
|
|
cros_mark_as_stable.fileinput.input(self.revved_ebuild_path,
|
|
inplace=1).AndReturn(mock_file)
|
|
m_file.write('EAPI=2')
|
|
m_file.write('CROS_WORKON_COMMIT="my_id"\n')
|
|
m_file.write('KEYWORDS="x86 arm"')
|
|
m_file.write('src_unpack(){}')
|
|
diff_cmd = ['diff', '-Bu', self.m_ebuild.ebuild_path,
|
|
self.revved_ebuild_path]
|
|
cros_mark_as_stable.RunCommand(diff_cmd, exit_code=True,
|
|
print_cmd=False).AndReturn(1)
|
|
cros_mark_as_stable._SimpleRunCommand('git add ' + self.revved_ebuild_path)
|
|
cros_mark_as_stable._SimpleRunCommand('git rm ' + self.m_ebuild.ebuild_path)
|
|
|
|
self.mox.ReplayAll()
|
|
marker = cros_mark_as_stable.EBuildStableMarker(self.m_ebuild)
|
|
marker.RevEBuild('my_id', redirect_file=m_file)
|
|
self.mox.VerifyAll()
|
|
|
|
def testRevUnchangedEBuild(self):
|
|
self.mox.StubOutWithMock(cros_mark_as_stable.fileinput, 'input')
|
|
self.mox.StubOutWithMock(cros_mark_as_stable.os.path, 'exists')
|
|
self.mox.StubOutWithMock(cros_mark_as_stable.shutil, 'copyfile')
|
|
m_file = self.mox.CreateMock(file)
|
|
|
|
# Prepare mock fileinput. This tests to make sure both the commit id
|
|
# and keywords are changed correctly.
|
|
mock_file = ['EAPI=2', 'CROS_WORKON_COMMIT=old_id',
|
|
'KEYWORDS=\"~x86 ~arm\"', 'src_unpack(){}']
|
|
|
|
ebuild_9999 = self.m_ebuild.ebuild_path_no_version + '-9999.ebuild'
|
|
cros_mark_as_stable.os.path.exists(ebuild_9999).AndReturn(True)
|
|
cros_mark_as_stable.shutil.copyfile(ebuild_9999, self.revved_ebuild_path)
|
|
cros_mark_as_stable.fileinput.input(self.revved_ebuild_path,
|
|
inplace=1).AndReturn(mock_file)
|
|
m_file.write('EAPI=2')
|
|
m_file.write('CROS_WORKON_COMMIT="my_id"\n')
|
|
m_file.write('KEYWORDS="x86 arm"')
|
|
m_file.write('src_unpack(){}')
|
|
diff_cmd = ['diff', '-Bu', self.m_ebuild.ebuild_path,
|
|
self.revved_ebuild_path]
|
|
cros_mark_as_stable.RunCommand(diff_cmd, exit_code=True,
|
|
print_cmd=False).AndReturn(0)
|
|
cros_mark_as_stable.os.unlink(self.revved_ebuild_path)
|
|
|
|
self.mox.ReplayAll()
|
|
marker = cros_mark_as_stable.EBuildStableMarker(self.m_ebuild)
|
|
marker.RevEBuild('my_id', redirect_file=m_file)
|
|
self.mox.VerifyAll()
|
|
|
|
def testRevMissingEBuild(self):
|
|
self.mox.StubOutWithMock(cros_mark_as_stable.fileinput, 'input')
|
|
self.mox.StubOutWithMock(cros_mark_as_stable.os.path, 'exists')
|
|
self.mox.StubOutWithMock(cros_mark_as_stable.shutil, 'copyfile')
|
|
self.mox.StubOutWithMock(cros_mark_as_stable, 'Die')
|
|
m_file = self.mox.CreateMock(file)
|
|
|
|
# Prepare mock fileinput. This tests to make sure both the commit id
|
|
# and keywords are changed correctly.
|
|
mock_file = ['EAPI=2', 'CROS_WORKON_COMMIT=old_id',
|
|
'KEYWORDS=\"~x86 ~arm\"', 'src_unpack(){}']
|
|
|
|
ebuild_9999 = self.m_ebuild.ebuild_path_no_version + '-9999.ebuild'
|
|
cros_mark_as_stable.os.path.exists(ebuild_9999).AndReturn(False)
|
|
cros_mark_as_stable.Die("Missing 9999 ebuild: %s" % ebuild_9999)
|
|
cros_mark_as_stable.shutil.copyfile(ebuild_9999, self.revved_ebuild_path)
|
|
cros_mark_as_stable.fileinput.input(self.revved_ebuild_path,
|
|
inplace=1).AndReturn(mock_file)
|
|
m_file.write('EAPI=2')
|
|
m_file.write('CROS_WORKON_COMMIT="my_id"\n')
|
|
m_file.write('KEYWORDS="x86 arm"')
|
|
m_file.write('src_unpack(){}')
|
|
diff_cmd = ['diff', '-Bu', self.m_ebuild.ebuild_path,
|
|
self.revved_ebuild_path]
|
|
cros_mark_as_stable.RunCommand(diff_cmd, exit_code=True,
|
|
print_cmd=False).AndReturn(1)
|
|
cros_mark_as_stable._SimpleRunCommand('git add ' + self.revved_ebuild_path)
|
|
cros_mark_as_stable._SimpleRunCommand('git rm ' + self.m_ebuild.ebuild_path)
|
|
|
|
self.mox.ReplayAll()
|
|
marker = cros_mark_as_stable.EBuildStableMarker(self.m_ebuild)
|
|
marker.RevEBuild('my_id', redirect_file=m_file)
|
|
self.mox.VerifyAll()
|
|
|
|
|
|
def testCommitChange(self):
|
|
mock_message = 'Commit me'
|
|
cros_mark_as_stable._SimpleRunCommand(
|
|
'git commit -am "%s"' % mock_message)
|
|
self.mox.ReplayAll()
|
|
marker = cros_mark_as_stable.EBuildStableMarker(self.m_ebuild)
|
|
marker.CommitChange(mock_message)
|
|
self.mox.VerifyAll()
|
|
|
|
def testPushChange(self):
|
|
#cros_mark_as_stable._SimpleRunCommand('git push')
|
|
#self.mox.ReplayAll()
|
|
#marker = cros_mark_as_stable.EBuildStableMarker(self.m_ebuild)
|
|
#marker.PushChange()
|
|
#self.mox.VerifyAll()
|
|
pass
|
|
|
|
|
|
class _Package(object):
|
|
def __init__(self, package):
|
|
self.package = package
|
|
|
|
|
|
class BuildEBuildDictionaryTest(mox.MoxTestBase):
|
|
|
|
def setUp(self):
|
|
mox.MoxTestBase.setUp(self)
|
|
self.mox.StubOutWithMock(cros_mark_as_stable.os, 'walk')
|
|
self.mox.StubOutWithMock(cros_mark_as_stable, 'RunCommand')
|
|
self.package = 'chromeos-base/test_package'
|
|
self.root = '/overlay/chromeos-base/test_package'
|
|
self.package_path = self.root + '/test_package-0.0.1.ebuild'
|
|
paths = [[self.root, [], []]]
|
|
cros_mark_as_stable.os.walk("/overlay").AndReturn(paths)
|
|
self.mox.StubOutWithMock(cros_mark_as_stable, '_FindStableEBuilds')
|
|
|
|
|
|
def testWantedPackage(self):
|
|
overlays = {"/overlay": []}
|
|
package = _Package(self.package)
|
|
cros_mark_as_stable._FindStableEBuilds([]).AndReturn(package)
|
|
self.mox.ReplayAll()
|
|
cros_mark_as_stable._BuildEBuildDictionary(overlays, False, [self.package])
|
|
self.mox.VerifyAll()
|
|
self.assertEquals(len(overlays), 1)
|
|
self.assertEquals(overlays["/overlay"], [package])
|
|
|
|
def testUnwantedPackage(self):
|
|
overlays = {"/overlay": []}
|
|
package = _Package(self.package)
|
|
cros_mark_as_stable._FindStableEBuilds([]).AndReturn(package)
|
|
self.mox.ReplayAll()
|
|
cros_mark_as_stable._BuildEBuildDictionary(overlays, False, [])
|
|
self.assertEquals(len(overlays), 1)
|
|
self.assertEquals(overlays["/overlay"], [])
|
|
self.mox.VerifyAll()
|
|
|
|
|
|
if __name__ == '__main__':
|
|
unittest.main()
|