Commit Graph

329 Commits

Author SHA1 Message Date
Will Drewry
d07f61d812 build_image: enable Chrome OS partition/hardware error behavior in dm-verity
ARM (kernel-next) should now be in sync with kernel.git so that we get similar
error handling behavior on all targeted platforms (with our partition layout).

This change makes that the default.

BUG=chromium-os:9697
TEST=manual build_image with kernel-next profile; booted and validated failover error behavior

Change-Id: I281302adb3cbc96aa5770630898f103b0d3639ca

Review URL: http://codereview.chromium.org/6220002
2011-01-12 10:39:54 -06:00
David McMahon
48db5d2068 Moving chromeos_version.sh to chromiumos_overlay.
BUG=chromium-os:9714
TEST=

Review URL: http://codereview.chromium.org/5513009

Change-Id: Ib569fe59f4e14551b198568b24014208b5d65647
2010-12-14 16:19:24 -08:00
Raja Aluri
888e07c9c8 Adding missing test
Change-Id: I1bbb4b0b54632878bcebdf2fac9fcbe105e2d6cd

BUG=None
TEST=Ran build_image with empty directory.

Review URL: http://codereview.chromium.org/5781009
2010-12-14 10:36:34 -08:00
Thieu Le
171321f8ff Zero free space on rootfs so it's more compressible for auto-update
BUG=chromium-os:10228
TEST=Build image, install image to Mario, make sure image still boots

Change-Id: Idc3c2a929515d39cb06926611eff37960074889c

Review URL: http://codereview.chromium.org/5704004
2010-12-13 11:37:42 -08:00
Trevor Bourget
8e6abb04c6 scripts: repair build_image nostatefuldev collision
Change-Id: Ib9fcc078d8e0223cd1b1376db91d8e71ae8359a6

BUG=cp file to itself fails in case of nostatefuldev
TEST=ran build_image with and without statefuldev

Review URL: http://codereview.chromium.org/4959001
Patch from Trevor Bourget <tbourget@codeaurora.org>.
2010-12-13 09:44:32 -07:00
Raja Aluri
aeb1048742 Moving generating au-generator.zip file to build_image.
Change-Id: Id4ed6af96e0b621f4ad36966fad45c887b991373

BUG=None
TEST=Ran a fresh build_packages and build_image for x86-generic.

Review URL: http://codereview.chromium.org/5689004
2010-12-10 13:03:09 -08:00
Mandeep Singh Baines
4ea330f007 build_image: honor USE flags from environment
BUG=n0ne
TEST=Ran the following command to test:

USE="-compat_wireless" ./build_image

Change-Id: I4b3fd12c1f62e1b2551045a5831a63d848fe2a3f

Review URL: http://codereview.chromium.org/5139003
2010-11-17 18:11:58 -08:00
Will Drewry
226522a011 build_image: rollback default error behavior until kernel-next merge
kernel-next lacks error mode 3.  Rolling back until merged.

TEST=none: rolling back to old value
BUG=chromium-os:8442

Change-Id: I0c1a89dc3e00fe5f315b3c15c5070209b0fd79d0

Review URL: http://codereview.chromium.org/4512004
2010-11-05 20:20:47 -05:00
Will Drewry
137eab6129 build_image: enable new cros specific error handling in dm-verity
A new error mode for dm-verity exists which can be called as
"cros" or "3".  This change enables that mode in builds by default.

TEST=build_image had the correct argument; functionality was there [in progress]
BUG=chromium-os:8442

Change-Id: I3eb3f4a662c5d36011542af4e50718db50ab63bd

Review URL: http://codereview.chromium.org/4530003
2010-11-04 22:06:41 -05:00
Andrew de los Reyes
0eb6d764ad Rootfs: increase size to 850MiB.
BUG=not sure, but this is CL 2/2 to fix broken L13 build
TEST=tested usb intall/auto update

Change-Id: I14cdd1ec941a0653ac25ec7ef72f69f2ec8f64c9

Review URL: http://codereview.chromium.org/4270002
2010-11-01 18:27:53 -07:00
Chris Sosa
765db0f771 Add sed to remove path dependency for wget
Change-Id: Iecdea822e9600249a9596c059e4db980b409c0a0

BUG=8082
TEST=Built a vm image and ran sudo gmerge metrics

Review URL: http://codereview.chromium.org/4118001
2010-10-25 15:08:55 -07:00
Chris Sosa
e38f90f309 Add ability to blacklist packages from chromeos-base/chromeos.
Change-Id: I05370137dbe9f9adc7b18f2ff77d1b7680275c37

BUG=7973
TEST=Ran with/without current blacklist file.  Also, added chromeos-base/chromeos-chrome
to test it actually dies correctly.

Review URL: http://codereview.chromium.org/4005002
2010-10-20 16:04:23 -07:00
Will Drewry
55b42c94ca cros_make_image_bootable, mount_gpt_image, common.sh: root filesystem changes: ext2, ro by default
This change makes more of the root filesyste metadata static across builds, but
more can be done there.  It also changes the root filesystem to use ext2 as
we don't need journaling in normal mode.  Optionally we could use ext3 for
non-verified if desired (it's an easy change).

In particular, this change cleans up the following:
- clears the rootfs uuid
- labels it C-ROOT (instead of C-KEYFOB)
- removes reserved inodes and blocks

The major feature of this change, however, is that it adds two simple
helpers to common.sh: disable_rw_mount and enable_rw_mount.  They will
set high order byte (le) in the ro compat field to be 0xff.  This will
tell the kernel that the filesystem uses features R24-R31 which are safe
for use on the running kernel iff the filesystem is mounted read-only.

These functions are called in cros_make_image_bootable and
mount_gpt_image, respectively.  mount_gpt_image will always
enable_rw_mount and cros_make_image_bootable will disable_rw_mount if
--enable_rootfs_verification is true.

The approach is ugly but reasonably well contained.  If ext2 ever gets a
new revision and new features in the same range are introduced, then we
would be getting inconsistent behavior.  That said, it is unlikely that
that churmn will happen and if the impact is negative, it will ideally
show up during testing.

N.B., this will likely result in changes needing to be made to the
signing scripts in vboot_reference to ensure that rw mounting is
enabled/disabled in the same way (E.g., during stamping).

BUG=chromium-os:7468
TEST=- built x86-generic, imaged to usb stick, attempted to mount rw /dev/sdc3 on the host and was properly bounced.
     - booted to the image just fine on a dogfood device.
     - mod'd for recovery, then installed and booted.
     - mod_image_for_test runs with no errors; booted the resulting image as well
     - booted a factory_install with the pending dm changes
     - BVT passed with build_image x86-generic (vboot enabled)
     - [in progress] autotest that checks if the rootdev = /dev/dm-0 and
       then does a dumpe2fs | grep -q FEATURE_R31

Review URL: http://codereview.chromium.org/3916002

Change-Id: If4dcba7568a110f4e32627c916d9e5741e5e5414
2010-10-20 15:44:11 -05:00
Chris Sosa
6304adc473 Setup python symlinks for python on stateful partition.
Change-Id: Ifbfbd3b55ae97ea94ea5bba40a001c6a1ddbf7a0

BUG=720
TEST=Ran suite_Smoke in a VM and ran python from command line and checked
to see if I could import packages from /usr/local/site-packages.

Review URL: http://codereview.chromium.org/3972001
2010-10-20 13:40:33 -07:00
Will Drewry
32d8c11747 build_image & make_bootable: allow additional kernel cmdline args
In order to more easily test kernel commandline tweaks, ensure that
--boot_args is propagated to all kernel cmdline sinks.

This is useful for changing default schedulers and any other kernel argument
tweaks we may want to quickly test out.

TEST=build and tested x86-generic
BUG=none

Change-Id: I5138755aa8c5e32e7f117f18291d2ae197e95bef

Review URL: http://codereview.chromium.org/3644004
2010-10-11 15:37:17 -05:00
Will Drewry
52c40f8d35 build_image: fix verity defaults
This changes defaults failure to a panic/recovery reboot and
disables the debugging max_bios argument to ensure that we don't
trigger race conditions in the kernel during un-protected
pending_bio count decrements.  (Can lead to a hung-system.)

TEST=built x86-generic; ensured -1 and the panic changes worked
BUG=chromium-os:6956

Review URL: http://codereview.chromium.org/3595015

Change-Id: I81c9e1a7f406e551cd528d5226902c89165b30f9
2010-10-06 14:54:38 -05:00
Hung-Te Lin
2ffe2bed8b crosutils: refine imaging output message (as instructions)
image_to_usb has been made to work inside chroot for quite some time
(maybe since http://codereview.chromium.org/1991006), and some special
modes may even require it to be executed inside chroot.
However the output messages were not fixed, so we should remove the
"OUTSIDE CHROOT" alerts.

BUG=none
TEST=manually:
1. executed build_image and verified that output messages is correct, and the image is really built successfully.
2. executed image_to_usb.sh --from=... --to=/dev/sde and verified output messages is correct, and the USB device is really imaged by the given target

Change-Id: I8f4274c5f59a0aa585471469ac285e91c0cead13

Review URL: http://codereview.chromium.org/3519003
2010-10-05 08:15:40 +08:00
Kenneth Waters
e3049de00f build_image: Merge x86 and ARM where possible.
- I looked at all of the x86 and ARM paths through out build image scripts,
  these changes clean up stale comments, stale code, and unforks some small
  things.

BUG=none
TEST=Built images for x86-generic, arm-generic and tegra2-seaboard, booted tegra2-seaboard image.

Review URL: http://codereview.chromium.org/3448022

Change-Id: Ibad2774ff2cbf5f15528454506542b87e43e24a2
2010-09-30 14:20:34 -07:00
Kenneth Waters
ed54d93e2c build_image: Add verity support for ARM.
- Build a "kernel image" which contains a uboot script and a uboot kernel
  image.
- Fix some sd* assumptions.
- Remove cruft that has never done anything usefull from update_bootloaders

BUG=none
TEST=Built, booted, and updated on tegra2_dev-board

Review URL: http://codereview.chromium.org/3396011

Change-Id: I00ecf57faa5fe64c8e33dd4c042f1dbed806c10a
2010-09-21 10:29:54 -07:00
Paul Stewart
12973e562d Install make.globals and create make.profile directory
Some mod_for_test images don't have the files necessary to run
emerge.  Install them.

BUG=none
TEST=Rerun package install

Review URL: http://codereview.chromium.org/3351016
2010-09-09 20:04:11 -07:00
Anush Elangovan
bc2aaf67f8 Make factory emerge the virtual/kernel atom to support profile based kernel
This is dependent on http://codereview.chromium.org/3317012/show

Change-Id: Ifb6e7511619e9f2000448408dd800dd7043a7783

BUG=5847
TEST=new setupboard and build_packages/image for arm/x86-generic with the CL 3317012 included

Review URL: http://codereview.chromium.org/3328016
2010-09-09 19:40:30 -07:00
Tan Gao
74a07cac15 Issue 6577: remove confirmation to delete output directory
Change-Id: Ib19986121a8988c6cae23527148a7b5d4a58663e

BUG=chromium-os:6577
TEST=(inside chroot) run 4 test cases from src/scripts/, using Ctrl+C to force abort (hence triggering "delete_prompt")
a.) (stdin tty) "./build_image --board=x86-generic < /dev/null", expected = no prompt and delete output dir; actual == expected
b.) (stdout tty) "./build_image --board=x86-generic > foo.txt", expected = no prompt and delete output dir; actual == expected
c.) (normal user case) "./build_image --board=x86-generic",
expected = prompt to delete output dir, if y, output dir is removed; actual == expected
d.) (normal user case) "./build_image --board=x86-generic", expected = prompt to delete output dir, if N, output dir is NOT removed; actual == expected

Review URL: http://codereview.chromium.org/3373003
2010-09-09 11:41:30 -07:00
David James
ffede3b414 Use --usepkgonly in build_image to ensure no accidental builds of packages.
Historically, we used --usepkgonly in build_image to ensure that packages
were not accidentally built during this step. Recently, build_image was
updated to use --usepkg. The benefit of using --usepkg was that it would not
install obsolete binary packages to your image. It was counter-intuitive that
--usepkgonly would install packages to your image that are not actually
installed to your board root. The disadvantage, however, of --usepkg, was that
it sometimes tried to build packages afresh using the image as your build root,
and this failed with strange errors because you're not supposed to do that.

This change fixes build_image to give useful errors by switching back to
--usepkgonly. To fix the problem where --usepkgonly installs packages that are
not installed, we first run eclean-<board> to clean all unused packages from
the board root.

This change is a big improvement because a number of people have run into
strange issues with build_image due to this problem and have had trouble
debugging them.

This change was actually written by Sean Paul, and I am shepherding his change
through for him because he doesn't have a Chromium account yet.

BUG=chromium-os:6437
TEST=
 1) build_packages && build_image should still work
 2) build_packages && ./cros_workon start power_manager && build_image should
    fail with an error that all versions of the power manager are masked. This
    happens because you started working on the power manager, but did not build
    the version of the power manager you were working on before installing it.
 3) Assuming you are working on the power manager, build_packages && build_image
    should succeed because your cros_workon'd version of the package is built.
 4) ( ./cros_workon start power_manager && build_packages &&
      ./cros_workon stop power_manager && build_image ) should fail with the
    same error message as case 2 for similar reasons.
 5) ( ./cros_workon start power_manager && build_packages &&
      ./cros_workon stop power_manager && build_packages && build_image )
    should work because you've built your new version of the stable package.

Change-Id: Ia3858c70997bc6f0ec0b6d1bfaede8d3272a0976

Review URL: http://codereview.chromium.org/3305010
2010-09-07 14:22:38 -07:00
Nick Sanders
446c2115e4 Don't kill sdcards with boot_tries
USB/SDCard boot devices typicaly don't run software updater,
and won't have success ever set. We never want to try to
fall back to the empty B partition either. The workaround
for this is to set the successful bit regardless of actual
boot success.

bug=6395
Change-Id: I67c625804203b13be9a0c626c404fa38bafb5445

Review URL: http://codereview.chromium.org/3344008
2010-09-03 18:15:35 -07:00
Nick Sanders
ebce8543fc missed feedback from CL
Review URL: http://codereview.chromium.org/3323004
2010-09-02 14:57:34 -07:00
Nick Sanders
c8cb33699e Allow full build of factory install shim in build_image.
BUG=4951
TEST=Build and boot install shim on legacy bios, on H2C

Review URL: http://codereview.chromium.org/3140028
2010-09-01 21:31:30 -07:00
Nick Sanders
ae26a5cbbf * Combine partition setting
* Add dev-rec key to factory installer
* rename factory_install_shim output to be consistent with dev install shim

Change-Id: Ibf8f027edda67626af5c319b4daa164cb53ccfe7

BUG=4382
TEST=Build factory install, build dev install, build normal

Review URL: http://codereview.chromium.org/3286002
2010-08-30 21:59:50 -07:00
Olof Johansson
1f5e84d157 build_image: image_to_vm needs board arg
BUG=none
TEST=build_image + cut and paste image_to_vm in the output

Change-Id: I9def13a56d796c1f034c834a8429e909b45afa02

Review URL: http://codereview.chromium.org/3181038
2010-08-24 20:26:49 -05:00
Tan Gao
7b6d5036f5 Issue 5183: reduce dev install shim size
Change-Id: I7722848872b1712b26c38ac8f163d450c5a08f6d

BUG=chromium-os:5183
TEST=manually built a dev install shim and verified it's bootable on agz device

Review URL: http://codereview.chromium.org/3158021
2010-08-23 08:17:48 -07:00
Will Drewry
12f14ce889 build_image: default to using verified rootfs for x86
This change enables root filesystem integrity checking for all x86
builds by default.  All mod_image_for_* work with this and the
factory_install.  In addition, the BVT tests all pass running on
a dm-verity root.

[I will send a mail to the chromium-os-dev once this lands with instructions on how to build with it and how to turn it off (chromeos-setimage) on an installed machine.]

Once this is functioning, I will start migrating the build/install process over to use the UUID-based boot.

TEST=built x86-generic, mod'd for test, installed, ran suite_BuildVerify
BUG=chromium-os:5100

Review URL: http://codereview.chromium.org/3143025

Change-Id: Ib23962b7a5e034ef6aea31b4361944ba894700c6
2010-08-17 17:27:16 -05:00
Will Drewry
d253badb6c build_image: make sure the factory_image size is propagated
Verified rootfs-based factory installers fail because the ROOT_SIZE_BYTES is
updated, but the information is not propagated to the boot.desc which
cros_make_image_bootable uses.  The result is that mod_image_for_test
incorrectly appends the rootfs hash even though it is correctly computed.

Random note:
build_kernel_image uses dumpe2fs to compute the size, but
cros_make_image_bootable uses the supplied size.  These shouldn't
diverge though the partition size should accomodate the addition of the
hashes.
TODO(wad) Add checking of sizes in cros_make_image_bootable

TEST=x86-generic build image with --enable_rootfs_verification and --factory_install; then put in a machine and it no longer spewed dm-verity hash errors and the root hash checked successfully!
BUG=chromium-os:5100

Review URL: http://codereview.chromium.org/3155025

Change-Id: I174e3661b80d83b25f3af95ff1eb77f634a7e797
2010-08-17 14:09:41 -05:00
Tan Gao
843b70acf4 Issue 5183: Create a developer shim for release builds
Change-Id: I14cd9dc365093c0450210d7853ad5f67ffa0ddd0

BUG=chromium-os:5183
TEST=1) manually built a dev install shim and verified it's only bootable when dev switch is ON

Review URL: http://codereview.chromium.org/3153001
2010-08-17 09:41:48 -07:00
Ken Mixter
0d11563bfd Move leave_core where other similar files exist
BUG=5696

Review URL: http://codereview.chromium.org/3109014
2010-08-13 15:51:07 -07:00
Ken Mixter
1334788772 Leave core files around for developers to inspect.
BUG=5358

Review URL: http://codereview.chromium.org/3170008
2010-08-12 16:51:52 -07:00
Will Drewry
6793ba78ca build_image,cros_make_image_bootable: fix missing arm argument
Adds arm_extra_bootargs to boot.desc and to cros_make_image_bootable.

TEST=tegra2 dev-board build_packages, build_image --fast worked
BUG=broken tree

Change-Id: Ifdfeda66f1eb5e5b1e618706eeba269f31fa9913

Review URL: http://codereview.chromium.org/3069031
2010-08-05 16:17:46 -05:00
Will Drewry
7ab698d713 build_image, mod_image_for_*: break out make_image_bootable
Breaks make_image_bootable out of build_image into a separate
script.  In addition, it make a helper .sh in the OUTPUT_DIR
to let make_image_bootable be re-run on an image with the same
arguments that were passed in via build_image.

This change also removes the use of the boot/ directory in
OUTPUT_DIR.

TEST=build_image verified; image_to_usb --test_image; booted l13
           build_image; image_to_vm; qemu booted
           build_image verified; image_to_usb; booted l13
BUG=chromium-os:5081

Review URL: http://codereview.chromium.org/3066037

Change-Id: I627d678089aa71c353347f387ad5b14063fd4e7b
2010-08-05 13:57:52 -05:00
Olof Johansson
58f25cca72 Create a latest link to point at newest image
build_image creates it after a successful build, and get_latest_image
can use it if it exists. Fall back to old behavior for now when there
are directories without a link.

BUG=none
TEST=Try building an image, check link. Rebuild, check new link.

Review URL: http://codereview.chromium.org/3014051
2010-08-04 21:18:49 -07:00
David James
0366864a98 Enable fast build by default in build_image and mod_image_for_test.sh.
The fast build is stable enough now that we can enable it for everybody.
I ran the build constantly all weekend on two machines and I only ran into
one (rare) error, which I've fixed in a separate patch.

See <http://codereview.chromium.org/2856048/show>

TEST=Ran lots and lots of fast builds
BUG=none

Review URL: http://codereview.chromium.org/3059001
2010-07-28 17:08:29 -07:00
Nikita Kostylev
c8bba90ae4 Make oem_customization flag optional.
BUG=chromium-os:1888
TEST=Manual. build_image should run fine when oem_customization flag is not specified.

Review URL: http://codereview.chromium.org/3076009
2010-07-28 17:05:26 +04:00
Will Drewry
efce66880f image_to_vm: convert to calling setimage directly
The last changes to the installer broke image_to_vm.  Since image_to_vm
doesn't need to run postinst, but just change the active image, it
now just calls chromeos-setimage and passes in its needed flags (already
supported by the last installer change).  It will also detect whether
the image was built with verification of the rootfs enabled or not
by looking at the default.cfg file.

Also updates the location of where you should run the command in
build_image.

TEST=built a new image with --enable_rootfs_verification and started with qemu -curses -hda [output]; did the same without verification
BUG=chromium-os:2963

Review URL: http://codereview.chromium.org/3034030

Change-Id: I265d6ad8971f9427b78cc07d784fced9cceb5974
2010-07-23 19:43:27 -05:00
Will Drewry
9926ee2879 build_image: avoid losetup -c because older kernels seem to balk
Instead of resizing the loop device after adding padding for the
hash tree data.  Just ensure that the mkfs.ext3 call doesn't exceed
the rootfs size.

TEST=reran build_image on my lucid machine and checked the rootfs size; asked someone with hardy machine to test.
BUG=none

Change-Id: I59f95e1d17e35aca265bd44bb863da6069c05bd2

Review URL: http://codereview.chromium.org/3048009
2010-07-21 15:11:10 -05:00
Will Drewry
78992a33f4 build_image, build_kernel_image, update_bootloaders: fix up rootfs_verification
This change adds
- --rootfs_hash_pad to specify the MBs reserved for the pad
- the implementation of the above flag
- check if total fs size + pad size exceeds the partition size
- hash appending in make_image_bootable()

Fixes:
- a style for ROOT_FS_HASH usage
- bad mount|grep
- bad bash subst for root devices in all boot paths
- fixed a typo in the update_bootloaders table creation
- disables verified usb for now

Adding the padding argument ensures that the generated hash tree for the root filesystem is appended to the image.  Assuming the rootfs is _never_ mounted read-write
again, that hash tree will be valid and vboot will be able to proceed.

BUG=chromium-os:2693
TEST=manual build_image

Review URL: http://codereview.chromium.org/3043011

Change-Id: I67d9b0f91cacdefa309c0cc2dd7fed1d2eddd7a7
2010-07-21 14:02:20 -05:00
Will Drewry
721d94f429 build_image,update_bootloaders: directly update the built image
Instead of playing mount and loop device games, this change adds support for
update_bootloaders.sh to directly update the EFI system partition living in the
image if a file, offset, and size is supplied.

TEST=build_image for x86-generic; booted resulting image
BUG=broken build

Change-Id: I3d891fd965df6fb4abfc63d660e314c497a4184d

Review URL: http://codereview.chromium.org/3006006
2010-07-16 14:39:45 -05:00
Andrew de los Reyes
3172b7e296 build_image: add temporary hack to fix syslinux building.
Will Drewry is working on the proper fix, but this unblocks people who
build images that boot w/ syslinux.

Review URL: http://codereview.chromium.org/3009003
2010-07-15 22:10:47 -07:00
Zelidrag Hornung
478a0d44a4 Renamed VM image to match naming convention of other images.
Review URL: http://codereview.chromium.org/2955014
2010-07-14 11:47:39 -07:00
Denis Romanov
95bdf47a1a Added command line parameter to specify OEM content location.
Added populating OEM partner partition with content.
Added creating flag file .consider_oobe for OEM partition to get mounted on OOBE.

BUG=http://crosbug.com/3828
TEST=Install Chrome OS on the device from USB stick. /mnt/partner_partition contains etc/... directory with customization manifests on first boot.

Review URL: http://codereview.chromium.org/2938003
2010-07-12 22:44:42 +04:00
Mandeep Singh Baines
87b169428f build_image: modify to not get devkeys from vboot_reference checkout
An earlier CL modifies the vboot_reference ebuild to install the
keys into /usr/share/vboot.

TEST=verified that build_image fails without this change and no
vboot_reference checkout but succeeds with this change and no
vboot_reference checkout

Change-Id: Ie2bc1091b52c36fd56cd5f763ee275afc91765c3

Review URL: http://codereview.chromium.org/2896008
2010-07-09 20:52:41 -07:00
Will Drewry
07e350578b build_image: enable syslinux installation for x86
Adds the --install_syslinux to the update_bootloaders call for x86.

BUG=chromium-os:2693
TEST=build_image with both tegra2 and x86-generic in progress. Doesn't affect actual booting until we change the active gpt boot partition.

Review URL: http://codereview.chromium.org/2911003
2010-07-09 14:50:42 -07:00
Will Drewry
1670d481a1 build_image, build_kernel_image, legacy_bootloaders: Rename vboot flags
The use_vboot and vboot_ flags were confusing from a functionality perspective
since verified boot as a feature encompasses firmware and kernel functionality.
The firmware bits are always enabled, but use_vboot enabled the image-integrity
portion of vboot.  It is not called
  --enable_rootfs_verification
and all options for the kernel functionality is under --verity_* given that
verity/dm-verity is the current working name for the module and userspace tool.

TEST=ran x86-generic build_image & tegra2-dev-board build_image and checked the resulting boot.config files (with and without --enable_rootfs_verification).
BUG=chromium-os:2693

Review URL: http://codereview.chromium.org/2917008
2010-07-09 13:08:38 -07:00
David James
fd7403ab89 Revert "Use --fast by default in build_image when --jobs is enabled."
See if this fixes the symlink problems we've been running into.

This reverts commit 8edffbaec5.
2010-07-09 12:00:17 -07:00
David James
8edffbaec5 Revert "Revert "Use --fast by default in build_image when --jobs is enabled.""
parallel_emerge prints a message every 30 seconds now so that buildbot doesn't
kill us early. Per discussion with cmasone, reverting the revert.

This reverts commit debaa3d8cf.
2010-07-08 21:21:41 -07:00
Chris Masone
debaa3d8cf Revert "Use --fast by default in build_image when --jobs is enabled."
This reverts commit f0fb864e8d.

This change needs to be reverted because it suppresses logging output
from the build process.  Thus, when something goes wrong...the
sherriff is left completely helpless in terms of debugging the issue.

TBR: davidjames@chromium.org
2010-07-08 21:10:23 -07:00
David James
f0fb864e8d Use --fast by default in build_image when --jobs is enabled.
Also update eretry to not pass in $EMERGE_JOBS anymore, in coordination with my previous change, which passed it in directly instead of depending on eretry to do so: http://codereview.chromium.org/2944004/show

TEST=Ran build_image --jobs 2 and build_packages --jobs 2
BUG=none

Review URL: http://codereview.chromium.org/2914004
2010-07-08 20:17:45 -07:00
Tien-Ren Chen
71ff3fc632 fix disappearing vmlinuz_hd.vblock problem
Review URL: http://codereview.chromium.org/2905001
2010-07-08 15:27:59 +08:00
Tammo Spalink
cfc0c64823 Allow python to find gtk module. (originally nsanders CL)
BUG=4464
TEST=manually edit file so far

Review URL: http://codereview.chromium.org/2850045
2010-07-07 10:51:21 +08:00
Louis Yung-Chieh Lo
85d49fc1d9 Copy vmlinuz_hd.vblock only in x86 platform.
Review URL: http://codereview.chromium.org/2842044
2010-07-05 22:55:31 +08:00
Louis Yung-Chieh Lo
ca1c2b0430 Change code of copy vmlinuz_hd.vblock to make_image_bootable().
Review URL: http://codereview.chromium.org/2857037
2010-07-05 17:37:05 +08:00
Louis Yung-Chieh Lo
3602040b74 Use the new developer keys to sign things. (submit for Bill)
The original CL is http://codereview.chromium.org/2868044/show

Review URL: http://codereview.chromium.org/2818045
2010-07-05 13:23:34 +08:00
Will Drewry
25861ee160 TBR: use the correct output directory
Pushed with the rootfs instead of output dir.

TBR=fes
BUG=none
TEST=manual
2010-07-04 05:09:41 -07:00
Will Drewry
c985ae271f TBR: build_image chmods the /boot copy
TBR=fes
BUG=none
TEST=manual (no local archive_build)
2010-07-04 05:06:50 -07:00
Will Drewry
82780e5c37 TBR: clean up arm
Right now, the created arm.mbr is the size of the ESP
partition. It should be truncated though to just the mbr size.

In addition, dm= doesnt do anything on arm yet so replacing use with a todo and adding a check if it isn't there.

TEST=manually ran
BUG=none
TBR=fes
2010-07-03 18:27:10 -07:00
Will Drewry
821d07cb42 build_image: fix hash perms & arm image path
This should fix the bad parsing and the failed archiving.
EMphasis on should. I'll keep monitoring.

TEST=in progress
BUG=none

Review URL: http://codereview.chromium.org/2812044
2010-07-03 17:14:58 -07:00
Will Drewry
4a675e18a0 [PATCH 5/5] build_image: refactor bootloaders and enable vboot config paths
This change adds make_image_bootable which combines the
prior changes to make ARM, x86-legacy, x86-efi, and x86-fw
share kernel commandlines (where possible) and not rely on
keeping data stored on the rootfs to do so.

It does not enable a cut over to syslinux yet, though.

TEST=manually built image and tested boot and install (in progress)
BUG=chromium-os:327

Review URL: http://codereview.chromium.org/2834038
2010-07-03 13:35:02 -05:00
Will Drewry
1ee156fd00 [PATCH 3/5] Unify efi and legacy bootloader configuration generation
This change unifies the creation of extlinux.conf,
syslinux cfgs, and grub efi files.  It shouldn't change the
existing behavior but does add support for further arguments
and future use of syslinux (once it is properly rewritten by
an installer or other script).

TEST=in progress; manual run
BUG=chromium-os:327

Review URL: http://codereview.chromium.org/2829038
2010-07-03 13:27:19 -05:00
Bill Richardson
2ace49e0a4 Generate and use .vbprivk files for signing now.
Review URL: http://codereview.chromium.org/2817047
2010-07-01 10:23:27 -07:00
Nick Sanders
f2dee6c5df Add --fast to build_image
Include checked in parallel emerge,
with an optional (default false) argument
in build_image to turn it on.

Review URL: http://codereview.chromium.org/2827037
2010-07-01 00:21:32 -07:00
Denis Romanov
110615446e Added empty ext3 filesystem initialization for OEM partner partition.
BUG=http://crosbug.com/3828
TEST=When mounted, /dev/sd8 (OEM partition) has a valid empty filesystem on it.

Review URL: http://codereview.chromium.org/2867030
2010-06-29 04:23:53 +04:00
Eric Li
5cf288fb1c Increase stateful test partition size to 1G, to accommodate autotest package pre-installation under /usr/local.
Review URL: http://codereview.chromium.org/2865018
2010-06-28 12:46:26 -07:00
David James
868d7bb6b9 Added --preserve option and logic.
Other changes:
- Added update_base_packages() method.
- Fix a get_latest_image.sh problem when the image does not already exist.
- Cleanup method invocations, and remove OUTPUT_IMG global variable.
- Add kernel testing logic back (it was accidentally deleted in an earlier patch.)

TEST=Built regular image. Updated old image to contain new packages.
BUG=none

Patch by: Don Garrett <dgarrett@chromium.org>
(Tweaked by me to address review feedback.)

Review URL: http://codereview.chromium.org/2857020
2010-06-24 21:48:14 -07:00
Tan Gao
40551cd9ca recovery installer: fix build_gpt and build_image
Change-Id: I3cbb62827a33894f47d26dd047134b6c39c6667b

Review URL: http://codereview.chromium.org/2813029
2010-06-24 16:33:32 -07:00
Mandeep Singh Baines
3dfa852743 build_image: use --usepkg instead of --usepkgonly
We want build_image to honour the configuration in PORTDIR and only use
the latest stable version as known by portage and the overlays.

We get these semantics with --usepkg. We do not get them with --usepkgonly.
The one downside is that instead of failing when you forget to run
build_packages before build_image, build_image will try to build
packages from source.

From "man emerge":

       --usepkg[=n] (-k)
              Tells emerge to use binary packages (from $PKGDIR) if they
              are available, thus possibly avoiding some  time-consuming
              compiles.   This option is useful for CD installs; you can
              export PKGDIR=/mnt/cdrom/packages and then use this option
              to have emerge "pull" binary packages from the CD in order
              to satisfy dependencies.

       --usepkgonly[=n] (-K)
              Tells emerge to only use binary packages  (from  $PKGDIR).
              All  the  binary packages must be available at the time of
              dependency  calculation  or  emerge  will  simply   abort.
              Portage  does not use $PORTDIR when calculating dependency
              information so all masking information is ignored.

Change-Id: I267dad8992ac683d0ff4db0d0c72baba61ecbccf

Review URL: http://codereview.chromium.org/2874013
2010-06-24 15:00:49 -07:00
Will Drewry
69563b7349 build_image: pull out kernel partition creation
Makes kernel partition creation standalone.  This is motivated
both by the ability to build test kernel partitions easily as well
the need to create all kernel command line configuration after the
rootfs has been completely created.

Instead of a massive overhaul, I'll do this refactor in pieces.

TEST=manually rebuilt the image
BUG=chromium-os:327

Review URL: http://codereview.chromium.org/2825021
2010-06-24 16:12:58 -05:00
Bill Richardson
8f23ff3dfe Add "gpt" to kernel parameters to ignore missing PMBR
Review URL: http://codereview.chromium.org/2799030
2010-06-23 21:41:59 -07:00
Chris Sosa
6c587b0a5b TBR: Fix build_image without reverting don's change. 2010-06-21 17:36:18 -07:00
Don Garrett
3f41e152bd Created wrapper methods for create_base_image and image updates.
update_dev_packages, and update_recovery_packages created.

Moved assorted global variables up to the top section, since they are global.

TEST=Ran build_image.
BUG=none

Review URL: http://codereview.chromium.org/2823010
2010-06-21 14:54:34 -07:00
Don Garrett
e0020b19b0 Fixed formatting in build_image $VAR -> ${VAR}.
Also remove trailing spaces, and add punctuation to comments.
TEST=Ran build_image
BUG=None

Review URL: http://codereview.chromium.org/2804012
2010-06-17 15:55:35 -07:00
Bill Richardson
25e4c18e96 Add distinct strings to kernel config files to indicate BIOS type.
This does nothing, except provide a way to determine which of the three
possible boot methods was used to boot the running image. Handy for
debugging BIOS issues on experimental and dogfood machines.

Review URL: http://codereview.chromium.org/2868010
2010-06-17 12:50:49 -07:00
Bill Richardson
6ed135883c Use new kernel-signing tools.
Review URL: http://codereview.chromium.org/2820012
2010-06-16 21:38:15 -07:00
Nick Sanders
d250927093 Add Build Timer
Review URL: http://codereview.chromium.org/2859005
2010-06-16 03:50:04 -07:00
Nick Sanders
8ab729ab98 Prototype faster build (kind of ugly)
Review URL: http://codereview.chromium.org/2724014
2010-06-16 03:15:17 -07:00
Nick Sanders
9e305dbae0 Add alternate grub setting for some systems
Review URL: http://codereview.chromium.org/2735017
2010-06-11 15:18:35 -07:00
rginda
e58b86fdcf remove dev-mode aterm related changes
aterm will be going back into every build for now, so we can revert these dev-mode only changes

BUG=chromium-os:3884
TEST=none yet

Review URL: http://codereview.chromium.org/2669004
2010-06-07 17:50:54 -07:00
Bill Richardson
3fefd2ad79 Only sign kernel for x86 for now. Leave ARM unsigned.
The signing work is being tested and developed on x86, and ARM isn't ready
to use it. Signing the ARM kernel is disruptive. We'll enable it for ARM
later.

Review URL: http://codereview.chromium.org/2599001
2010-06-03 11:03:27 -07:00
Tan Gao
a40ed448fc fix for issue 2610:
- add recovery installer config file (which invokes chromeos-install with
   --recovery flag)
 - update build_image to install recovery_installer pkg and changed base image
   name to recovery_image.bin

Review URL: http://codereview.chromium.org/2081018
2010-06-02 15:45:19 -07:00
Zelidrag Hornung
1d12c1a01d RootFS size customization params added
Review URL: http://codereview.chromium.org/2440005
2010-06-02 10:20:29 -07:00
Bill Richardson
6795622ce9 Make build_image create a bootable kernel partition.
Modify build_image to use the kernel_utility and the inline bootloader
to generate a bootable kernel partition.

Review URL: http://codereview.chromium.org/2112013

Review URL: http://codereview.chromium.org/2377003
2010-05-28 15:38:56 -07:00
Bill Richardson
2517edabb7 TBR: davidjames 2010-05-27 22:59:41 -07:00
Bill Richardson
c86f88fc44 Start generating a bootable kernel partition as part of build_image
Modify build_image to use the create_blob utility and the inline bootloader
to generate a bootable (but still unsigned) kernel partition.

Review URL: http://codereview.chromium.org/2112013
2010-05-27 21:44:17 -07:00
Anush Elangovan
bb85f8f023 Revert "Teach build_image to pull from buildbot as necessary..."
This reverts commit 6e65e658ff51dc6f3444e8fddb17b3e2b0590661.

Review URL: http://codereview.chromium.org/2315001
2010-05-27 11:00:57 -07:00
Chris Sosa
b689577aa6 Adds symlink for aterm in /usr/local for xterm.
TEST=Tested with developer build and verified xterm shortcut works correctly

Review URL: http://codereview.chromium.org/2163004
2010-05-25 17:47:51 -07:00
Anush Elangovan
2991604b4e Teach build_image to pull from buildbot as necessary when the package is unavailable locally.
TEST=./build_package && ./build_image for x86-generic and voguet20

Review URL: http://codereview.chromium.org/2074019
2010-05-21 10:09:04 -07:00
Chris Sosa
d44550272c Cleanup of adding pristine image and fixing of symlinks in developer image.
TEST=Tested with building a new image, looking in the output directory, running
the image and running vi.

Review URL: http://codereview.chromium.org/2075019
2010-05-20 10:14:06 -07:00
Tan Gao
6df5aeeebb fix for issue 2610
- add back in RECOVERY variable since we can't specify value "0" in place
    of boolean flag "--recovery"
  - for recovery image, make ROOT-B 1GB, KERN-B 16MB and stateful partition 1GB

Review URL: http://codereview.chromium.org/2133006
2010-05-19 14:19:55 -07:00
Girts Folkmanis
7a8a838350 Fix factory_install build.
- Don't run test image when building factory_image.
- Bump the size for factory_install image to 300MB, as the existing build_image
  overfills the current size.  The size does not really matter, as our SD card
  copying time depends on the size of the contents, not the disk size.

Review URL: http://codereview.chromium.org/2113013
2010-05-18 22:52:25 -07:00
Chris Sosa
9673f3b92e Always build pristine image as well as dev/test image.
TEST=Tested build process.  Tested dev image, test image and base image by booting all three and logging in.

Review URL: http://codereview.chromium.org/2106009
2010-05-18 13:24:40 -07:00
Tom Wai-Hong Tam
f87a3678dd Reduce the size of factory install shim.
Temporary approach to using INSTALL_MASK to suppress some non-relevant paths.
It reduces the size from ~426MB to ~163MB. Eventually, will remove it and
create a clean and separated ebuild for chromeos-factoryinstall.

Review URL: http://codereview.chromium.org/2084001
2010-05-17 16:06:33 +08:00
Bill Richardson
9c5e5ecad3 Use new grub2 variables to boot from the device with the bootloader
See http://codereview.chromium.org/2113004/show for details.

This also adds a script to allow manual selection of the preferred image (A or B).

BUG=none

Review URL: http://codereview.chromium.org/2090006
2010-05-14 17:00:21 -07:00
Chris Sosa
702618ff2b Move to using chromeos-test to emerge test dependencies in mod_image_for_test.
In addition unifies changes in mount_gpt_image and one-offs in mod_image_for_test
to consolidate gpt / var mounting.

Review URL: http://codereview.chromium.org/2064001
2010-05-14 12:52:32 -07:00
Chris Sosa
3f21b99e37 Dev flag is not used in customize_rootfs and we should not be making dev-specific changes there.
TEST=Built an image

Review URL: http://codereview.chromium.org/2019008
2010-05-10 16:34:47 -07:00
Nick Sanders
7789d34e97 Allow factory install shim to be overlay installed
Make standalone package for factory install, so it can be overlayed on top of an existing image.
Modify mod_image_for_test to do the overlay.

Review URL: http://codereview.chromium.org/1945004
2010-05-05 21:21:15 -07:00
Chris Sosa
b9f2d2ecbd Flag day flip of statefuldev
Review URL: http://codereview.chromium.org/1989001
2010-05-05 16:42:44 -07:00
Don Garrett
640a0585f5 Added restart_in_chroot_if_needed to common.sh.
Add restart_in_chroot_if_needed to common.sh, and modify the build scripts which referred to assert_inside_chroot to use it instead. The effect is that you don't ever have to explicitly enter_chroot.sh to build (still can, it work's fine).

Update mod_image_for_test.sh to use restart_in_chroot_if_needed

Review URL: http://codereview.chromium.org/1736025
2010-05-04 16:54:28 -07:00
Chris Sosa
5c37ce2e03 Modifies dev server to produce stateful gzip and modify image_to_live to use it.
TEST=Tested with image_to_live, memento_updater without image_to_live

This mimics the update process of the real image for the stateful partition.
By moving this the update into a separate script, I can add it to the gmerge
package such that developers will not have to use image_to_live.  This change
also removes the dependency on tar.

Review URL: http://codereview.chromium.org/1774021
2010-05-03 20:18:02 -07:00
robotboy
b75eee3d67 Add --bootargs option to build_image.
This allows appending extra kernel command line parameters to
the ARM kernel command line on the Voguev210 boards.

BUG=None
TEST=Built image

Review URL: http://codereview.chromium.org/1694021
2010-04-30 09:51:23 -07:00
Chris Sosa
bde8c1bccc Harden build_image to not lose loopback devices.
Review URL: http://codereview.chromium.org/1794007
2010-04-29 14:02:35 -07:00
Bill Richardson
041bd71932 Add more choices to grub2 menu.
This adds some '/dev/sdb' options to the grub2 menu, so that we can keep the
default boot partition /dev/sda3 while still using the USB key as a recovery
image. This is work in progress for EFI BIOS development.

Review URL: http://codereview.chromium.org/1706014
2010-04-27 09:36:14 -07:00
Daniel Erat
dd9818aaad build: Get rid of scary /dev/sdb defaults in scripts.
Choosing a default device is no good; the user should
tell us where the image should be written.

BUG=none
TEST=wrote an image

Review URL: http://codereview.chromium.org/1730012
2010-04-26 09:16:44 -07:00
Ken Mixter
d5c4b17da5 Revert "Retry on build_image failures and make sbt more aggressive by default"
This reverts commit 7c3272657eb2e3a106090c5ab57f16ba5ba21ffe.

Review URL: http://codereview.chromium.org/1594035
2010-04-16 10:11:02 -07:00
Ken Mixter
c223ba1e0c Retry on build_image failures and make sbt more aggressive by default
As with build_packages, only retries by default if you passed --jobs
even though build_image will indeed spuriously fail with only one job.
sync_build_test now uses jobs=#cores by default for both package and
image building.  Eventually will also use this for gclient sync'ing
once that is better vetted.

Review URL: http://codereview.chromium.org/1564035
2010-04-16 09:08:26 -07:00
Chris Sosa
3d9a10b393 Fix install mask and move dev_mode to true when dev packages are installed
Review URL: http://codereview.chromium.org/1553028
2010-04-13 15:00:46 -07:00
Bill Richardson
ba9682ac08 Change default grub.cfg to support fast-boot from EFI BIOS
Review URL: http://codereview.chromium.org/1518025
2010-04-13 13:02:32 -07:00
Jie Sun
96e2b09b24 current mkimage are build in u-boot package and copied to sys-root ( a x86 binary).
move mkimage to hard-host-depends and remove dependency from u-boot to kernel.
this will make use of mkimage on target possible in the future.

Review URL: http://codereview.chromium.org/1613008
2010-04-09 11:05:49 -07:00
Bill Richardson
a81df76a06 Replace "mount -o loop" with explict losetup use in build_image.
This fixes the loop device leak. The problem is that inside the chroot, we
have /etc/mtab as a symlink to /proc/mounts. That works most of the time,
but if you mount something using "-o loop", it isn't cleaned up correctly
when you umount it. To avoid that, we either have to replace the /etc/mtab
symlink with an empty file when we create the chroot, or we have to make
sure that we never execute a "mount -o loop" command from within the chroot.
If we use an empty /etc/mtab file, the builds work fine, but then we can't
see any mounted partitions that the host creates outside the chroot (such as
USB keys), which causes other problems. Bleah.

Review URL: http://codereview.chromium.org/1594020
2010-04-09 08:12:05 -07:00
Chris Sosa
1e5fe62f92 Fix build image
Review URL: http://codereview.chromium.org/1622015
2010-04-08 20:51:53 -07:00
Andrew de los Reyes
e7a04adc83 Factory Installer.
Change build_image to support building a factory install image. Also,
a shell script and startup script to run the factory installer.

Change software_update startup script to detect if it's a factory
install and abort if so.

BUG=2378,2379,2380
TEST=Tested factory install worked on device.
Wrapper script to perform factory install at boot.

AU: New arg to install on non-boot device partition. This is used to
install in the factory. Also, switch to shflags for argument parsing.

Review URL: http://codereview.chromium.org/1556022
2010-04-08 15:58:17 -07:00
Chris Sosa
503efe1f65 Add /usr/local/lib to readlibs for test_image and move ldconfig higher for sful
Review URL: http://codereview.chromium.org/1618007
2010-04-08 10:05:46 -07:00
Chris Sosa
4bffb8be6a Fix symlinks for gmergefs on stateful and keep other stateful items installed from build_image
Review URL: http://codereview.chromium.org/1561014
2010-04-07 17:23:54 -07:00
Bill Richardson
8b3bd10b91 Create EFI System Partition on USB image during build.
The EFI System Partition is a special disk partition where EFI BIOS expects
to find the platform-specific bootloader. We need this in order to work on
the BIOS/kernel handoff. It's not needed for the final ChromeOS image and it
isn't useful for legacy BIOS systems, so right now it only makes any difference on x86
devices with development BIOSes.

This change creates the partition for ARM builds as well; it has no effect
there, either.

Review URL: http://codereview.chromium.org/1513019
2010-04-06 15:00:10 -07:00
Chris Masone
35a83f99e4 Apparently, we have to have a rootfs big enough to hold all dev and test tools too.
I need a couple extra tools for testing purposes (about 10MB).  I'd love to not add space to the rootfs for these.  But...talking to sosa, it doesn't seem there's any other way.

Review URL: http://codereview.chromium.org/1576018
2010-04-05 16:51:53 -07:00
Chris Sosa
aa1a7fd63d Adds gmergefs. A method of remoting to a target and pushing new
packages using emerge from the host

Review URL: http://codereview.chromium.org/1515011
2010-04-02 14:06:29 -07:00
Antoine Labour
e9e585f330 Add a --to option to build_image
That way we can directly build an image onto a usb stick/sd card without a separate step.
Also, add mounting of /sys into the chroot that is needed by build_gpt on a block device.

Review URL: http://codereview.chromium.org/1521012
2010-04-01 15:57:57 -07:00
Bill Richardson
6dcea16492 Clean up temporary files and directories, add utilities.
Remove the temporary rootfs.image file and others that are left by build_image and related scripts. Also added tool to emit scripts that can pack and unpack the combined disk image.

Review URL: http://codereview.chromium.org/1567013
2010-03-31 19:20:24 -07:00
Bill Richardson
4364a2e679 Switch to GPT-format disk images.
This changes the disk image for both USB keys and hard-drive installs to use
the EFI GUID Partition Tables. This is a prequisite for booting with an EFI
BIOS. This change does not use the EFI Boot protocol; it still boots using
Legacy BIOS. The PMBR contains syslinux' gptmbr.bin, which searches the GPT
for a specified partition's GUID to boot.

I've tested it on my EeePC. The USB image works, chromeos-install works, and
the reimaged hard drive works. I have not yet tested the memento_updater.sh
script, but I wanted to start the review without waiting until it's all perfect.
I will also be refactoring build_gpt.sh and chromeos-install to share common
logic.

It's almost certain that all existing dogfood machines will need to be
reimaged from a USB key. We could probably figure out a way to upgrade
automatically, but not quickly or without risk.

In addition to the GPT formatting, the build_image script has changed to
emit a single usb.bin file. This can be copied directly onto a USB key and
booted. Installation of dev tools needs to happen with build_image, not
image_to_usb. I have not yet looked at the other image_to_* scripts.

Review URL: http://codereview.chromium.org/1100001
2010-03-30 14:17:34 -07:00
Antoine Labour
643fffab67 arm: don't truncate the mbr when installing the boot script. bad things happen otherwise
Review URL: http://codereview.chromium.org/1117005
2010-03-19 18:17:11 -07:00
Chris Sosa
cbac648820 Fix xterm
Review URL: http://codereview.chromium.org/1026002
2010-03-15 17:52:47 -07:00
Chris Sosa
77a2963e7d TBR: Change default to false 2010-03-15 14:12:15 -07:00
Chris Sosa
4bccd3c54d Build image part of http://codereview.chromium.org/913004/show
Review URL: http://codereview.chromium.org/998002
2010-03-15 13:23:14 -07:00
Bill Richardson
c09b94fda3 Replace symlink to build_image with real file.
Review URL: http://codereview.chromium.org/921001
2010-03-15 11:40:30 -07:00
tedbo
6a2c4c3365 Add symlinks to new build scripts. This obviates the need to run setup_source_tree.sh.
Review URL: http://codereview.chromium.org/650056
2010-02-19 14:54:50 -08:00