It's from Gentoo commit e32772476e61578dd91229d77b82f56822857d92.
It needed an update because the old version failed to build with the
new version of the readline library.
The package will take over the symlink creation from the
sys-apps/baselayout package for the following reasons:
- We will use the new location of the bash files as targets for the
symlinks (`/usr/share/flatcar/etc/skel/…`).
- This package makes sure that the symlinks won't dangle.
- `/usr/share/flatcar/etc` does not exist in GCE OEM ACI image because
we don't move `/etc` to `/usr/share/flatcar/etc` (actually, `/etc`
gets completely removed) when building this image. It makes bash
symlinks in core home directory to dangle and thus fail the rootfs
check that happens right after installing the
`coreos-base/coreos-oem-gce` package. Using the old location for the
bash symlinks (that'd be `/usr/share/skel`) wouldn't help, because
the files there also became symlinks, and they are dangling too.
This can't fix it in the manglefs script because it's invoked too
late, after the rootfs check. I decided to move the core home bash
symlink creation to `coreos-base/misc-files` as this package won't
be installed in ACI image.
The new coreos-base/misc-files package will contain the compatibility
symlinks and other files we added as modifications to Gentoo
ebuilds. Now we will be moving the app-shells/bash package to
portage-stable, so move our bashrc snippet and symlink creation to the
new package.
The temporary /etc backup created during emerging packages should only
contain empty files that will make sure that the symlinks pointing to
files within the /etc backup won't dangle at any time.
getacl is currently failing with a buffer overflow:
$ getfacl /
getfacl: Removing leading '/' from absolute path names
# file: .
# owner: root
# group: root
*** buffer overflow detected ***: terminated
Aborted (core dumped)
This has been addressed upstream in acl-2.3.1-r1 by lowering
FORTIFY_SOURCE level.
Upstream commit 6273f7c0c37bc0fae7071ec6237654796bdcca55.
Signed-off-by: Jeremi Piotrowski <jpiotrowski@microsoft.com>
This change updates dispatching of SDK and OS image builds from changes
to a PR to an explicit comment. PRs will only be built if that comment
was added by a member of the Flatcar maintainers team.
Signed-off-by: Thilo Fromm <thilofromm@microsoft.com>
This change is a building block for PR builds triggered by PR commands.
It checks for membership of the commenter in the Flatcar Maintainers
team.
Note that the "issue comment" event (which is also triggered on PR
comments) is only emitted to workflows in the "main" branch. So in order
to test / trigger this workflow, a transient "PR update" event is used,
and the "commenter" user's login is hard-coded for testing.
This will be updated to using the actual commenter's login before merge.
Signed-off-by: Thilo Fromm <thilofromm@microsoft.com>
This change adds a github actions workflow to build a new SDK container
based on an existing SDK container. This can be used for CI testing
intrusive changes that also affect the SDK without bootstrapping a whole
new SDK.
Signed-off-by: Thilo Fromm <thilofromm@microsoft.com>
git show-ref in check_remote_branch is not working at all, because the
GitHub Actions checkout fetches a git repo with only depth 1 by default.
That means only main branch is available, not any other remote branches.
As a result, git show-ref always fails.
Fix that by checking for remote branches by git ls-remote.
