cros_workon: fix arguments passed to loman

fix arguments passed to loman. revision should not be passed wrapped in ""
otherwise, if not set, it will pass an extra blank argument to loman which
breaks the argument count checking.

BUG=chromium-os:33688
TEST=verified with remote project both with and without revision works.

CQ-DEPEND:I568a9e2821a1c089a0ba391f6df6c0e3b2dc61c9

Change-Id: Ica7d04cf5c3f7ab3871c71abe8b6025b561ac81f
Signed-off-by: Rhyland Klein <rklein@nvidia.com>
Reviewed-on: https://gerrit.chromium.org/gerrit/32392
Commit-Ready: Brian Harring <ferringb@chromium.org>
Reviewed-by: Brian Harring <ferringb@chromium.org>
Tested-by: Brian Harring <ferringb@chromium.org>
This commit is contained in:
Rhyland Klein 2012-09-06 11:31:44 -04:00 committed by Gerrit
parent 389634d71c
commit d5e3c01c08

View File

@ -279,9 +279,9 @@ regen_manifest_and_sync() {
local srcdir=$(readlink -m "${S}")
local revision="${FLAGS_revision:+--revision=${FLAGS_revision}}"
if [ -z "${FLAGS_remote}" ]; then
loman add --workon "${CROS_WORKON_PROJECT[i]}" "${revision}"
loman add --workon "${CROS_WORKON_PROJECT[i]}" ${revision}
else
loman add --remote "${FLAGS_remote}" "${revision}" \
loman add --remote "${FLAGS_remote}" ${revision} \
"${CROS_WORKON_PROJECT[i]}" "${srcdir#${trunkdir}/}"
fi
: $(( ++i ))