From d5e3c01c08a0d8a86e40d1a3fc230ee0422424ae Mon Sep 17 00:00:00 2001 From: Rhyland Klein Date: Thu, 6 Sep 2012 11:31:44 -0400 Subject: [PATCH] cros_workon: fix arguments passed to loman fix arguments passed to loman. revision should not be passed wrapped in "" otherwise, if not set, it will pass an extra blank argument to loman which breaks the argument count checking. BUG=chromium-os:33688 TEST=verified with remote project both with and without revision works. CQ-DEPEND:I568a9e2821a1c089a0ba391f6df6c0e3b2dc61c9 Change-Id: Ica7d04cf5c3f7ab3871c71abe8b6025b561ac81f Signed-off-by: Rhyland Klein Reviewed-on: https://gerrit.chromium.org/gerrit/32392 Commit-Ready: Brian Harring Reviewed-by: Brian Harring Tested-by: Brian Harring --- cros_workon | 4 ++-- 1 file changed, 2 insertions(+), 2 deletions(-) diff --git a/cros_workon b/cros_workon index 8c903489bc..8e60fc0e4e 100755 --- a/cros_workon +++ b/cros_workon @@ -279,9 +279,9 @@ regen_manifest_and_sync() { local srcdir=$(readlink -m "${S}") local revision="${FLAGS_revision:+--revision=${FLAGS_revision}}" if [ -z "${FLAGS_remote}" ]; then - loman add --workon "${CROS_WORKON_PROJECT[i]}" "${revision}" + loman add --workon "${CROS_WORKON_PROJECT[i]}" ${revision} else - loman add --remote "${FLAGS_remote}" "${revision}" \ + loman add --remote "${FLAGS_remote}" ${revision} \ "${CROS_WORKON_PROJECT[i]}" "${srcdir#${trunkdir}/}" fi : $(( ++i ))