setup_board: drop arm-none-eabi gdb workaround

Now that the bots have run and built gdb binpkgs, release this onto
the wider development community.

BUG=chromium-os:26998
TEST=`./setup_board --board=amd64-generic --usepkg` installed arm-none-eabi/gdb via binpkg

Change-Id: I1f870d7a07662c96d9154d2e4d4777c00f6c9fdc
Reviewed-on: https://gerrit.chromium.org/gerrit/17482
Reviewed-by: David James <davidjames@chromium.org>
Reviewed-by: asharif <asharif@chromium.org>
Commit-Ready: Mike Frysinger <vapier@chromium.org>
Tested-by: Mike Frysinger <vapier@chromium.org>
This commit is contained in:
Mike Frysinger 2012-03-07 10:37:14 -05:00 committed by Gerrit
parent 7119cb1499
commit bb214a9f59

View File

@ -206,16 +206,6 @@ toolchain_needs_update() {
fi fi
fi fi
# HACK: Older crossdev did not generate a gdb even when given
# --ex-gdb if it did not build all previous stages. So need
# to skip gdb for these targets until the binpkgs get posted
# otherwise users end up hitting problems when they setup_board.
if [[ ${FLAGS_usepkg} -eq ${FLAGS_TRUE} ]] &&
[[ ${toolchain} == "arm-none-eabi" ]] &&
[[ ${pn} == "gdb" ]] ; then
continue
fi
pkgs+=( "${atom}" ) pkgs+=( "${atom}" )
done done
@ -271,17 +261,9 @@ build_toolchain() {
CROSS_ARGS+=( CROSS_ARGS+=(
--overlays "${CHROMIUMOS_OVERLAY} /usr/local/portage/stable" --overlays "${CHROMIUMOS_OVERLAY} /usr/local/portage/stable"
--ov-output "${CROSSDEV_OVERLAY}" --ov-output "${CROSSDEV_OVERLAY}"
--ex-gdb
) )
# HACK: Older crossdev did not generate a gdb even when given
# --ex-gdb if it did not build all previous stages. So need
# to skip gdb for these targets until the binpkgs get posted
# otherwise users end up hitting problems when they setup_board.
if [[ ${FLAGS_usepkg} -ne ${FLAGS_TRUE} ]] ||
[[ ${toolchain} != "arm-none-eabi" ]] ; then
CROSS_ARGS+=( --ex-gdb )
fi
sudo -E FEATURES="splitdebug ${FEATURES}" crossdev "${CROSS_ARGS[@]}" sudo -E FEATURES="splitdebug ${FEATURES}" crossdev "${CROSS_ARGS[@]}"
} }