From bb214a9f59fdf2af42bb446596af519fa17372bf Mon Sep 17 00:00:00 2001 From: Mike Frysinger Date: Wed, 7 Mar 2012 10:37:14 -0500 Subject: [PATCH] setup_board: drop arm-none-eabi gdb workaround Now that the bots have run and built gdb binpkgs, release this onto the wider development community. BUG=chromium-os:26998 TEST=`./setup_board --board=amd64-generic --usepkg` installed arm-none-eabi/gdb via binpkg Change-Id: I1f870d7a07662c96d9154d2e4d4777c00f6c9fdc Reviewed-on: https://gerrit.chromium.org/gerrit/17482 Reviewed-by: David James Reviewed-by: asharif Commit-Ready: Mike Frysinger Tested-by: Mike Frysinger --- setup_board | 20 +------------------- 1 file changed, 1 insertion(+), 19 deletions(-) diff --git a/setup_board b/setup_board index 0222cfaaaf..a3437888a2 100755 --- a/setup_board +++ b/setup_board @@ -206,16 +206,6 @@ toolchain_needs_update() { fi fi - # HACK: Older crossdev did not generate a gdb even when given - # --ex-gdb if it did not build all previous stages. So need - # to skip gdb for these targets until the binpkgs get posted - # otherwise users end up hitting problems when they setup_board. - if [[ ${FLAGS_usepkg} -eq ${FLAGS_TRUE} ]] && - [[ ${toolchain} == "arm-none-eabi" ]] && - [[ ${pn} == "gdb" ]] ; then - continue - fi - pkgs+=( "${atom}" ) done @@ -271,17 +261,9 @@ build_toolchain() { CROSS_ARGS+=( --overlays "${CHROMIUMOS_OVERLAY} /usr/local/portage/stable" --ov-output "${CROSSDEV_OVERLAY}" + --ex-gdb ) - # HACK: Older crossdev did not generate a gdb even when given - # --ex-gdb if it did not build all previous stages. So need - # to skip gdb for these targets until the binpkgs get posted - # otherwise users end up hitting problems when they setup_board. - if [[ ${FLAGS_usepkg} -ne ${FLAGS_TRUE} ]] || - [[ ${toolchain} != "arm-none-eabi" ]] ; then - CROSS_ARGS+=( --ex-gdb ) - fi - sudo -E FEATURES="splitdebug ${FEATURES}" crossdev "${CROSS_ARGS[@]}" }