From 2ea8a7859eae982638072101bca17299a70cc8f4 Mon Sep 17 00:00:00 2001 From: David James Date: Fri, 13 Jan 2012 10:17:33 -0800 Subject: [PATCH] Don't skip over /usr/local/autotest when generating symbols. Right now, the buildbot won't symbolize any crash that occurs in autotest because all symbols in /usr/local/autotest are skipped by breakpad. Tweak cros_generate_breakpad_symbols to not skip over these symbols so that browser test crashes can be symbolized. BUG=chromium-os:25061 TEST=Run cros_generate_breakpad_symbols and verify it still completes successfully, and generates working symbols for autotest that can be used to symbolize browser test crashes. Change-Id: I072498060e78b373bd12c94ff95465878301cbce Reviewed-on: https://gerrit.chromium.org/gerrit/14155 Commit-Ready: David James Reviewed-by: David James Tested-by: David James --- cros_generate_breakpad_symbols | 10 ---------- 1 file changed, 10 deletions(-) diff --git a/cros_generate_breakpad_symbols b/cros_generate_breakpad_symbols index d907dcf937..67fe516afc 100755 --- a/cros_generate_breakpad_symbols +++ b/cros_generate_breakpad_symbols @@ -152,15 +152,6 @@ function process_file() { fi return 0 fi - if [ "${text_file#${AUTOTEST_ROOT}}" != "${text_file}" ]; then - # Skip autotest files, they are not part of the image to debug - # and some cause trouble to dump_syms because they are built - # externally (with different build options). - if [ ${FLAGS_verbose} -eq ${FLAGS_TRUE} ]; then - info "Skipping autotest file: ${text_file}" - fi - return 0 - fi if [ ! -f "${text_file}" ]; then # Allow files to not exist, for instance if they are in the INSTALL_MASK. warn "Binary does not exist: ${text_file}" @@ -202,7 +193,6 @@ function main() { info "Writing minidump symbols to ${FLAGS_minidump_symbol_root}" DEBUG_ROOT="${SYSROOT}/usr/lib/debug" - AUTOTEST_ROOT="${SYSROOT}/usr/local/autotest" CUMULATIVE_SIZE=0 sudo rm -rf "${FLAGS_minidump_symbol_root}"