mirrors/flatcar-scripts
1
0
Fork 0
mirror of https://github.com/flatcar/scripts.git synced 2025-09-27 08:31:04 +02:00
Code Issues Packages Projects Releases Wiki Activity

Add warnings if CHROME_ORIGIN is set on cros_workon start chromeos-chrome

Browse Source 
Because the chromeos-chrome ebuild will no longer force GERRIT_SOURCE,
warn a user that is starting to workon chromeos-chrome that they
may not be getting the experience they expect.

BUG=None
TEST=Ran cros_workon with CHROME_ORIGIN unset, set to GERRIT_SOURCE
  and set to LOCAL_SOURCE
  Saw warning only on LOCAL_SOURCE
  Ran cros_workon start kernel with CHROME_ORIGIN set and saw
    no warnings

Change-Id: Iecbc793d3b190a12a126d42a1bfaee6d8846e9ec
Reviewed-on: https://gerrit.chromium.org/gerrit/10815
Tested-by: Jon Kliegman <kliegs@chromium.org>
Reviewed-by: Ryan Cui <rcui@chromium.org>
Commit-Ready: Jon Kliegman <kliegs@chromium.org>
This commit is contained in:
Jonathan Kliegman 2011-10-27 18:05:11 -04:00 committed by David James
parent 0ddc35067b
commit 016f63d1e3
1 changed files with 5 additions and 0 deletions
Show Stats Download Patch File Download Diff File Expand all files Collapse all files

5
cros_workon
View File

@ -261,6 +261,11 @@ chrome_to_live () {
# Run chrome_set_ver to set DEPS # Run chrome_set_ver to set DEPS
info "Setting Chrome dependencies to the correct revision." info "Setting Chrome dependencies to the correct revision."
${CHROME_SET_VER} ${CHROME_SET_VER}
if [ -n "${CHROME_ORIGIN}" ] && [ "${CHROME_ORIGIN}" != GERRIT_SOURCE ]; then
warn "CHROME_ORIGIN is already set to ${CHROME_ORIGIN}"
warn "To use the new GERRIT_SOURCE workflow, please unset it."
warn "Run 'unset CHROME_ORIGIN' to reset to the default source location."
fi
} }
# Move a stable ebuild to the live development catgeory. The ebuild # Move a stable ebuild to the live development catgeory. The ebuild