From 016f63d1e30f7a8a4e6714ac608dd4edc9f25a0e Mon Sep 17 00:00:00 2001 From: Jonathan Kliegman Date: Thu, 27 Oct 2011 18:05:11 -0400 Subject: [PATCH] Add warnings if CHROME_ORIGIN is set on cros_workon start chromeos-chrome Because the chromeos-chrome ebuild will no longer force GERRIT_SOURCE, warn a user that is starting to workon chromeos-chrome that they may not be getting the experience they expect. BUG=None TEST=Ran cros_workon with CHROME_ORIGIN unset, set to GERRIT_SOURCE and set to LOCAL_SOURCE Saw warning only on LOCAL_SOURCE Ran cros_workon start kernel with CHROME_ORIGIN set and saw no warnings Change-Id: Iecbc793d3b190a12a126d42a1bfaee6d8846e9ec Reviewed-on: https://gerrit.chromium.org/gerrit/10815 Tested-by: Jon Kliegman Reviewed-by: Ryan Cui Commit-Ready: Jon Kliegman --- cros_workon | 5 +++++ 1 file changed, 5 insertions(+) diff --git a/cros_workon b/cros_workon index ee4d925f3d..6272217caa 100755 --- a/cros_workon +++ b/cros_workon @@ -261,6 +261,11 @@ chrome_to_live () { # Run chrome_set_ver to set DEPS info "Setting Chrome dependencies to the correct revision." ${CHROME_SET_VER} + if [ -n "${CHROME_ORIGIN}" ] && [ "${CHROME_ORIGIN}" != GERRIT_SOURCE ]; then + warn "CHROME_ORIGIN is already set to ${CHROME_ORIGIN}" + warn "To use the new GERRIT_SOURCE workflow, please unset it." + warn "Run 'unset CHROME_ORIGIN' to reset to the default source location." + fi } # Move a stable ebuild to the live development catgeory. The ebuild