mirror of
https://github.com/kubernetes-sigs/external-dns.git
synced 2026-05-05 06:36:11 +02:00
Merge branch 'master' into akamai-provider-1846
This commit is contained in:
commit
ef5e888488
@ -52,7 +52,7 @@ Note, how your provider doesn't need to know anything about where the DNS record
|
||||
# Running Github Actions locally
|
||||
|
||||
You can also extend the CI workflow which is currently implemented as Github Action within the [workflow](https://github.com/kubernetes-sigs/external-dns/tree/HEAD/.github/workflows) folder.
|
||||
In order to test your changes before commiting you can leverage [act](https://github.com/nektos/act) to run the Github Action locally.
|
||||
In order to test your changes before committing you can leverage [act](https://github.com/nektos/act) to run the Github Action locally.
|
||||
|
||||
Follow the installation instructions in the nektos/act [README.md](https://github.com/nektos/act/blob/master/README.md).
|
||||
Afterwards just run `act` within the root folder of the project.
|
||||
|
||||
@ -1,5 +1,5 @@
|
||||
# Setting up ExternalDNS for CoreDNS with minikube
|
||||
This tutorial describes how to setup ExternalDNS for usage within a [minikube](https://github.com/kubernetes/minikube) cluster that makes use of [CoreDNS](https://github.com/coredns/coredns) and [nginx ingress controller](https://github.com/kubernetes/ingress-nginx).
|
||||
This tutorial describes how to setup ExternalDNS for usage within a [minikube](https://github.com/kubernetes/minikube) cluster that makes use of [CoreDNS](https://github.com/coredns/coredns) and [nginx ingress controller](https://github.com/kubernetes/ingress-nginx).
|
||||
You need to:
|
||||
* install CoreDNS with [etcd](https://github.com/etcd-io/etcd) enabled
|
||||
* install external-dns with coredns as a provider
|
||||
@ -24,7 +24,7 @@ helm install stable/etcd-operator --name my-etcd-op
|
||||
```
|
||||
etcd cluster is installed with example yaml from etcd operator website.
|
||||
```
|
||||
kubectl apply -f https://raw.githubusercontent.com/coreos/etcd-operator/HEAD/example/example-etcd-cluster.yaml
|
||||
kubectl apply -f https://raw.githubusercontent.com/coreos/etcd-operator/HEAD/example/example-etcd-cluster.yaml
|
||||
```
|
||||
|
||||
### Installing CoreDNS
|
||||
@ -34,7 +34,7 @@ wget https://raw.githubusercontent.com/helm/charts/HEAD/stable/coredns/values.ya
|
||||
```
|
||||
|
||||
You need to edit/patch the file with below diff
|
||||
```
|
||||
```diff
|
||||
diff --git a/values.yaml b/values.yaml
|
||||
index 964e72b..e2fa934 100644
|
||||
--- a/values.yaml
|
||||
@ -68,7 +68,7 @@ index 964e72b..e2fa934 100644
|
||||
# Complete example with all the options:
|
||||
# - zones: # the `zones` block can be left out entirely, defaults to "."
|
||||
```
|
||||
**Note**:
|
||||
**Note**:
|
||||
* IP address of etcd's endpoint should be get from etcd client service. It should be "example-etcd-cluster-client" in this example. This IP address is used through this document for etcd endpoint configuration.
|
||||
```
|
||||
$ kubectl get svc example-etcd-cluster-client
|
||||
@ -228,5 +228,5 @@ $ kubectl run -it --rm --restart=Never --image=infoblox/dnstools:latest dnstools
|
||||
If you don't see a command prompt, try pressing enter.
|
||||
dnstools# dig @10.100.4.143 nginx.example.org +short
|
||||
10.0.2.15
|
||||
dnstools#
|
||||
dnstools#
|
||||
```
|
||||
|
||||
@ -188,7 +188,7 @@ kafka-1.example.org
|
||||
kafka-2.example.org
|
||||
```
|
||||
|
||||
If you set `--fqdn-template={{name}}.example.org` you can ommit the annotation.
|
||||
If you set `--fqdn-template={{name}}.example.org` you can omit the annotation.
|
||||
Generally it is a better approach to use `--fqdn-template={{name}}.example.org`, because then
|
||||
you would get the service name inside the generated A records:
|
||||
|
||||
|
||||
@ -269,7 +269,7 @@ status:
|
||||
```
|
||||
|
||||
ExternalDNS will create a A-records `echoserver.example.org`, that
|
||||
use AWS ALIAS record to automatically maintain IP adresses of the NLB.
|
||||
use AWS ALIAS record to automatically maintain IP addresses of the NLB.
|
||||
|
||||
## RouteGroup (optional)
|
||||
|
||||
|
||||
@ -128,13 +128,13 @@ func (sc *httpProxySource) Endpoints(ctx context.Context) ([]*endpoint.Endpoint,
|
||||
// Convert to []*projectcontour.HTTPProxy
|
||||
var httpProxies []*projectcontour.HTTPProxy
|
||||
for _, hp := range hps {
|
||||
unstrucuredHP, ok := hp.(*unstructured.Unstructured)
|
||||
unstructuredHP, ok := hp.(*unstructured.Unstructured)
|
||||
if !ok {
|
||||
return nil, errors.New("could not convert")
|
||||
}
|
||||
|
||||
hpConverted := &projectcontour.HTTPProxy{}
|
||||
err := sc.unstructuredConverter.scheme.Convert(unstrucuredHP, hpConverted, nil)
|
||||
err := sc.unstructuredConverter.scheme.Convert(unstructuredHP, hpConverted, nil)
|
||||
if err != nil {
|
||||
return nil, errors.Wrap(err, "failed to convert to HTTPProxy")
|
||||
}
|
||||
|
||||
Loading…
x
Reference in New Issue
Block a user