From fdbc66a47d0e6f98337007eeab9e9f1a1fb1eeaf Mon Sep 17 00:00:00 2001 From: bl-ue <54780737+bl-ue@users.noreply.github.com> Date: Sat, 28 Nov 2020 13:21:44 -0500 Subject: [PATCH 1/4] Fix diff highlighting in CoreDNS tutorial --- docs/tutorials/coredns.md | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/docs/tutorials/coredns.md b/docs/tutorials/coredns.md index 3f3464a64..2fab7f4af 100644 --- a/docs/tutorials/coredns.md +++ b/docs/tutorials/coredns.md @@ -34,7 +34,7 @@ wget https://raw.githubusercontent.com/helm/charts/HEAD/stable/coredns/values.ya ``` You need to edit/patch the file with below diff -``` +```diff diff --git a/values.yaml b/values.yaml index 964e72b..e2fa934 100644 --- a/values.yaml From 615c92ddd273b99ec5bf31e34361b54a55b09e63 Mon Sep 17 00:00:00 2001 From: bl-ue <54780737+bl-ue@users.noreply.github.com> Date: Sat, 28 Nov 2020 13:32:44 -0500 Subject: [PATCH 2/4] Cleanup extra whitespace --- docs/tutorials/coredns.md | 8 ++++---- 1 file changed, 4 insertions(+), 4 deletions(-) diff --git a/docs/tutorials/coredns.md b/docs/tutorials/coredns.md index 2fab7f4af..2e4ac6f7c 100644 --- a/docs/tutorials/coredns.md +++ b/docs/tutorials/coredns.md @@ -1,5 +1,5 @@ # Setting up ExternalDNS for CoreDNS with minikube -This tutorial describes how to setup ExternalDNS for usage within a [minikube](https://github.com/kubernetes/minikube) cluster that makes use of [CoreDNS](https://github.com/coredns/coredns) and [nginx ingress controller](https://github.com/kubernetes/ingress-nginx). +This tutorial describes how to setup ExternalDNS for usage within a [minikube](https://github.com/kubernetes/minikube) cluster that makes use of [CoreDNS](https://github.com/coredns/coredns) and [nginx ingress controller](https://github.com/kubernetes/ingress-nginx). You need to: * install CoreDNS with [etcd](https://github.com/etcd-io/etcd) enabled * install external-dns with coredns as a provider @@ -24,7 +24,7 @@ helm install stable/etcd-operator --name my-etcd-op ``` etcd cluster is installed with example yaml from etcd operator website. ``` -kubectl apply -f https://raw.githubusercontent.com/coreos/etcd-operator/HEAD/example/example-etcd-cluster.yaml +kubectl apply -f https://raw.githubusercontent.com/coreos/etcd-operator/HEAD/example/example-etcd-cluster.yaml ``` ### Installing CoreDNS @@ -68,7 +68,7 @@ index 964e72b..e2fa934 100644 # Complete example with all the options: # - zones: # the `zones` block can be left out entirely, defaults to "." ``` -**Note**: +**Note**: * IP address of etcd's endpoint should be get from etcd client service. It should be "example-etcd-cluster-client" in this example. This IP address is used through this document for etcd endpoint configuration. ``` $ kubectl get svc example-etcd-cluster-client @@ -228,5 +228,5 @@ $ kubectl run -it --rm --restart=Never --image=infoblox/dnstools:latest dnstools If you don't see a command prompt, try pressing enter. dnstools# dig @10.100.4.143 nginx.example.org +short 10.0.2.15 -dnstools# +dnstools# ``` From 9f28aa9106b43459e71525fc9fb8f9d6c77a8109 Mon Sep 17 00:00:00 2001 From: windayski Date: Mon, 30 Nov 2020 10:23:19 +0000 Subject: [PATCH 3/4] fix some typos --- docs/contributing/getting-started.md | 2 +- docs/tutorials/hostport.md | 2 +- docs/tutorials/kube-ingress-aws.md | 2 +- source/httpproxy.go | 4 ++-- 4 files changed, 5 insertions(+), 5 deletions(-) diff --git a/docs/contributing/getting-started.md b/docs/contributing/getting-started.md index 11a240ce3..cccfd7223 100644 --- a/docs/contributing/getting-started.md +++ b/docs/contributing/getting-started.md @@ -52,7 +52,7 @@ Note, how your provider doesn't need to know anything about where the DNS record # Running Github Actions locally You can also extend the CI workflow which is currently implemented as Github Action within the [workflow](https://github.com/kubernetes-sigs/external-dns/tree/HEAD/.github/workflows) folder. -In order to test your changes before commiting you can leverage [act](https://github.com/nektos/act) to run the Github Action locally. +In order to test your changes before committing you can leverage [act](https://github.com/nektos/act) to run the Github Action locally. Follow the installation instructions in the nektos/act [README.md](https://github.com/nektos/act/blob/master/README.md). Afterwards just run `act` within the root folder of the project. diff --git a/docs/tutorials/hostport.md b/docs/tutorials/hostport.md index b3f1c1273..ea9e8af4a 100644 --- a/docs/tutorials/hostport.md +++ b/docs/tutorials/hostport.md @@ -188,7 +188,7 @@ kafka-1.example.org kafka-2.example.org ``` -If you set `--fqdn-template={{name}}.example.org` you can ommit the annotation. +If you set `--fqdn-template={{name}}.example.org` you can omit the annotation. Generally it is a better approach to use `--fqdn-template={{name}}.example.org`, because then you would get the service name inside the generated A records: diff --git a/docs/tutorials/kube-ingress-aws.md b/docs/tutorials/kube-ingress-aws.md index 266cf4159..27ea646f4 100644 --- a/docs/tutorials/kube-ingress-aws.md +++ b/docs/tutorials/kube-ingress-aws.md @@ -269,7 +269,7 @@ status: ``` ExternalDNS will create a A-records `echoserver.example.org`, that -use AWS ALIAS record to automatically maintain IP adresses of the NLB. +use AWS ALIAS record to automatically maintain IP addresses of the NLB. ## RouteGroup (optional) diff --git a/source/httpproxy.go b/source/httpproxy.go index ea705c937..257cc2203 100644 --- a/source/httpproxy.go +++ b/source/httpproxy.go @@ -128,13 +128,13 @@ func (sc *httpProxySource) Endpoints(ctx context.Context) ([]*endpoint.Endpoint, // Convert to []*projectcontour.HTTPProxy var httpProxies []*projectcontour.HTTPProxy for _, hp := range hps { - unstrucuredHP, ok := hp.(*unstructured.Unstructured) + unstructuredHP, ok := hp.(*unstructured.Unstructured) if !ok { return nil, errors.New("could not convert") } hpConverted := &projectcontour.HTTPProxy{} - err := sc.unstructuredConverter.scheme.Convert(unstrucuredHP, hpConverted, nil) + err := sc.unstructuredConverter.scheme.Convert(unstructuredHP, hpConverted, nil) if err != nil { return nil, errors.Wrap(err, "failed to convert to HTTPProxy") } From 7f7c663da9cad7cc9af0ff2946be6ada537700b8 Mon Sep 17 00:00:00 2001 From: Kundan Kumar Date: Thu, 3 Dec 2020 15:41:07 +0530 Subject: [PATCH 4/4] fir for 1878 --- docs/tutorials/akamai-fastdns.md | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/docs/tutorials/akamai-fastdns.md b/docs/tutorials/akamai-fastdns.md index e4940b6b5..514964705 100644 --- a/docs/tutorials/akamai-fastdns.md +++ b/docs/tutorials/akamai-fastdns.md @@ -7,7 +7,7 @@ Akamai FastDNS provider support was added via [this PR](https://github.com/kuber The Akamai FastDNS provider expects that your zones, you wish to add records to, already exists and are configured correctly. It does not add, remove or configure new zones in anyway. -To do this please refer to the [FastDNS documentation](https://learn.akamai.com/en-us/products/web_performance/fast_dns.html). +To do this please refer to the [FastDNS documentation](https://developer.akamai.com/legacy/cli/packages/fast-dns.html). Additional data you will have to provide: