mirrors/external-dns
1
0
Fork 0
mirror of https://github.com/kubernetes-sigs/external-dns.git synced 2025-10-27 08:41:29 +01:00
Code Issues Packages Projects Releases Wiki Activity

Apply suggestions from code review

Browse Source 
Co-authored-by: Nick Jüttner <nick@juni.io>
This commit is contained in:
pg2000 2022-08-19 17:08:38 +02:00 committed by GitHub
parent 03a28eea6e
commit ce38a40e2b
No known key found for this signature in database
GPG Key ID: 4AEE18F83AFDEB23
1 changed files with 3 additions and 2 deletions
Show Stats Download Patch File Download Diff File Expand all files Collapse all files

5
provider/aws/aws.go
View File

@ -199,12 +199,13 @@ func NewAWSProvider(awsConfig AWSConfig) (*AWSProvider, error) {
} }
if awsConfig.AssumeRole != "" { if awsConfig.AssumeRole != "" {
log.Infof("Assuming role: %s", awsConfig.AssumeRole) if awsConfig.AssumeRoleExternalID != "" {
if awsConfig.AssumeRole != "" { log.Infof("Assuming role: %s with external id %s", awsConfig.AssumeRole, awsConfig.AssumeRoleExternalID)
session.Config.WithCredentials(stscreds.NewCredentials(session, awsConfig.AssumeRole, func(p *stscreds.AssumeRoleProvider) { session.Config.WithCredentials(stscreds.NewCredentials(session, awsConfig.AssumeRole, func(p *stscreds.AssumeRoleProvider) {
p.ExternalID = &awsConfig.AssumeRoleExternalID p.ExternalID = &awsConfig.AssumeRoleExternalID
})) }))
} else { } else {
log.Infof("Assuming role: %s", awsConfig.AssumeRole)
session.Config.WithCredentials(stscreds.NewCredentials(session, awsConfig.AssumeRole)) session.Config.WithCredentials(stscreds.NewCredentials(session, awsConfig.AssumeRole))
} }
} }