From ce38a40e2bacb5a79a9742f9dd09388ba39efa44 Mon Sep 17 00:00:00 2001 From: pg2000 <10741029+PG2000@users.noreply.github.com> Date: Fri, 19 Aug 2022 17:08:38 +0200 Subject: [PATCH] Apply suggestions from code review MIME-Version: 1.0 Content-Type: text/plain; charset=UTF-8 Content-Transfer-Encoding: 8bit Co-authored-by: Nick Jüttner --- provider/aws/aws.go | 5 +++-- 1 file changed, 3 insertions(+), 2 deletions(-) diff --git a/provider/aws/aws.go b/provider/aws/aws.go index 98c328177..56af8dda1 100644 --- a/provider/aws/aws.go +++ b/provider/aws/aws.go @@ -199,12 +199,13 @@ func NewAWSProvider(awsConfig AWSConfig) (*AWSProvider, error) { } if awsConfig.AssumeRole != "" { - log.Infof("Assuming role: %s", awsConfig.AssumeRole) - if awsConfig.AssumeRole != "" { + if awsConfig.AssumeRoleExternalID != "" { + log.Infof("Assuming role: %s with external id %s", awsConfig.AssumeRole, awsConfig.AssumeRoleExternalID) session.Config.WithCredentials(stscreds.NewCredentials(session, awsConfig.AssumeRole, func(p *stscreds.AssumeRoleProvider) { p.ExternalID = &awsConfig.AssumeRoleExternalID })) } else { + log.Infof("Assuming role: %s", awsConfig.AssumeRole) session.Config.WithCredentials(stscreds.NewCredentials(session, awsConfig.AssumeRole)) } }