mirrors/external-dns
1
0
Fork 0
mirror of https://github.com/kubernetes-sigs/external-dns.git synced 2025-08-06 09:36:58 +02:00
Code Issues Packages Projects Releases Wiki Activity

test(ns1): minTTLSeconds changes

Browse Source
This commit is contained in:
Matt Dennison 2020-05-14 09:34:49 -07:00
parent 6176d8151d
commit c74f22e123
2 changed files with 18 additions and 9 deletions
Show Stats Download Patch File Download Diff File Expand all files Collapse all files

2
provider/ns1/ns1.go
View File

@ -183,7 +183,7 @@ func (p *NS1Provider) ns1BuildRecord(zoneName string, change *ns1Change) *dns.Re
for _, v := range change.Endpoint.Targets { for _, v := range change.Endpoint.Targets {
record.AddAnswer(dns.NewAnswer(strings.Split(v, " "))) record.AddAnswer(dns.NewAnswer(strings.Split(v, " ")))
} }
// set detault ttl, but respect minTTLSeconds // set default ttl, but respect minTTLSeconds
var ttl = ns1DefaultTTL var ttl = ns1DefaultTTL
if p.minTTLSeconds > ttl { if p.minTTLSeconds > ttl {
ttl = p.minTTLSeconds ttl = p.minTTLSeconds

25
provider/ns1/ns1_test.go
View File

@ -129,9 +129,10 @@ func (m *MockNS1ListZonesFail) ListZones() ([]*dns.Zone, *http.Response, error)
func TestNS1Records(t *testing.T) { func TestNS1Records(t *testing.T) {
provider := &NS1Provider{ provider := &NS1Provider{
client: &MockNS1DomainClient{}, client: &MockNS1DomainClient{},
domainFilter: endpoint.NewDomainFilter([]string{"foo.com."}), domainFilter: endpoint.NewDomainFilter([]string{"foo.com."}),
zoneIDFilter: provider.NewZoneIDFilter([]string{""}), zoneIDFilter: provider.NewZoneIDFilter([]string{""}),
minTTLSeconds: 3600,
} }
ctx := context.Background() ctx := context.Background()
@ -195,10 +196,18 @@ func TestNS1BuildRecord(t *testing.T) {
RecordType: "A", RecordType: "A",
}, },
} }
record := ns1BuildRecord("foo.com", change)
provider := &NS1Provider{
client: &MockNS1DomainClient{},
domainFilter: endpoint.NewDomainFilter([]string{"foo.com."}),
zoneIDFilter: provider.NewZoneIDFilter([]string{""}),
minTTLSeconds: 300,
}
record := provider.ns1BuildRecord("foo.com", change)
assert.Equal(t, "foo.com", record.Zone) assert.Equal(t, "foo.com", record.Zone)
assert.Equal(t, "new.foo.com", record.Domain) assert.Equal(t, "new.foo.com", record.Domain)
assert.Equal(t, ns1DefaultTTL, record.TTL) assert.Equal(t, 300, record.TTL)
changeWithTTL := &ns1Change{ changeWithTTL := &ns1Change{
Action: ns1Create, Action: ns1Create,
@ -206,13 +215,13 @@ func TestNS1BuildRecord(t *testing.T) {
DNSName: "new-b", DNSName: "new-b",
Targets: endpoint.Targets{"target"}, Targets: endpoint.Targets{"target"},
RecordType: "A", RecordType: "A",
RecordTTL: 100, RecordTTL: 3600,
}, },
} }
record = ns1BuildRecord("foo.com", changeWithTTL) record = provider.ns1BuildRecord("foo.com", changeWithTTL)
assert.Equal(t, "foo.com", record.Zone) assert.Equal(t, "foo.com", record.Zone)
assert.Equal(t, "new-b.foo.com", record.Domain) assert.Equal(t, "new-b.foo.com", record.Domain)
assert.Equal(t, 100, record.TTL) assert.Equal(t, 3600, record.TTL)
} }
func TestNS1ApplyChanges(t *testing.T) { func TestNS1ApplyChanges(t *testing.T) {