diff --git a/provider/ns1/ns1.go b/provider/ns1/ns1.go index 82ebafc14..e859fa4f2 100644 --- a/provider/ns1/ns1.go +++ b/provider/ns1/ns1.go @@ -183,7 +183,7 @@ func (p *NS1Provider) ns1BuildRecord(zoneName string, change *ns1Change) *dns.Re for _, v := range change.Endpoint.Targets { record.AddAnswer(dns.NewAnswer(strings.Split(v, " "))) } - // set detault ttl, but respect minTTLSeconds + // set default ttl, but respect minTTLSeconds var ttl = ns1DefaultTTL if p.minTTLSeconds > ttl { ttl = p.minTTLSeconds diff --git a/provider/ns1/ns1_test.go b/provider/ns1/ns1_test.go index f4309ec50..6d529879b 100644 --- a/provider/ns1/ns1_test.go +++ b/provider/ns1/ns1_test.go @@ -129,9 +129,10 @@ func (m *MockNS1ListZonesFail) ListZones() ([]*dns.Zone, *http.Response, error) func TestNS1Records(t *testing.T) { provider := &NS1Provider{ - client: &MockNS1DomainClient{}, - domainFilter: endpoint.NewDomainFilter([]string{"foo.com."}), - zoneIDFilter: provider.NewZoneIDFilter([]string{""}), + client: &MockNS1DomainClient{}, + domainFilter: endpoint.NewDomainFilter([]string{"foo.com."}), + zoneIDFilter: provider.NewZoneIDFilter([]string{""}), + minTTLSeconds: 3600, } ctx := context.Background() @@ -195,10 +196,18 @@ func TestNS1BuildRecord(t *testing.T) { RecordType: "A", }, } - record := ns1BuildRecord("foo.com", change) + + provider := &NS1Provider{ + client: &MockNS1DomainClient{}, + domainFilter: endpoint.NewDomainFilter([]string{"foo.com."}), + zoneIDFilter: provider.NewZoneIDFilter([]string{""}), + minTTLSeconds: 300, + } + + record := provider.ns1BuildRecord("foo.com", change) assert.Equal(t, "foo.com", record.Zone) assert.Equal(t, "new.foo.com", record.Domain) - assert.Equal(t, ns1DefaultTTL, record.TTL) + assert.Equal(t, 300, record.TTL) changeWithTTL := &ns1Change{ Action: ns1Create, @@ -206,13 +215,13 @@ func TestNS1BuildRecord(t *testing.T) { DNSName: "new-b", Targets: endpoint.Targets{"target"}, RecordType: "A", - RecordTTL: 100, + RecordTTL: 3600, }, } - record = ns1BuildRecord("foo.com", changeWithTTL) + record = provider.ns1BuildRecord("foo.com", changeWithTTL) assert.Equal(t, "foo.com", record.Zone) assert.Equal(t, "new-b.foo.com", record.Domain) - assert.Equal(t, 100, record.TTL) + assert.Equal(t, 3600, record.TTL) } func TestNS1ApplyChanges(t *testing.T) {