mirrors/external-dns
1
0
Fork 0
mirror of https://github.com/kubernetes-sigs/external-dns.git synced 2025-08-06 17:46:57 +02:00
Code Issues Packages Projects Releases Wiki Activity

Merge pull request #5427 from AndrewCharlesHay/feat/cyclop

Browse Source 
chore(codebase): add cyclop max
This commit is contained in:
Kubernetes Prow Robot 2025-05-19 23:53:15 -07:00 committed by GitHub
commit 718ee660ff
No known key found for this signature in database
GPG Key ID: B5690EEEBB952194
2 changed files with 24 additions and 21 deletions
Show Stats Download Patch File Download Diff File Expand all files Collapse all files

3
.golangci.yml
View File

@ -20,6 +20,7 @@ linters:
- sloglint # Ensure consistent code style when using log/slog - sloglint # Ensure consistent code style when using log/slog
- asciicheck # Checks that all code identifiers does not have non-ASCII symbols in the name - asciicheck # Checks that all code identifiers does not have non-ASCII symbols in the name
- nilnil # Checks that there is no simultaneous return of nil error and an nil value. ref: https://golangci-lint.run/usage/linters/#nilnil - nilnil # Checks that there is no simultaneous return of nil error and an nil value. ref: https://golangci-lint.run/usage/linters/#nilnil
- cyclop # Checks function and package cyclomatic complexity. https://golangci-lint.run/usage/linters/#cyclop
settings: settings:
exhaustive: exhaustive:
default-signifies-exhaustive: false default-signifies-exhaustive: false
@ -29,6 +30,8 @@ linters:
rules: rules:
- name: confusing-naming - name: confusing-naming
disabled: true disabled: true
cyclop: # Lower cyclomatic complexity threshold after the max complexity is lowered
max-complexity: 52
exclusions: exclusions:
generated: lax generated: lax
presets: presets:

42
endpoint/endpoint_test.go
View File

@ -192,7 +192,7 @@ func TestIsLess(t *testing.T) {
func TestGetProviderSpecificProperty(t *testing.T) { func TestGetProviderSpecificProperty(t *testing.T) {
e := &Endpoint{ e := &Endpoint{
ProviderSpecific: []ProviderSpecificProperty{ ProviderSpecific: []ProviderSpecificProperty{
ProviderSpecificProperty{ {
Name: "name", Name: "name",
Value: "value", Value: "value",
}, },
@ -228,7 +228,7 @@ func TestSetProviderSpecficProperty(t *testing.T) {
key: "key1", key: "key1",
value: "value1", value: "value1",
expected: []ProviderSpecificProperty{ expected: []ProviderSpecificProperty{
ProviderSpecificProperty{ {
Name: "key1", Name: "key1",
Value: "value1", Value: "value1",
}, },
@ -245,7 +245,7 @@ func TestSetProviderSpecficProperty(t *testing.T) {
"example.org", "example.com", "1.2.4.5", "example.org", "example.com", "1.2.4.5",
}, },
ProviderSpecific: []ProviderSpecificProperty{ ProviderSpecific: []ProviderSpecificProperty{
ProviderSpecificProperty{ {
Name: "name1", Name: "name1",
Value: "value1", Value: "value1",
}, },
@ -256,11 +256,11 @@ func TestSetProviderSpecficProperty(t *testing.T) {
value: "value2", value: "value2",
expected: []ProviderSpecificProperty{ expected: []ProviderSpecificProperty{
ProviderSpecificProperty{ {
Name: "name1", Name: "name1",
Value: "value1", Value: "value1",
}, },
ProviderSpecificProperty{ {
Name: "name2", Name: "name2",
Value: "value2", Value: "value2",
}, },
@ -277,15 +277,15 @@ func TestSetProviderSpecficProperty(t *testing.T) {
"example.org", "example.com", "1.2.4.5", "example.org", "example.com", "1.2.4.5",
}, },
ProviderSpecific: []ProviderSpecificProperty{ ProviderSpecific: []ProviderSpecificProperty{
ProviderSpecificProperty{ {
Name: "name1", Name: "name1",
Value: "value1", Value: "value1",
}, },
ProviderSpecificProperty{ {
Name: "name2", Name: "name2",
Value: "value2", Value: "value2",
}, },
ProviderSpecificProperty{ {
Name: "name3", Name: "name3",
Value: "value3", Value: "value3",
}, },
@ -295,15 +295,15 @@ func TestSetProviderSpecficProperty(t *testing.T) {
value: "value2", value: "value2",
expectedIdentifier: "newIdentifier", expectedIdentifier: "newIdentifier",
expected: []ProviderSpecificProperty{ expected: []ProviderSpecificProperty{
ProviderSpecificProperty{ {
Name: "name1", Name: "name1",
Value: "value1", Value: "value1",
}, },
ProviderSpecificProperty{ {
Name: "name2", Name: "name2",
Value: "value2", Value: "value2",
}, },
ProviderSpecificProperty{ {
Name: "name3", Name: "name3",
Value: "value3", Value: "value3",
}, },
@ -320,7 +320,7 @@ func TestSetProviderSpecficProperty(t *testing.T) {
"example.org", "example.com", "1.2.4.5", "example.org", "example.com", "1.2.4.5",
}, },
ProviderSpecific: []ProviderSpecificProperty{ ProviderSpecific: []ProviderSpecificProperty{
ProviderSpecificProperty{ {
Name: "name1", Name: "name1",
Value: "value1", Value: "value1",
}, },
@ -330,7 +330,7 @@ func TestSetProviderSpecficProperty(t *testing.T) {
value: "value2", value: "value2",
expectedIdentifier: "identifier", expectedIdentifier: "identifier",
expected: []ProviderSpecificProperty{ expected: []ProviderSpecificProperty{
ProviderSpecificProperty{ {
Name: "name1", Name: "name1",
Value: "value2", Value: "value2",
}, },
@ -363,7 +363,7 @@ func TestDeleteProviderSpecificProperty(t *testing.T) {
name: "name and key are not matching", name: "name and key are not matching",
endpoint: Endpoint{ endpoint: Endpoint{
ProviderSpecific: []ProviderSpecificProperty{ ProviderSpecific: []ProviderSpecificProperty{
ProviderSpecificProperty{ {
Name: "name1", Name: "name1",
Value: "value1", Value: "value1",
}, },
@ -371,7 +371,7 @@ func TestDeleteProviderSpecificProperty(t *testing.T) {
}, },
key: "name2", key: "name2",
expected: []ProviderSpecificProperty{ expected: []ProviderSpecificProperty{
ProviderSpecificProperty{ {
Name: "name1", Name: "name1",
Value: "value1", Value: "value1",
}, },
@ -381,15 +381,15 @@ func TestDeleteProviderSpecificProperty(t *testing.T) {
name: "some keys are matching and some keys are not matching", name: "some keys are matching and some keys are not matching",
endpoint: Endpoint{ endpoint: Endpoint{
ProviderSpecific: []ProviderSpecificProperty{ ProviderSpecific: []ProviderSpecificProperty{
ProviderSpecificProperty{ {
Name: "name1", Name: "name1",
Value: "value1", Value: "value1",
}, },
ProviderSpecificProperty{ {
Name: "name2", Name: "name2",
Value: "value2", Value: "value2",
}, },
ProviderSpecificProperty{ {
Name: "name3", Name: "name3",
Value: "value3", Value: "value3",
}, },
@ -397,11 +397,11 @@ func TestDeleteProviderSpecificProperty(t *testing.T) {
}, },
key: "name2", key: "name2",
expected: []ProviderSpecificProperty{ expected: []ProviderSpecificProperty{
ProviderSpecificProperty{ {
Name: "name1", Name: "name1",
Value: "value1", Value: "value1",
}, },
ProviderSpecificProperty{ {
Name: "name3", Name: "name3",
Value: "value3", Value: "value3",
}, },
@ -411,7 +411,7 @@ func TestDeleteProviderSpecificProperty(t *testing.T) {
name: "name and key are matching", name: "name and key are matching",
endpoint: Endpoint{ endpoint: Endpoint{
ProviderSpecific: []ProviderSpecificProperty{ ProviderSpecific: []ProviderSpecificProperty{
ProviderSpecificProperty{ {
Name: "name1", Name: "name1",
Value: "value1", Value: "value1",
}, },