From 0f2dcb363f8bd1aac9d5a43bc0a24dfa28a6dbee Mon Sep 17 00:00:00 2001
From: Andrew Hay <39sumer3939@gmail.com>
Date: Mon, 19 May 2025 20:57:43 +0000
Subject: [PATCH] chore: add cyclop max

---
 .golangci.yml             |  3 +++
 endpoint/endpoint_test.go | 42 +++++++++++++++++++--------------------
 2 files changed, 24 insertions(+), 21 deletions(-)

diff --git a/.golangci.yml b/.golangci.yml
index 7b12c19c9..fed1a177c 100644
--- a/.golangci.yml
+++ b/.golangci.yml
@@ -20,6 +20,7 @@ linters:
     - sloglint # Ensure consistent code style when using log/slog
     - asciicheck  # Checks that all code identifiers does not have non-ASCII symbols in the name
     - nilnil # Checks that there is no simultaneous return of nil error and an nil value. ref: https://golangci-lint.run/usage/linters/#nilnil
+    - cyclop # Checks function and package cyclomatic complexity. https://golangci-lint.run/usage/linters/#cyclop
   settings:
     exhaustive:
       default-signifies-exhaustive: false
@@ -29,6 +30,8 @@ linters:
       rules:
         - name: confusing-naming
           disabled: true
+    cyclop: # Lower cyclomatic complexity threshold after the max complexity is lowered
+      max-complexity: 52
   exclusions:
     generated: lax
     presets:
diff --git a/endpoint/endpoint_test.go b/endpoint/endpoint_test.go
index 6776b81ad..b1b7f519d 100644
--- a/endpoint/endpoint_test.go
+++ b/endpoint/endpoint_test.go
@@ -192,7 +192,7 @@ func TestIsLess(t *testing.T) {
 func TestGetProviderSpecificProperty(t *testing.T) {
 	e := &Endpoint{
 		ProviderSpecific: []ProviderSpecificProperty{
-			ProviderSpecificProperty{
+			{
 				Name:  "name",
 				Value: "value",
 			},
@@ -228,7 +228,7 @@ func TestSetProviderSpecficProperty(t *testing.T) {
 			key:      "key1",
 			value:    "value1",
 			expected: []ProviderSpecificProperty{
-				ProviderSpecificProperty{
+				{
 					Name:  "key1",
 					Value: "value1",
 				},
@@ -245,7 +245,7 @@ func TestSetProviderSpecficProperty(t *testing.T) {
 					"example.org", "example.com", "1.2.4.5",
 				},
 				ProviderSpecific: []ProviderSpecificProperty{
-					ProviderSpecificProperty{
+					{
 						Name:  "name1",
 						Value: "value1",
 					},
@@ -256,11 +256,11 @@ func TestSetProviderSpecficProperty(t *testing.T) {
 			value:              "value2",
 
 			expected: []ProviderSpecificProperty{
-				ProviderSpecificProperty{
+				{
 					Name:  "name1",
 					Value: "value1",
 				},
-				ProviderSpecificProperty{
+				{
 					Name:  "name2",
 					Value: "value2",
 				},
@@ -277,15 +277,15 @@ func TestSetProviderSpecficProperty(t *testing.T) {
 					"example.org", "example.com", "1.2.4.5",
 				},
 				ProviderSpecific: []ProviderSpecificProperty{
-					ProviderSpecificProperty{
+					{
 						Name:  "name1",
 						Value: "value1",
 					},
-					ProviderSpecificProperty{
+					{
 						Name:  "name2",
 						Value: "value2",
 					},
-					ProviderSpecificProperty{
+					{
 						Name:  "name3",
 						Value: "value3",
 					},
@@ -295,15 +295,15 @@ func TestSetProviderSpecficProperty(t *testing.T) {
 			value:              "value2",
 			expectedIdentifier: "newIdentifier",
 			expected: []ProviderSpecificProperty{
-				ProviderSpecificProperty{
+				{
 					Name:  "name1",
 					Value: "value1",
 				},
-				ProviderSpecificProperty{
+				{
 					Name:  "name2",
 					Value: "value2",
 				},
-				ProviderSpecificProperty{
+				{
 					Name:  "name3",
 					Value: "value3",
 				},
@@ -320,7 +320,7 @@ func TestSetProviderSpecficProperty(t *testing.T) {
 					"example.org", "example.com", "1.2.4.5",
 				},
 				ProviderSpecific: []ProviderSpecificProperty{
-					ProviderSpecificProperty{
+					{
 						Name:  "name1",
 						Value: "value1",
 					},
@@ -330,7 +330,7 @@ func TestSetProviderSpecficProperty(t *testing.T) {
 			value:              "value2",
 			expectedIdentifier: "identifier",
 			expected: []ProviderSpecificProperty{
-				ProviderSpecificProperty{
+				{
 					Name:  "name1",
 					Value: "value2",
 				},
@@ -363,7 +363,7 @@ func TestDeleteProviderSpecificProperty(t *testing.T) {
 			name: "name and key are not matching",
 			endpoint: Endpoint{
 				ProviderSpecific: []ProviderSpecificProperty{
-					ProviderSpecificProperty{
+					{
 						Name:  "name1",
 						Value: "value1",
 					},
@@ -371,7 +371,7 @@ func TestDeleteProviderSpecificProperty(t *testing.T) {
 			},
 			key: "name2",
 			expected: []ProviderSpecificProperty{
-				ProviderSpecificProperty{
+				{
 					Name:  "name1",
 					Value: "value1",
 				},
@@ -381,15 +381,15 @@ func TestDeleteProviderSpecificProperty(t *testing.T) {
 			name: "some keys are matching and some keys are not matching",
 			endpoint: Endpoint{
 				ProviderSpecific: []ProviderSpecificProperty{
-					ProviderSpecificProperty{
+					{
 						Name:  "name1",
 						Value: "value1",
 					},
-					ProviderSpecificProperty{
+					{
 						Name:  "name2",
 						Value: "value2",
 					},
-					ProviderSpecificProperty{
+					{
 						Name:  "name3",
 						Value: "value3",
 					},
@@ -397,11 +397,11 @@ func TestDeleteProviderSpecificProperty(t *testing.T) {
 			},
 			key: "name2",
 			expected: []ProviderSpecificProperty{
-				ProviderSpecificProperty{
+				{
 					Name:  "name1",
 					Value: "value1",
 				},
-				ProviderSpecificProperty{
+				{
 					Name:  "name3",
 					Value: "value3",
 				},
@@ -411,7 +411,7 @@ func TestDeleteProviderSpecificProperty(t *testing.T) {
 			name: "name and key are matching",
 			endpoint: Endpoint{
 				ProviderSpecific: []ProviderSpecificProperty{
-					ProviderSpecificProperty{
+					{
 						Name:  "name1",
 						Value: "value1",
 					},