mirror of
https://github.com/Jguer/yay.git
synced 2026-05-04 20:06:09 +02:00
3b79933638
* Test coverage hardening and parallel-safe refactors Add focused test coverage for under-tested operational paths, edge branches, and make key table-driven suites parallel-safe. Also fixed flaky installer test execution under repeated/parallel runs. * chore: fix goimports ordering for golangci-lint * Test(download): expand integration coverage for download paths Add integration scenarios for force/pull repo updates, repo-only and skip semantics, and direct AUR download/scanner coverage used by getpkgbuild and package preparation. * Test(exe): relax systemd-run path assertion Fix flaky TestBuildGitCmd by accepting an absolute systemd-run path while still asserting the expected binary is used. * Test(text): avoid race in color tests Remove parallel execution from TestColorHash so global UseColor writes do not overlap with color consumers in parallel tests and trigger race detector failures. * fix potential race conditions
75 lines
2.0 KiB
Go
75 lines
2.0 KiB
Go
//go:build !integration
|
|
// +build !integration
|
|
|
|
package exe
|
|
|
|
import (
|
|
"context"
|
|
"io"
|
|
"path/filepath"
|
|
"strings"
|
|
"testing"
|
|
|
|
"github.com/stretchr/testify/require"
|
|
|
|
"github.com/Jguer/yay/v12/pkg/settings/parser"
|
|
"github.com/Jguer/yay/v12/pkg/text"
|
|
)
|
|
|
|
func TestBuildGitCmd(t *testing.T) {
|
|
t.Parallel()
|
|
|
|
logger := text.NewLogger(io.Discard, io.Discard, strings.NewReader(""), false, "test")
|
|
runner := &MockRunner{}
|
|
builder := &CmdBuilder{
|
|
GitBin: "git",
|
|
Runner: runner,
|
|
SudoBin: "su",
|
|
Log: logger,
|
|
}
|
|
|
|
cmd := builder.BuildGitCmd(context.Background(), "repo", "status")
|
|
if filepath.Base(cmd.Path) == "git" {
|
|
require.Equal(t, []string{"git", "-C", "repo", "status"}, cmd.Args)
|
|
require.NotContains(t, strings.Join(cmd.Env, "|"), "GIT_WORK_TREE=")
|
|
require.NotContains(t, strings.Join(cmd.Env, "|"), "GIT_DIR=")
|
|
} else {
|
|
require.Equal(t, "systemd-run", filepath.Base(cmd.Path))
|
|
}
|
|
}
|
|
|
|
func TestBuildPacmanCmd(t *testing.T) {
|
|
t.Parallel()
|
|
|
|
logger := text.NewLogger(io.Discard, io.Discard, strings.NewReader(""), false, "test")
|
|
builder := &CmdBuilder{
|
|
PacmanBin: "pacman",
|
|
PacmanConfigPath: "/etc/pacman.conf",
|
|
PacmanDBPath: t.TempDir(),
|
|
Runner: &MockRunner{},
|
|
Log: logger,
|
|
}
|
|
|
|
args := parser.MakeArguments()
|
|
args.AddArg("Q")
|
|
cmd := builder.BuildPacmanCmd(context.Background(), args, parser.ModeAny, true)
|
|
require.Equal(t, "pacman", filepath.Base(cmd.Path))
|
|
require.Contains(t, strings.Join(cmd.Args, " "), "--noconfirm")
|
|
require.Contains(t, strings.Join(cmd.Args, " "), "--config /etc/pacman.conf")
|
|
require.Contains(t, strings.Join(cmd.Args, " "), "--")
|
|
}
|
|
|
|
func TestBuildPrivilegeElevatorCommand(t *testing.T) {
|
|
t.Parallel()
|
|
|
|
logger := text.NewLogger(io.Discard, io.Discard, strings.NewReader(""), false, "test")
|
|
builder := &CmdBuilder{
|
|
SudoBin: "su",
|
|
Runner: &MockRunner{},
|
|
Log: logger,
|
|
}
|
|
cmd := builder.buildPrivilegeElevatorCommand(context.Background(), []string{"echo", "hello"})
|
|
require.Equal(t, "su", filepath.Base(cmd.Path))
|
|
require.Equal(t, []string{"su", "-c", "echo hello"}, cmd.Args)
|
|
}
|